From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 004AF2F39A6 for ; Mon, 24 Nov 2025 10:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980207; cv=none; b=p82dhhjGqth8KR2Idgon7B4AfsnjC3xXJ1+2P5xV8saVsV/lin8gE4SNLNnpYRjsKJPjFM+3uixDWA5beujOW+0W5tk04LT46JCqq66NAGQn23ygk28RPWx5DyG4bC/bsnlMWUz06AQiqpb8x5OKyq/bfCKCxHBVEUKRwPL7x1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980207; c=relaxed/simple; bh=MyhVfaLuUMB4FJ2DvvqxwnUvFdn4Yuvt+apgQWbex0s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rc11U1z73PhR4kOSTXIimvYBBsnNp84tDu2GHBj/UCgYoBoMi9Ks+1pNVxQhReTn627H1rFoM2i5P5vZEfDpEq4m7qLjbVf4YP4PpDlP0caJbbjpCYmDWDfpvtfKcazyHgPkRzFms4ytWo86fcOmqrLEzTq33fqc4VdKlB2BXIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ECDxxOF1; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ECDxxOF1" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-37a56a475e8so35176751fa.3 for ; Mon, 24 Nov 2025 02:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763980204; x=1764585004; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UvxeS/74nBAEFSf4nVKv65BSIxiE58qrGcTM82uuMOU=; b=ECDxxOF15SkpmV4wHDvS5vhvIrvhf2TPfyhsX4aNkwpQM7Be0/7ZXbn+FzK8dAHr1Q no39YRubplHtxdKeEbemSBhHvygFFhpPlo2+FT5edFLymTbrP66VWwkb99DEMaTBA0hP QtvtvUE0RTfRD5kiBcQGnF7Bb/ucTw9M3+iwtwAhi+pw9kh2KE3cDA8meAelioIAR/NR ZG3OsMyxD2ZxWyRJg/635A+WHn+SVME4QjH1maW/5VxrzklMI3sSK6+N6BlOAaaJMH8W +9URKdlzMX734ETXfZxmdf4KCMO+L5uhRut6ZUSASze0qZPHPsj47ZdDlRCSk5pq08+/ tT1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763980204; x=1764585004; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UvxeS/74nBAEFSf4nVKv65BSIxiE58qrGcTM82uuMOU=; b=fzdmA6LoU4vmh088gsg3GyEvWognCbtftRYJ9V02AdfocAXFLQvKXG/EN6TXWeFQea ZFHE/OQHBl9SY+sZpChA1e4kAS5eZbly23U7HMpig9utXvTlBwJSM/U6LZICZSUp5Eh9 LA2yyc3lJwyj9eVJ1+IaO0sCx/l2pB40cKe/7CKgTY6VlM4QUFLuozXBPsarriyFdNwi Gjc0dBJh225gmbtSlMfa2IjOLkgT0sUvfTDgwuQa2YB1eGIKi2urX38kl4Rz51Kzt/ty G4yQyiZl7m1Dbys5Tw/fxVKN8K51QZji00HdqCGPcMd6XI+xVrdcQndUlj+SYS0QhKIy ss6Q== X-Forwarded-Encrypted: i=1; AJvYcCW6eKY/SViFyMe/fX1cNded+LrbFPwpQcs3mEdeSHnvo6pN+jI0/nkbZrV+/xZPFAf77OyH20wh6CZjQIc=@vger.kernel.org X-Gm-Message-State: AOJu0YwEXSdwaB+PuJQaQrTVff+/6LJ1iunq6/n35PZd3bBM7M6BKHRo JTSdsnxXXtuU1oVvMHiyItfYM19+Ibum5+Cs//DkL51wE8mUbhmTa/yG9VHEPzD9 X-Gm-Gg: ASbGncsCYW/k85q0QmfyeIrvw5s6kqIk7GCMywauc1juy/ZKxiJRod9vvN/vbfKP//B ar7xbJv1rw0Tp+jSAeCJeEIriM9RlluDxKmSGe25CHxdHgPfQBUhWTiSLExs63P/vcIUtBLi1k1 DS4UA/yowiJKP7XmyVpeyzJXNqXUK+cJQQUr975VdRoQFEugwsxau8vxAWupeDGz6w2+t7d2t7R QQzr/QDg/+3Hacpbl2m9y5FdDugdpJ43WEbhP2fPCjC1fxXQzcgxKSC9SchHbSaQV7f0MB6o0rL 5fWuMyMJOnqSm9ywhKyJGrPTq222uJvmJbHlNvSZ6v1Ig/HIt3Aj3NJOUpqRcnQeKwWIcJNqaor UrNZFmdHnuVgiX0dQSRx6fCb/vtjf/eNEGWAJ+cKHtXDBOCLNGZXywr6jzpTeGo3ALhM2Rf1EIg KYBM4KgYrNv/RizQ== X-Google-Smtp-Source: AGHT+IGzb+yApYHtjewkoQzx7FPWIVvgfb9lCElhP6A4EWOQNvayCoMjjLyY5L5QUpilRr8Cj3haxw== X-Received: by 2002:a05:6512:104a:b0:595:90ee:f476 with SMTP id 2adb3069b0e04-596a3edab46mr4292946e87.28.1763974136131; Mon, 24 Nov 2025 00:48:56 -0800 (PST) Received: from [10.38.18.76] ([213.255.186.37]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5969dbc5c5dsm4019850e87.79.2025.11.24.00.48.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 00:48:55 -0800 (PST) Message-ID: <6ee209b3-4d7a-45a8-bd65-6a51730d458d@gmail.com> Date: Mon, 24 Nov 2025 10:48:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] Revert "treewide: Fix probing of devices in DT overlays" To: Saravana Kannan , Herve Codina , Greg Kroah-Hartman , "Rafael J. Wysocki" , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Wolfram Sang , Rob Herring , Mark Brown , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Geert Uytterhoeven Cc: kernel-team@android.com, Wolfram Sang , linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, Matti Vaittinen References: <20240411235623.1260061-1-saravanak@google.com> <20240411235623.1260061-2-saravanak@google.com> Content-Language: en-US From: Kalle Niemi In-Reply-To: <20240411235623.1260061-2-saravanak@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/12/24 02:56, Saravana Kannan wrote: > This reverts commit 1a50d9403fb90cbe4dea0ec9fd0351d2ecbd8924. > > While the commit fixed fw_devlink overlay handling for one case, it > broke it for another case. So revert it and redo the fix in a separate > patch. > > Fixes: 1a50d9403fb9 ("treewide: Fix probing of devices in DT overlays") > Reported-by: Herve Codina > Closes: https://lore.kernel.org/lkml/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJgyo8x6=9F9rZ+-KzjOg@mail.gmail.com/ > Closes: https://lore.kernel.org/all/20240221095137.616d2aaa@bootlin.com/ > Closes: https://lore.kernel.org/lkml/20240312151835.29ef62a0@bootlin.com/ > Signed-off-by: Saravana Kannan > --- > drivers/bus/imx-weim.c | 6 ------ > drivers/i2c/i2c-core-of.c | 5 ----- > drivers/of/dynamic.c | 1 - > drivers/of/platform.c | 5 ----- > drivers/spi/spi.c | 5 ----- > 5 files changed, 22 deletions(-) > > diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c > index 837bf9d51c6e..caaf887e0ccc 100644 > --- a/drivers/bus/imx-weim.c > +++ b/drivers/bus/imx-weim.c > @@ -331,12 +331,6 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action, > "Failed to setup timing for '%pOF'\n", rd->dn); > > if (!of_node_check_flag(rd->dn, OF_POPULATED)) { > - /* > - * Clear the flag before adding the device so that > - * fw_devlink doesn't skip adding consumers to this > - * device. > - */ > - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; > if (!of_platform_device_create(rd->dn, NULL, &pdev->dev)) { > dev_err(&pdev->dev, > "Failed to create child device '%pOF'\n", > diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c > index a6c407d36800..a250921bbce0 100644 > --- a/drivers/i2c/i2c-core-of.c > +++ b/drivers/i2c/i2c-core-of.c > @@ -178,11 +178,6 @@ static int of_i2c_notify(struct notifier_block *nb, unsigned long action, > return NOTIFY_OK; > } > > - /* > - * Clear the flag before adding the device so that fw_devlink > - * doesn't skip adding consumers to this device. > - */ > - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; > client = of_i2c_register_device(adap, rd->dn); > if (IS_ERR(client)) { > dev_err(&adap->dev, "failed to create client for '%pOF'\n", > diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c > index 4d57a4e34105..19a1a38554f2 100644 > --- a/drivers/of/dynamic.c > +++ b/drivers/of/dynamic.c > @@ -224,7 +224,6 @@ static void __of_attach_node(struct device_node *np) > np->sibling = np->parent->child; > np->parent->child = np; > of_node_clear_flag(np, OF_DETACHED); > - np->fwnode.flags |= FWNODE_FLAG_NOT_DEVICE; > > raw_spin_unlock_irqrestore(&devtree_lock, flags); > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > index 389d4ea6bfc1..efd861fa254f 100644 > --- a/drivers/of/platform.c > +++ b/drivers/of/platform.c > @@ -743,11 +743,6 @@ static int of_platform_notify(struct notifier_block *nb, > if (of_node_check_flag(rd->dn, OF_POPULATED)) > return NOTIFY_OK; > > - /* > - * Clear the flag before adding the device so that fw_devlink > - * doesn't skip adding consumers to this device. > - */ > - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; > /* pdev_parent may be NULL when no bus platform device */ > pdev_parent = of_find_device_by_node(rd->dn->parent); > pdev = of_platform_device_create(rd->dn, NULL, > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index ff75838c1b5d..17cd417f7681 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -4761,11 +4761,6 @@ static int of_spi_notify(struct notifier_block *nb, unsigned long action, > return NOTIFY_OK; > } > > - /* > - * Clear the flag before adding the device so that fw_devlink > - * doesn't skip adding consumers to this device. > - */ > - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; > spi = of_register_spi_device(ctlr, rd->dn); > put_device(&ctlr->dev); > Hello, Test system testing drivers for ROHM ICs bisected this commit to cause BD71847 drivers probe to not be called. The devicetree blob overlay describing bd71847 enables I2C1 bus on BeagleBone Black aswell. Probe is called when the driver is used with HW connected to I2C2 bus. I2C2 bus is enabled before overlaying devicetree blobs. ---- BD71847 Devicetree overlay source ---- /dts-v1/; /plugin/; /{ /* this is our device tree overlay root node */ compatible = "ti,beaglebone", "ti,beaglebone-black"; part-number = "BBB-I2C1"; version = "00A0"; fragment@0 { target = <&am33xx_pinmux>; // this is a link to an already defined node in the device tree, so that node is overlayed with our modification __overlay__ { i2c1_pins: pinmux_i2c1_pins { pinctrl-single,pins = < 0x158 0x72 /* spi0_d1.i2c1_sda */ 0x15C 0x72 /* spi0_cs0.i2c1_sdl */ >; }; }; }; .... .... fragment@2 { target = <&i2c1>; __overlay__ { pinctrl-0 = <&i2c1_pins>; clock-frequency = <100000>; status = "okay"; pmic: pmic@4b { /* the "test" defined as child of the i2c1 bus */ compatible = "rohm,bd71847"; reg = <0x4b>; .... .... }; /* root node end */ ---- END OF BD71847 Devicetree overlay source ---- Reverting this patch from linux-next from last friday fixes the issue. BR Kalle Niemi