From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D76242A79F for ; Tue, 21 Jul 2026 07:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784619663; cv=none; b=lbS44xFeGwc0XmjZitMrbdyG+eg6YfQqvSDJSmXmJtMSsYInkDrN/kZrmjAC942Kwr1SQqh0UugtEkSn/yRpL4U/3OKG1MfdcZl025wWC0TU3yEg9yZYI+kdBO5iQm96gAKOtVONpeuNtbGndsv0iL3tq6ye4fzsZ22htMG1nPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784619663; c=relaxed/simple; bh=AGCSHhzNWPhx56WFUP0NFupamjbwzH52rSwHHYx7zlw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gc027RJOnY3JMW83nqRTfyngyz2oUfvyHuxaZ2uw2F9G/Nopg2yMtjeqy00WZM0pW8pJIuhh2Jhk5k87nRPpZivZrTdUDVCQpssDMoj8J0/mLYK+1r8nt31Jp8ldvpD8mCLJCKlOfG/0DwVhyHC72JISaZIMtkNCP1vkD+jZaXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j73ce9Bd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WbacIvhV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j73ce9Bd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WbacIvhV" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66L6Ok1P933318 for ; Tue, 21 Jul 2026 07:41:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= R5u/F8c1Z6uNv+y3K8dxZbgvRMHAOcVf9LRk7KX6thM=; b=j73ce9BdE8wIZNnD eOl+BQ2TQ7bAhWE7Ob2vEjBLWYp+81BWg+eMbcHmq7uNjtTHuMqw+vBHF2fFnYZy FJFXcDlJnMPTY8AZELYgsH2tNHPelWSjy+lPmAVid34A3WDsMXxkdInr6QlsCQBB pTyfk2Mb42Qnmw3xcdBN9I06QE4014Pb9EcS8IqfZK4geE1WSCcPvOQE1K5R4dj2 +2b6H1euqETYnRuFfCyTkml43ZOqklHZbEXpkISG+sDTpxYVC+O9PsvEEgjjOK7z Mf2MjvPPgDq/M3xeJ6RpMBezCwKTSnCGoPBeOl1fXtLvU6TcQS8tlrYVhHgWlL9k tplpMw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhqv5u0bu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 07:41:01 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ccb687f82eso157124605ad.3 for ; Tue, 21 Jul 2026 00:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784619661; x=1785224461; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=R5u/F8c1Z6uNv+y3K8dxZbgvRMHAOcVf9LRk7KX6thM=; b=WbacIvhV0c7qeH6vx41HPrt5Dzg6ELCMlSvbxXyrul8FzEcUJ8IabtpvxRfmGzuA7r UU2w0/GJigalaBKrStT8HL/N+zcs0fQwgX73wICD1YN2GVHrd0YswAqDwFnF4GNL3Ak6 KM2yPKkt2LEKtihpz1ttU2k80J6vJkwOWEdeFYX803RZoLqeSVRu46SPRvwTMiSvbpwN zpY9FcdoO83KeOKma5oEfiyvsHQqJr4H3ebT4QqVyjgdx3GeR75lA0Nvl6hjjSQl+tuy cV0zyWQpzjwKUCvVl5bG+bnIgrCBvhcNih5da30pj/awxM/lqKPEnQGGDJ5jzyJffEEg KqSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784619661; x=1785224461; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=R5u/F8c1Z6uNv+y3K8dxZbgvRMHAOcVf9LRk7KX6thM=; b=nTSqaIKPZJ63ktJwHw0UTFc1LmB5nR3vJiigOGTqhm5kVnIjpo0hILDRtz39TO9/VV 40og/3MxqxYjAGvF5RKf5RvDd6I44pUir+AolDreDW4PAbAc6QXuSQK21w/s2y0AtWH9 k93o3lJJuoWhe5+86FUuf5Bqv5tSICVfq7bqWG51yffQ/SnaAc7v7T6KsyELClo71Ag0 FlcSHR6/XTSdDbZocvwxTB8G6/exx6THokS/4fB0doEVGcSz4N/pR4ze68RyfvY2s/cr nPVIl5iQKtDGTyW5FQl4AGDQEQ2W/4WW8R2Nf9V1EsX4IhFz9gY906xEPJ6j3Qber+nt IvFw== X-Forwarded-Encrypted: i=1; AHgh+Ros8cC86Y9f1zRRczn3yUyUcnN6aiZPrv/5Vd3f/INpAwmndyDR5r1BQdhEW4mNct1PJYs1IZp65o3Wzuo=@vger.kernel.org X-Gm-Message-State: AOJu0YwHEboYz19hJecO+xu2V3rFHpGIJih+9QjRjVdASEf/M6Kh2tSF tZUHQnYfy25Ldk2K5/mGbnM/sNkB3g48j+jjWtDrnTPKMaC3Ccb7eI9hOyev5YmC5ST+neup4je 0JdBbtwNAPe2LE1d1xhXulu0AXs0g2JrrmRUi14gINn/IPulerYhW0zEZnsnpNnA5j9s= X-Gm-Gg: AfdE7ckH1aXtlCQaL0gaUQNKuz6MYPxDwwhkfMsfZXy0Vt4qlG1/IoxVBu04SOJzA+l yUcUqdrJkN8AzTTlGUaynRR2Zh1/ELgn5LbAX6MU4fOQFiYNHF5rMOyzvhzm7PZaaufuM60c3s8 M85yqaB1BvX4Qg/VcnPLv4/14fs+1uwq2uTo+qXD69MySbuvTeLuOtmmPsxNJJN0EPZ7mek+oWl ZqFOJ3yfKWFFfY8qmaCc1z5h8K0Oq0zZQhpXHQqxKYNBI3LE20Fc3X/P521SE+hwWqNWrZjF9HQ Wvu+6snpNHLQ+5yN5nTDU+vigMH6XkyvgsWgjSfcUztwENBS7A8x3CNZml5GIZwX/esd5xA0MUS Jcuwrhh9f0JLK2w+WbSZDhf7aPkhLDox8Yjk9hOne01dWZId5RlFKYLXl5GgBWWmeQ8AgU8Yc X-Received: by 2002:a17:903:3b8f:b0:2cc:d192:50b8 with SMTP id d9443c01a7336-2cf34a31907mr193526575ad.47.1784619660931; Tue, 21 Jul 2026 00:41:00 -0700 (PDT) X-Received: by 2002:a17:903:3b8f:b0:2cc:d192:50b8 with SMTP id d9443c01a7336-2cf34a31907mr193526385ad.47.1784619660474; Tue, 21 Jul 2026 00:41:00 -0700 (PDT) Received: from [10.133.33.82] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf3448dac2sm70879125ad.3.2026.07.21.00.40.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 00:41:00 -0700 (PDT) Message-ID: <6ef27e6d-4313-4655-b166-987185e67ae3@oss.qualcomm.com> Date: Tue, 21 Jul 2026 15:40:57 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] wifi: ath11k: fix resource leak on error in ext IRQ setup To: ZhaoJinming , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org References: <181b5ee0-f002-4f5e-93ff-49b6aa0a6e61@oss.qualcomm.com> <20260721072128.142668-1-zhaojinming@uniontech.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260721072128.142668-1-zhaojinming@uniontech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: KJ9HswZ1QgM0lrxZXuFZ3R_zG2xBLiUQ X-Proofpoint-ORIG-GUID: KJ9HswZ1QgM0lrxZXuFZ3R_zG2xBLiUQ X-Authority-Analysis: v=2.4 cv=e+U2j6p/ c=1 sm=1 tr=0 ts=6a5f228d cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=iHwBjlyiAAAA:8 a=EUspDBNiAAAA:8 a=oLTilD6pKAFhNrx_43MA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=uNSKXYNwxGiU6LD0JREI:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDA3OSBTYWx0ZWRfXzWWKYrHxv9bx 8xDn9gikT5C8s75C4zC8lOKEF65ryUwVvHNzcDFqWWekuRgOh/DI2O/rs/JoR8RjvbPq0er9C03 vg8sk1mNaUBOKbqK6bWD6jxDBCRShyQ= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDA3OSBTYWx0ZWRfX7RJPajelzFzq 3zuyU8fxO2DFb+uFXWIwmKD7S82C8dCpuMZPP/Np19OiPJzKpcyFyhihLck5qa5GPK1Yrnohq+n /ZtkfU7iS3yFz+1W+gUu3DdvPbj/B8ZISA8xi+JwHl9mfGSane6dzrq/8WV8haq3erbNdociAKO Nc0ClTvWrWQVP+E7QA5mO3bJ0JFjIrPZ6VHmVGCnmgfb/GMWs1kNjN+fF3F92Bn7DCuDTKqfPfQ b1XuZKAkfoxiX8vEnfBmwIVIlsuBshwdLO97McrRISvvhvJg5QtGSs7S+Fb0UdPIQpzWd5c67ij VhZNqLrPWLjiL9wgL8aE63O0gufpC+eN8Xefex1mv4ZFKkpoaA8qZpyJbvr//eUWBdBeoaf7pBn grMyqSu1mizGjlv3j4R18QesFOrPNtx9c/vhmaZaBPmO6hfLOvivH6PuIzCOi0Wnqehrq2p/Nu0 ajsCKLbpRXCjraUev4A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210079 On 7/21/2026 3:21 PM, ZhaoJinming wrote: > In ath11k_ahb_config_irq(), when a CE request_irq() fails, the function > returns the error immediately without freeing the CE IRQs that were > successfully registered in previous loop iterations. The probe error > path does not call ath11k_ahb_free_irq() either, so the previously > registered CE IRQ handlers remain attached to the interrupt lines and > are never released. > > In ath11k_ahb_config_ext_irq(), when an external request_irq() fails, > the error is only logged and the loop continues. The function then > returns 0 indicating success, leaving the device in a partially > configured state where some external IRQs are not registered. This > causes enable_irq()/disable_irq()/free_irq() to be called on > unregistered IRQs during runtime and remove/shutdown, triggering > WARN_ON(!desc->action), and missing interrupt handlers lead to data > loss. > > Additionally, if alloc_netdev_dummy() fails for a later IRQ group, the > function returns -ENOMEM without freeing the ext IRQs and napi_ndev > that were successfully set up for earlier groups. > > Fix all three issues: propagate the error up to the caller and unwind > all successfully registered IRQs and allocated resources on failure. > > Signed-off-by: ZhaoJinming Reviewed-by: Baochen Qiang