From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192AbdKMPKx (ORCPT ); Mon, 13 Nov 2017 10:10:53 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:47672 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752752AbdKMPKw (ORCPT ); Mon, 13 Nov 2017 10:10:52 -0500 Cc: Arnd Bergmann , Sudeep Holla , Thomas Gleixner , Benjamin Gaignard , LKML Subject: Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init To: Daniel Lezcano References: <20171106133450.482858-1-arnd@arndb.de> <20171113101107.GA9084@e107155-lin> <6cdbbe9b-309a-7cb9-648f-7df2295c510f@linaro.org> From: Sudeep Holla Organization: ARM Message-ID: <6ef431ab-54c4-00c3-852a-7e448ccaa837@arm.com> Date: Mon, 13 Nov 2017 15:10:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <6cdbbe9b-309a-7cb9-648f-7df2295c510f@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/11/17 14:58, Daniel Lezcano wrote: > On 13/11/2017 11:11, Sudeep Holla wrote: [..] >> >> Agreed, may be if we add users which is called from init functions, the >> warning should disappear. Also as tglx suggested, we could rename if it's >> just used from init function error/exit paths. > > The drivers are not compiled as module AFAICT, the function will be > called in the init error path. > Understood, IMO better to rename the functions as cleanup or something similar. exit made it sound differently and since there were no users, I assumed it to be used in remove/exit functions. Sorry for the noise. -- Regards, Sudeep