From: Randy Dunlap <rdunlap@infradead.org>
To: decui@microsoft.com, willy@infradead.org, netdev@vger.kernel.org,
davem@davemloft.net, willemb@google.com, kuba@kernel.org,
simon.horman@netronome.com, sdf@google.com, edumazet@google.com,
fw@strlen.de, jonathan.lemon@gmail.com, pablo@netfilter.org,
jeremy@azazel.net, pabeni@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net] skbuff.h: Improve the checksum related comments
Date: Sun, 5 Apr 2020 18:42:33 -0700 [thread overview]
Message-ID: <6efee6bb-d68d-0f83-d469-b173cf4f5d0f@infradead.org> (raw)
In-Reply-To: <1586136369-67251-1-git-send-email-decui@microsoft.com>
On 4/5/20 6:26 PM, Dexuan Cui wrote:
> @@ -211,9 +211,9 @@
> * is implied by the SKB_GSO_* flags in gso_type. Most obviously, if the
> * gso_type is SKB_GSO_TCPV4 or SKB_GSO_TCPV6, TCP checksum offload as
> * part of the GSO operation is implied. If a checksum is being offloaded
> - * with GSO then ip_summed is CHECKSUM_PARTIAL, csum_start and csum_offset
> - * are set to refer to the outermost checksum being offload (two offloaded
> - * checksums are possible with UDP encapsulation).
> + * with GSO then ip_summed is CHECKSUM_PARTIAL, and both csum_start and
> + * csum_offset are set to refer to the outermost checksum being offload (two
being offloaded
> + * offloaded checksums are possible with UDP encapsulation).
> */
>
> /* Don't change this without changing skb_csum_unnecessary! */
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
--
~Randy
next prev parent reply other threads:[~2020-04-06 1:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 1:26 Dexuan Cui
2020-04-06 1:42 ` Randy Dunlap [this message]
2020-04-06 1:51 ` Dexuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6efee6bb-d68d-0f83-d469-b173cf4f5d0f@infradead.org \
--to=rdunlap@infradead.org \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=jeremy@azazel.net \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=sdf@google.com \
--cc=simon.horman@netronome.com \
--cc=willemb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®