From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81A3C2236EE for ; Fri, 3 Jul 2026 23:12:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783120367; cv=none; b=O6Y4p5oAI4b59JQF3JPMGSDvsZ32BG/ooIPnGi5gFPlwShi5250dsWZ2CryAjXmzaj+xR3w/b17AG0sW735SScgE3ATKNUEi/kzJP+WZW7x/lv5odb3ULzd/4Jl8HIuzgSwV9SsFoKzaoxUM9wfzgiBZTDAV87xtyTQdfaNUnfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783120367; c=relaxed/simple; bh=u4LQYJOWirbCrWOLISyUVhSJn5uCp/8k1nYDfOpOI0s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NntSNrebPFWc9Z3xeMxjiecWd6YRlcQmCvC/lBcLNz4ojreUa8uluyAHP8Jjr+rV9zuZJJ88GT8a5QrBew8Z/n1mkZKJlsMxPY1tC0EcMA5xARxn2knEWnvXuxJRaw/SHnJfdUX+Zr9FqmvRlwNfMk5A1IhxB5m0VZrUT4de7Z4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MwuefZpS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L82nn+v5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MwuefZpS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L82nn+v5" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663KPTUV1019188 for ; Fri, 3 Jul 2026 23:12:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=ptvjiVFY55mHuzyR7IOPZN3q jRdO4GwgfZdidGQ+xdk=; b=MwuefZpSFTvuNgJyrkHy6OEbxdQIh4zwoxkeV0v1 SeNT+DdlpzYtM/NzLKO5cRhFyyJnebuIF5IKibnQH9YpiTNtspV6uDvHww+LUUZw Z26z8Ghqy1Bdy97MgjMlCybQAcNvxhH7AanAObFO0nN5IPodyrTpWh3DwjILH5JS lGZlFabkn+OlzqLPqxZPmZYtMum9AdRVSTRs/wP4GOzKS3Aj0HWCmra/f6MkDSMw qYaBJCD0DDY6/4P6Rd9xzPP5E3hUq7S5beve23YXYe29Mo8LO5BMBx2bJeVN/Pjr eFrVkDRH+FB3sjLbh5P/z/JAV4UUnzJ+/KZJdzBA5COZEg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6ckj20jt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 23:12:43 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8f18c4d1f82so14180376d6.2 for ; Fri, 03 Jul 2026 16:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783120363; x=1783725163; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ptvjiVFY55mHuzyR7IOPZN3qjRdO4GwgfZdidGQ+xdk=; b=L82nn+v5OgZ8kdhpgP6U9sUfutbeAxdFs6Rsk8+2d1gNIQBRrsSe36u7E5F+Md9pN3 Tgw1jU/YfrruDI4Kk1eyFmovNwMkV/YbtOAU4weS3G/BkVTJ4sY1pPQH64EpzJ40kG1U 7WllAp2wGqKWZgAShQq9tMk5yYfDxZBJLC8QJCy/XFBsfZppsA8zX7GMK3kQKEC3u8uN 5KV9ZN9BztN9NJicXhWO2wZqIflc88RPcl/DE33qB8c5uLy0Ab3sfLRXWMraUCw9Olqe 5mOGotL3uWGomp0Xd0Mb70sSANoSu62bprVWwUw0K++g8S6MYTqWs+YJ9nST69xKUUCU 5b0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783120363; x=1783725163; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ptvjiVFY55mHuzyR7IOPZN3qjRdO4GwgfZdidGQ+xdk=; b=GDRzvCY8pRXvJo6lw8uI4XFLIodNeVNu443Q4NT7Lirof/N2UXGvcMyEHH6xT5iOPp 1LwVPAAq+1Q/vT7gLw+LQLCq3ZO4LL1Y8ZthK35BYitRsWf3JWygE55LSHUo5398+m9a xnhnNbq/bzrLAP4NpOlMwIqsBXduEctruyeKZq8tSDVNc/zzDn5Ur4lS5GoS8ycJHuD8 g5FQB1OyZ47AQgxFW56KY3CMjIq8Q0Hwmg4uBwx/FVtwunh6B96HE/w3GTsdBFPu6910 bjL4Art/5YP+k1MZehPWEX8q6aIq9ddZfKc1Msi97eGdTAMUD++E1RzATF+qrTD3X1nA aohQ== X-Forwarded-Encrypted: i=1; AHgh+Ro4hmsHXMkQAsJUijJErCLIgNmsHn+tOP7FPJz+lEY315M/OI6zRsAlOI/BIujV214VqAV4G8hMHDiTWHs=@vger.kernel.org X-Gm-Message-State: AOJu0YxdEL9bbXl+3C36fD3KsNluIhpA7QxutJQg5uhFRm7chQhyH3t3 +fkJ9SCVGfM4beHoXja7aL/pEUCfsKDRbR2FtUW7oOT2+BRmlq18dhADYMWGxn99Kbxmj+NSML3 eUPY/ky4TAx5bLXHmkyx/qTWbztpwTOHHwC7oOGBlUi1OqWGgHMeTAySanrJAFum9aZ8= X-Gm-Gg: AfdE7cluHhaxsoTtEztfiELKX0J1iVQN7ILL2dv3pG0i5pjENqgAkixGCnMF3eTDq8W 31je5P160FoYWKcRbklHa8RCL3MlT6StpI1ANW4vfEndy+mRqnJ7VbvnTNq1+zUthx5t9HEa9a4 r3MljXeeBqDYfhuBjvyT9nOVBIXK2ThQWVbtjwoBmJfk5jTHesGHbjBjlAcwl7y0nzXXGRIiFtF eODCQeKy86FtNjiSS5be2eCQ4EvPZtis8LN7MJMvFuoimoR4xIkb1U8w9AtzRQwTsUWLkGc7uNn Z1Z+gwF3G3DfRZ2DujQkUFSSP8bHSPNapWTG80hvDX27kZDVAiCel7dSw+5HJccFKqBXhQAA67r YD9HHg1V2JjK9BnxHeGF6gl/8L9pLW6lYZXA4xe+UQ4/wvkimfVN/MpPNoe+EyQ7+3/r08CGQYG sSHzzD4x1ChS77nrh0629fjUeL X-Received: by 2002:ad4:5c82:0:b0:8ea:efae:ab2c with SMTP id 6a1803df08f44-8f74c0a468cmr20755386d6.38.1783120363142; Fri, 03 Jul 2026 16:12:43 -0700 (PDT) X-Received: by 2002:ad4:5c82:0:b0:8ea:efae:ab2c with SMTP id 6a1803df08f44-8f74c0a468cmr20754586d6.38.1783120362600; Fri, 03 Jul 2026 16:12:42 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aed13c3a0asm815528e87.71.2026.07.03.16.12.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 16:12:40 -0700 (PDT) Date: Sat, 4 Jul 2026 02:12:37 +0300 From: Dmitry Baryshkov To: Mukesh Ojha Cc: Bjorn Andersson , Konrad Dybcio , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Joel Stanley , Andrew Jeffery , Paul Cercueil , Anitha Chrisanthus , Paul Kocialkowski , Linus Walleij , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexey Brodkin , Laurent Pinchart , Tomi Valkeinen , Michal Simek , Daniel Scally , Jacopo Mondi , Mauro Carvalho Chehab , Eddie James , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Minghsiu Tsai , Houlong Wei , Matthias Brugger , AngeloGioacchino Del Regno , Joseph Liu , Marvin Lin , Dmitry Osipenko , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter , Srinivas Kandagatla , Arnd Bergmann , Greg Kroah-Hartman , Ge Gordon , Adrian Hunter , Ulf Hansson , Rob Herring , Saravana Kannan , Mathieu Poirier , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Liam Girdwood , Mark Brown , Frank Li , Sascha Hauer , Peter Ujfalusi , Bard Liao , Daniel Baluta , Orson Zhai , Baolin Wang , Peter Chen , Fugang Duan , Ekansh Gupta , BST Linux Kernel Upstream Group , Fabio Estevam , Nicolin Chen , Pengutronix Kernel Team , Kai Vehmanen , Pierre-Louis Bossart , Vijendar Mukunda , Chunyan Zhang , CIX Linux Kernel Upstream Group , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, linux-tegra@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-staging@lists.linux.dev, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, sound-open-firmware@alsa-project.org Subject: Re: [PATCH 03/42] firmware: qcom: scm: Use devm_of_reserved_mem_device_init() Message-ID: <6ejxrh43bkhryudrxk3lkzf2knlgv3mxtfgzhrzujw7km4n5bq@4bd2ahopzs4j> References: <20260703193855.110619-1-mukesh.ojha@oss.qualcomm.com> <20260703193855.110619-4-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260703193855.110619-4-mukesh.ojha@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDIzMyBTYWx0ZWRfX+lW5p3G9ek4F nBCSew167j2mJZNI71DBsbnwARistHdPafnVqg+9Id6JBm1Qy31c9s2z+s5TsHT4tdjKTenEzoD 86MXVb9tIoHDPeqQWHcqt66yCn+nAfY= X-Authority-Analysis: v=2.4 cv=E8v9Y6dl c=1 sm=1 tr=0 ts=6a4841eb cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=Dn8qeLIeI0d_esIdenwA:9 a=CjuIK1q_8ugA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-ORIG-GUID: sMvK81euruPuSBWOIPIieedXL_BwKzl2 X-Proofpoint-GUID: sMvK81euruPuSBWOIPIieedXL_BwKzl2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDIzMyBTYWx0ZWRfX5P16kMozh8Oe vHQVqLRzRT/1wpGrLHEXUXu9TH0+9w5xuAbyi86M8yXsyq7ZW9oDjX6yYZ46EFXAoUsLHWG+Iac iKz3BDY8fcjHXdvQTaLwG6MjOwsT3p2S2hgPvv+4TYIpVLXfx1qbjjmo/lmvxGGKcfI1Pysj5Du QTGcBAylQYnysUP/5LkjxWckyMl5pqh5LpI/iSy6mK5d3RLePE9ltNfejQbQfRV+h8EO4tJsyBn /tBO5aJTnOUhxSKkIhyxWJkC1gY68ReXJdU5SV6R/QeFn1HKsSspNkYvVUbJC9TBED+vTGfM1Ce UnP26M2i3EWcPkqGJenKbcGIBY8grREgA4vnSRI/H0/gLurAJtDyjlQFLs2+8hDXYaarZqScQgX /9EmwIhnm8N4sJdfncA8tytcDpqX2Cd9vDP9Vn2qmzpf5sDCg7U/hCPdpntDiBofEucPAfvd2zp EFs0ZGPp5QGzZV8sRxg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_04,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030233 On Sat, Jul 04, 2026 at 01:08:16AM +0530, Mukesh Ojha wrote: > Switch from of_reserved_mem_device_init() to the new resource managed > devm_of_reserved_mem_device_init() so that the reserved memory region > is released automatically on probe failure or device unbind. This > eliminates the err_rmem cleanup label and the need to call > of_reserved_mem_device_release() explicitly on error paths. > > Signed-off-by: Mukesh Ojha > --- > drivers/firmware/qcom/qcom_scm.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry