mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@linaro.org>
To: Mike Galbraith <efault@gmx.de>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Rik van Riel <riel@redhat.com>
Subject: Re: 9908859acaa9 cpuidle/menu: add per CPU PM QoS resume latency consideration
Date: Thu, 23 Feb 2017 21:58:47 +0800	[thread overview]
Message-ID: <6f016a9b-8968-e7c1-b1c7-c6b023431623@linaro.org> (raw)
In-Reply-To: <1487855304.4463.50.camel@gmx.de>



On 02/23/2017 09:08 PM, Mike Galbraith wrote:
> On Thu, 2017-02-23 at 13:15 +0100, Rafael J. Wysocki wrote:
>> On Wednesday, February 22, 2017 10:55:04 PM Alex Shi wrote:
>>>>
>>>> Its not hard; spinlock_t ends up being a mutex, and this is ran
>>>> from the
>>>> idle thread. What thread do you think we ought to run when we
>>>> block
>>>> idle?
>>>>
>>>
>>> Straight right.
>>> Thanks for explanations! :)
>>
>> I overlooked that, sorry.
>>
>> Shall we revert?
>>
>> I don't want RT to be broken because of this.
> 
> Just whacking the lock would take care of that.  The question is who is
> gonna use this, and what does it really buy them?  When I look at that
> commit, an eyebrow raises, lock or no lock.
> 

Right per cpu lock for per cpu data is unnecessary.

  reply	other threads:[~2017-02-23 14:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22 12:56 Mike Galbraith
2017-02-22 13:12 ` Peter Zijlstra
2017-02-22 13:19   ` Mike Galbraith
2017-02-22 14:31     ` Alex Shi
2017-02-22 14:39       ` Peter Zijlstra
2017-02-22 14:55         ` Alex Shi
2017-02-23 12:15           ` Rafael J. Wysocki
2017-02-23 13:08             ` Mike Galbraith
2017-02-23 13:58               ` Alex Shi [this message]
2017-02-23 13:55             ` Alex Shi
2017-02-23 22:34               ` Rafael J. Wysocki
2017-02-24  1:49                 ` Alex Shi
2017-02-24 12:25                   ` [PATCH] cpuidle: menu: Avoid taking spinlock for accessing QoS values Rafael J. Wysocki
2017-02-22 14:46       ` 9908859acaa9 cpuidle/menu: add per CPU PM QoS resume latency consideration Mike Galbraith
2017-02-22 14:53   ` Alex Shi
2017-02-22 15:03     ` Mike Galbraith
2017-02-22 15:36       ` Alex Shi
2017-02-22 15:46         ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f016a9b-8968-e7c1-b1c7-c6b023431623@linaro.org \
    --to=alex.shi@linaro.org \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®