From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 818EC26F46F for ; Fri, 5 Dec 2025 13:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764942638; cv=none; b=Wdo2m6OiDamB4GQrT2ldjdJRLHsaN+WPEGrzOjTdTDbbA5WcgT0VSYDo+/cw/DqNd8d7NV4coGaNQdidzBsNdPjrxFjh9a8hzoPkuhlni18h8fW1wwGKTVfDTNOfpFs1FvsxVGN1FOB4en7jCbPoIBRH1x565vCgi0TnIAGoVrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764942638; c=relaxed/simple; bh=4CZcpYXXlG2+62cC/J8MMsnK+3yQsIoU6uqKqHUZp1s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oHmE0xszLpa8ZX7FwZoyxB2QZL/AQNd7P+IKauW0GeNx0Mr5gFel1RtcCfJRfwM30jluBZUTjpQLOV9+T98ijAgre4kUT2KjQ8IvoXarCODIZtLWePIiJIj2ALbdgYe4sWmWltlgcv6MRciBnjdhmcJLu4ZrLyRdsXQXf8j1soI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GvquVuCs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MxVHUDIA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GvquVuCs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MxVHUDIA" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B5AOaLi067787 for ; Fri, 5 Dec 2025 13:50:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y5p88FGBRRHUrwtsPtwBgMJBiZaTek1nnXqBGbzR/+4=; b=GvquVuCsK1vpdH53 Puy/KC+rk3FqmvhsS+OANi48d5cBYUdq1L5BIkGFmupmXS0LIX2dX/JYT1xshlbq oSzltLddTpqPXqYHlSKQ/QQdpG5N/tX7FPR5+QLvt9QaiDJ0wDICsbkBwaKDCBrX E89qdyzgspfAMLmyXYYLvH1cK0RUiwAtrqLCXV3NZt6rLZdoiTo4gWyQ1KbIXGJb d93+ZHJskcaAjfSKxI3AZf91kU59me/uDmpfTTmNyTp4PVOrasvdDdwMRynFMh2k Bi8IbdzDbKWImbIM3y1AH8OJjtqTqof5tsQ9qocCSFT7SbYJ0w1TeHGSJW0uOSZs wL32tA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4auwm4ggf2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 05 Dec 2025 13:50:34 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ed83a05863so6058261cf.2 for ; Fri, 05 Dec 2025 05:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764942632; x=1765547432; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y5p88FGBRRHUrwtsPtwBgMJBiZaTek1nnXqBGbzR/+4=; b=MxVHUDIAOr++NOxtCUAwabd+QgCtkGTxV3g47Uwk0Fvo6EaZzzeunSlJ5ARSbe88Qq l+bVyb0mFlkU+YYAtTFg6J15kOjQDl1vYSKdLGEYH52PWu93Ge4y1zEjP/5JFkkAcMoE cYpvdswPjkf0PD19NOHi7bT+wG0e74jLRNZxDZj9Fxnha+D0dnWazC0vglcX6Gf/69iB TYV/FS5GMqQKmY0e9wWmqSD6sCkeiM77V2j5M1gzQdqhlzI+G0YI+TgFxy07MbUvgpJM HIW7X/sdSDwF8trEW2u6ea3t8MgaOE5lLfI6pbjYbv1gt79OdJFomPEzqDh+vZG/5sUq 3XzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764942632; x=1765547432; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y5p88FGBRRHUrwtsPtwBgMJBiZaTek1nnXqBGbzR/+4=; b=Z44ErYY1hmga2TTa7o63irEe0OFB1hqv5WgGPkTIb4/d90n3S9uGIyJ3EPgNrW912M yZnIiV71ReItKTnomdwIYn/5WSwfut7KTe4bUCvtBCZ3ObiDjf69n7+sYKde7pUCdiu8 S1+cde4NhyZliQl+bgST3JGiv4tkqG9Qc8xKTLjkDpusg+aw+g7uadTD5xiZ4QJb2Ljc FM27deON/3+HClcyLiOE8lnDOHZ6Jkjs/D1WL6rkjzL78z4j4mFceKEoddTBAiDPgBKq 6zwQ4WheJUzzAIHcSaVq1sA2VXIiqjeIFnyyJVYUvSYCN2Cqc+JCUVFypzYTmCZnM9OX TKyQ== X-Forwarded-Encrypted: i=1; AJvYcCVWDGcnR2OLXmiWYM/HE2vrArnmLUOzZKRP0mO8Z/aA6XhOcmFh1nC/tn2Hq6l5aH3rs0RfdhAbgtCu8pI=@vger.kernel.org X-Gm-Message-State: AOJu0YwRmv0tQsbBJdAr8a1roxrp++6dLyOLM/XDdB8AU3dPKzX7jBml WeMWY/pV2bT651YeY1Pb/C7sqm48dJ8ppkAzPMxqNkLDXgEelLqtcf27vHZoiA/Gh0+Zh8KrVL/ ASPaK15nozHMueccDDNsihGomlLAb6RK3i1CSeqD9b6B73qZABR8i38ctYaGwbgMTFaw= X-Gm-Gg: ASbGncvSUyB3S4/Ulsss+Cag844WSnZbzpm04QWj7U/YxCnnBzhZiGfL8ItWE4m5EVu HjD/C0W7erAA57IAbJi2/iqOx90D4xo/nS3CLtTPmpHwT+fWq17aUYNCWz81UHwA1ysgTGCDUrn YaZdiQaLR5oBQsLpRsL0Lr6Jsc9mvDTaQO75Pqv/b9UL9MAx/WhNdLVVDfZOGkAhSWQc2TuQiTp toKGXSAc56yVOjCKo4bVV+J4E7Ved36vTKshsVjMylr1sy2G7UjsfnVM4I5v7Uh9xss7cEtodzF l39uMo1/vvA7pQ1GOinKzFdNK6wkcSPTBDtydA4rBJIW216x9sd+N3EmwGUZQGQ4uE8EzCFLL1S HmXAR2Md9TAyapD7cm9TXwNCZIH7W8ueP9OdFglYDR+q5JsQr1GnD1CZrb76M0RGevg== X-Received: by 2002:ac8:5a13:0:b0:4ed:7f85:225c with SMTP id d75a77b69052e-4f01b3ae1dbmr90396671cf.10.1764942632396; Fri, 05 Dec 2025 05:50:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IF7+9p8L0qbtODh5+8acMl8B1/dPeo8CKcgfhrw8pmakuGMd5xrf43LdX+oGknLnUZeK7ZZqw== X-Received: by 2002:ac8:5a13:0:b0:4ed:7f85:225c with SMTP id d75a77b69052e-4f01b3ae1dbmr90396381cf.10.1764942631945; Fri, 05 Dec 2025 05:50:31 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-647b368dcf8sm3857364a12.19.2025.12.05.05.50.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Dec 2025 05:50:28 -0800 (PST) Message-ID: <6f085aee-e1a3-4171-822e-1ad4f963515a@oss.qualcomm.com> Date: Fri, 5 Dec 2025 14:50:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI To: David Heidelberg , longnoserob@gmail.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251205-slpi-v2-0-dfe0b106cf1a@gmail.com> <20251205-slpi-v2-1-dfe0b106cf1a@gmail.com> <2bd146fc-06a7-4f62-b542-fe24cb9150fe@oss.qualcomm.com> <5b1ad72d-bd85-4950-8148-266296a05db1@ixit.cz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <5b1ad72d-bd85-4950-8148-266296a05db1@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=T92BjvKQ c=1 sm=1 tr=0 ts=6932e32a cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=230YQcnhf1KWoVgRm34A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: QUT47NesW0nSLgLQZkS_CbSj2EnQSNQC X-Proofpoint-ORIG-GUID: QUT47NesW0nSLgLQZkS_CbSj2EnQSNQC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDA5OSBTYWx0ZWRfXyFtyP/xNbZx6 ltfrbf/VKL6+A7nR627uxT0syfDXoM6IhawDQfImcYClRO98cVjhyKuOxIbapqjBbCPt5YkfzeL ycocA3OhOR2C+sCOqIALgXngasQOUy+z2TR4gnG8ExQaZjXLU5IM7DCCrWCh+2B8erkXxRKv/91 uaWoV8j5sraPaIwMmi0V1+xN6KVDdTjZ/INMaFoy4DQyEkqg9/HU3peKwjXHrn6E4Oun2qnWwj2 M83LT23hB0bKbJIDWTVRBZPtAFj8sUhiHdoaZjPMpK8gTA9R9Cy9nRvC90C1YangC2TMOpU1OM/ MHqPrqlkFAwk86xtj7wCAGcDCyp7WgsYVpxjfvA2uN3WkAJAQ8xwBC7mMigGIw5uMtxfc7zK73o qQusdk9ei1vFX2FmVQ/Wd9vXu7CxMw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_04,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050099 On 12/5/25 2:45 PM, David Heidelberg wrote: > On 05/12/2025 14:27, Konrad Dybcio wrote: > > [...] > >>> @@ -637,3 +643,4 @@ &wifi { >>>       vdd-3.3-ch0-supply = <&vreg_l25a_3p3>; >>>       vdd-3.3-ch1-supply = <&vreg_l23a_3p3>; >>>   }; >>> + >>> >> >> Stray hunk? > > I think your comment goes into the category of "extreme nitpicks". > > Here as usual I guess there are three options: >  - another revision because of newline >  - maintainer merge it with it and nothing happens >  - while merge, maintainer remove the line $ LC_ALL=C b4 shazam 5b1ad72d-bd85-4950-8148-266296a05db1@ixit.cz -P 1 Grabbing thread from lore.kernel.org/all/5b1ad72d-bd85-4950-8148-266296a05db1@ixit.cz/t.mbox.gz Checking for newer revisions Grabbing search results from lore.kernel.org Analyzing 6 messages in the thread Analyzing 0 code-review messages Checking attestation on all messages, may take a moment... --- [PATCH v2 1/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI --- ✗ No key: openpgp/longnoserob@gmail.com --- Total patches: 1 (cherrypicked: 1) --- Base: using specified base-commit 6987d58a9cbc5bd57c983baa514474a86c945d56 Applying: arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI //.git/rebase-apply/patch:26: new blank line at EOF. + warning: 1 line adds whitespace errors. It works best when both submitters and maintainers check their work.. Konrad