From: Frank Rowand <frowand.list@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Vincent Guittot <vincent.guittot@linaro.org>,
David Gibson <david@gibson.dropbear.id.au>,
Michal Simek <michal.simek@xilinx.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Anmar Oueja <anmar.oueja@linaro.org>,
Bill Mills <bill.mills@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V11 3/5] kbuild: Allow .dtso format for overlay source files
Date: Fri, 12 Mar 2021 23:11:25 -0600 [thread overview]
Message-ID: <6f093bb1-1a80-a906-fb4c-3f6fdeed4838@gmail.com> (raw)
In-Reply-To: <20210312071325.zosmlttse4ym7sit@vireshk-i7>
On 3/12/21 1:13 AM, Viresh Kumar wrote:
> On 12-03-21, 01:09, Frank Rowand wrote:
>> I suggested having the .dtso files include the .dts file because that is a relatively
>> small and easy change to test. What would probably make more sense is the rename
>> the existing overlay .dts files to be .dtso files and then for each overlay .dtso
>> file create a new .dts file that #includes the corresponding .dtso file. This is
>> more work and churn, but easier to document that the .dts files are a hack that is
>> needed so that the corresponding .dtb.S files will be generated.
>
> What about creating links instead then ?
>
I don't really like the idea of using links here.
Maybe it is best to make the changes needed to allow the unittest
overlays to be .dtso instead of .dts.
Off the top of my head:
scripts/Makefile.lib:
The rule for %.dtb.S invokes cmd_dt_S_dtb, which puts the
overlay data in section .dtb.init.rodata, with a label
pointing to the beginning of the overlay __dtb_XXX_begin and
a label pointing to the end of the overlay __dtb_XXX_end,
for the overlay named XXX. I _think_ that you could simply
add a corresponding rule for %.dtbo.S using a new command
cmd_dt_S_dtbo (the same as cmd_dt_S_dtb, except use labels
__dtbo_XXX_begin and __dtbo_XXX_end).
drivers/of/unittest.o:
would need to have the #define of OVERLAY_INFO() changed to
reflect the changed label names (use __dtbo_##overlayname##begin
and __dtb_##overlay_name##_end).
drivers/of/unittest-data/Makefile:
In obj-$(CONFIG_OF_OVERLAY) change the *.dtb.o names to *.dtbo.o
I'm not sure how the DTC_FLAGS_... += -@ differentiates between
.dts / .dtb and .dtso / .dtbo That is worth looking at.
-Frank
next prev parent reply other threads:[~2021-03-13 5:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 5:35 [PATCH V11 0/5] dt: Add fdtoverlay rule and statically build unittest Viresh Kumar
2021-03-10 5:35 ` [PATCH V11 1/5] kbuild: Simplify builds with CONFIG_OF_ALL_DTBS Viresh Kumar
2021-03-10 5:35 ` [PATCH V11 2/5] kbuild: Add generic rule to apply fdtoverlay Viresh Kumar
2021-03-10 5:35 ` [PATCH V11 3/5] kbuild: Allow .dtso format for overlay source files Viresh Kumar
2021-03-10 11:24 ` Masahiro Yamada
2021-03-10 11:29 ` Masahiro Yamada
2021-03-10 14:48 ` Viresh Kumar
2021-03-10 15:18 ` Masahiro Yamada
2021-03-12 3:52 ` Viresh Kumar
2021-03-10 14:47 ` Viresh Kumar
2021-03-10 15:15 ` Masahiro Yamada
2021-03-10 22:42 ` Frank Rowand
2021-03-12 4:47 ` Viresh Kumar
2021-03-12 7:03 ` Frank Rowand
2021-03-12 7:09 ` Frank Rowand
2021-03-12 7:13 ` Viresh Kumar
2021-03-13 5:11 ` Frank Rowand [this message]
2021-03-15 1:16 ` Frank Rowand
2021-03-15 6:40 ` Viresh Kumar
2021-03-15 17:43 ` Masahiro Yamada
2021-03-15 22:12 ` Laurent Pinchart
2021-03-16 5:39 ` Frank Rowand
2021-03-16 8:01 ` Geert Uytterhoeven
2021-04-09 6:03 ` Masahiro Yamada
2021-03-16 5:27 ` Viresh Kumar
2021-03-16 5:36 ` Frank Rowand
2021-03-16 5:42 ` Viresh Kumar
2021-03-24 7:34 ` Frank Rowand
2021-03-24 22:45 ` Frank Rowand
2021-03-10 5:35 ` [PATCH V11 4/5] of: unittest: Create overlay_common.dtsi and testcases_common.dtsi Viresh Kumar
2021-03-10 5:35 ` [PATCH V11 5/5] of: unittest: Statically apply overlays using fdtoverlay Viresh Kumar
2021-03-11 23:27 ` [PATCH V11 0/5] dt: Add fdtoverlay rule and statically build unittest Frank Rowand
2021-03-12 4:31 ` Viresh Kumar
2021-03-12 6:46 ` Frank Rowand
2021-03-12 4:32 ` Viresh Kumar
2021-03-15 17:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f093bb1-1a80-a906-fb4c-3f6fdeed4838@gmail.com \
--to=frowand.list@gmail.com \
--cc=anmar.oueja@linaro.org \
--cc=bill.mills@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=michal.simek@xilinx.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome