mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Matthew Wilcox <willy@infradead.org>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [mm 4.15-rc8] Random oopses under memory pressure.
Date: Mon, 22 Jan 2018 14:26:02 +0100	[thread overview]
Message-ID: <6f0abb8d-84b3-070e-fca7-c71524311702@prevas.dk> (raw)
In-Reply-To: <CA+55aFwWCeFrhN+WJDD8u9nqBzmvknXk428Q0dVwwXAvwhg_-w@mail.gmail.com>

On 2018-01-19 19:42, Linus Torvalds wrote:
> 
> I actually asked (long long ago) for an optinal compiler warning for
> "pointer subtraction with non-power-of-2 sizes". Not because of it
> being undefined, but simply because it's expensive. The
> divide->multiply thing doesn't always work,

Huh? If (compile-time constant, positive) d=m*2^k with m odd, and x is
known to be a multiple of d, x/d can always be computed as (x>>k)*m' ==
(x*m')>>k, with m' being the mod 2^N multiplicative inverse of m, right?
This works whether x has signed or unsigned type and whether it indeed
happens to be negative, AFAICT.

Sure, the multiplication by m' may not exactly be cheap, but one only
needs the low N bits of the result.

Rasmus

  parent reply	other threads:[~2018-01-22 13:26 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201801112311.EHI90152.FLJMQOStVHFOFO@I-love.SAKURA.ne.jp>
     [not found] ` <20180111142148.GD1732@dhcp22.suse.cz>
     [not found]   ` <201801120131.w0C1VJUN034283@www262.sakura.ne.jp>
     [not found]     ` <CA+55aFx4pH4odYDfuGemm5TK-CS4E8pL_ipHCVzVBmsQkyWp1Q@mail.gmail.com>
     [not found]       ` <201801122022.IDI35401.VOQOFOMLFSFtHJ@I-love.SAKURA.ne.jp>
2018-01-14 11:54         ` [mm 4.15-rc7] " Tetsuo Handa
2018-01-15 23:05           ` Linus Torvalds
2018-01-16  1:15             ` [mm 4.15-rc8] " Tetsuo Handa
2018-01-16  2:14               ` Linus Torvalds
2018-01-16  8:06                 ` Dave Hansen
2018-01-16  8:37                   ` Ingo Molnar
2018-01-16 19:30                   ` Linus Torvalds
2018-01-16 17:33                 ` Tetsuo Handa
2018-01-16 19:34                   ` Linus Torvalds
2018-01-17 11:08                     ` Tetsuo Handa
2018-01-17 21:39                       ` Linus Torvalds
2018-01-17 21:51                         ` Linus Torvalds
2018-01-17 22:04                           ` Dave Hansen
2018-01-17 22:00                         ` Dave Hansen
2018-01-17 22:15                           ` Linus Torvalds
2018-01-18  8:12                       ` Tetsuo Handa
2018-01-18 12:25                         ` Kirill A. Shutemov
2018-01-18 13:12                           ` Kirill A. Shutemov
2018-01-18 14:34                             ` Kirill A. Shutemov
2018-01-18 14:38                             ` Dave Hansen
2018-01-18 14:45                               ` Kirill A. Shutemov
2018-01-18 14:51                                 ` Dave Hansen
2018-01-18 16:58                               ` Linus Torvalds
2018-01-18 14:45                           ` Dave Hansen
2018-01-18 14:58                             ` Andrea Arcangeli
2018-01-18 16:56                               ` Kirill A. Shutemov
2018-01-18 17:26                                 ` Luck, Tony
2018-01-18 17:28                                   ` Linus Torvalds
2018-01-18 17:26                                 ` Linus Torvalds
2018-01-18 23:49                                   ` Kirill A. Shutemov
2018-01-19 12:55                                     ` Matthew Wilcox
2018-01-19 18:42                                       ` Linus Torvalds
2018-01-19 22:12                                         ` Al Viro
2018-01-19 22:53                                           ` Linus Torvalds
2018-01-20  2:02                                             ` Al Viro
2018-01-20  5:24                                               ` Al Viro
2018-01-20  9:38                                                 ` Luc Van Oostenryck
2018-01-22 13:26                                         ` Rasmus Villemoes [this message]
2018-01-22 19:58                                           ` Linus Torvalds
2018-01-18 15:40                             ` Kirill A. Shutemov
2018-01-18 17:22                               ` Michal Hocko
2018-01-19 10:02                                 ` Kirill A. Shutemov
2018-01-19 10:33                                   ` Michal Hocko
2018-01-19 11:49                                     ` Kirill A. Shutemov
2018-01-19 12:07                                       ` Michal Hocko
2018-01-19 12:30                                         ` Kirill A. Shutemov
2018-01-19  2:01                               ` Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f0abb8d-84b3-070e-fca7-c71524311702@prevas.dk \
    --to=rasmus.villemoes@prevas.dk \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®