mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Jason Perlow <jperlow@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: btbcm: Add entries for BCM4364B3 UART Bluetooth
Date: Sun, 22 Nov 2026 09:27:48 +0100	[thread overview]
Message-ID: <6f0b4dfc-4bb3-45f9-81ae-347e345cbe33@molgen.mpg.de> (raw)
In-Reply-To: <4a1efe5e-ec67-4caa-bb84-35759e66ef42@gmail.com>

Dear Jason,


Thank you for your patch.

Am 16.11.26 um 22:38 schrieb Jason Perlow:
> The BCM4364B3 combo chip on Apple T2 Macs, e.g. the MacBookPro16,1, has a
> UART Bluetooth controller that reports LMP subversion 0x3032 (001.016.050)
> on some units and 0x305b (001.016.091) on others.  Neither has an entry in
> bcm_uart_subver_table, so the controller is logged without a name:
> 
>    Bluetooth: hci0: BCM4364B3 Trinidad Olympic GEN (MFG)
>    Bluetooth: hci0: BCM (001.016.091) build 0115
> 
> and the firmware lookup only tries the generic "brcm/BCM.hcd".
> 
> Add both subversions so the controller is named and its firmware is looked
> up as "brcm/BCM4364B3.hcd" first.  Tested on two MacBookPro16,1 with a
> v7.4-rc3 based kernel carrying an equivalent change, one reporting 0x3032
> and one reporting 0x305b.  They now log:
> 
>    Bluetooth: hci0: BCM4364B3 (001.016.050) build 0082
>    Bluetooth: hci0: BCM4364B3 (001.016.091) build 0115

Is this only about the logs, or does functionality also change, that BT 
starts working, or did it work before already?

> Signed-off-by: Jason Perlow <jperlow@gmail.com>
> ---
>   drivers/bluetooth/btbcm.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index 065536d4ec..92ba7aeac3 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -519,6 +519,8 @@ static const struct bcm_subver_table 
> bcm_uart_subver_table[] = {
>       { 0x2119, "BCM4373A0"    },    /* 001.001.025 */
>       { 0x2128, "BCM4384A0"    },    /* 001.001.040 */
>       { 0x4119, "BCM4384B0"    },    /* 002.001.025 */
> +    { 0x3032, "BCM4364B3"    },    /* 001.016.050 */
> +    { 0x305b, "BCM4364B3"    },    /* 001.016.091 */

Sort it?

>       { }
>   };

With my comments addressed, feel free to add:

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

      reply	other threads:[~2026-11-22  8:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 21:38 Jason Perlow
2026-11-22  8:27 ` Paul Menzel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f0b4dfc-4bb3-45f9-81ae-347e345cbe33@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=jperlow@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®