From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6991A3B6BEB for ; Mon, 30 Mar 2026 10:52:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774867933; cv=none; b=FHN49z3hhF4UhKajKzvqFG1G53czfK7fxQnGHJjHn9ASgJos3J0WFjSPHKybDLQ0z9cZ2DXKmIMXjOUvGMfI1ImVadTnh6xAO+1gyZvCo9YS6ZrwfMQ/q2mKnVOjmiUPEtm4kALyYfJjhxEzVOGQbfOQSHbchVYQULYJ8z0fP14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774867933; c=relaxed/simple; bh=8tGCl9H2u0kxygEigoVcToA6cJ97rZF07Am4vKOJmbs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=U9DYv0rrvpWA/xzHpzSZo3NsOlYCZH+/0BjPJKXAgUTgYsMvFZ7R47SOvv70Vsyt1F9Pssol/pbQ6LyUcdrwUou9EMMEVt6H3SWbjqbzSs+DHp7z8wJLhEZmYiwDYpxTQdbfCif80xVdwQA3z0cgaGm3F6+/xKfdzXCMPApEAWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VCvcQwNg; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VCvcQwNg" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-486fba7ce4cso43434125e9.3 for ; Mon, 30 Mar 2026 03:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774867931; x=1775472731; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=8tGCl9H2u0kxygEigoVcToA6cJ97rZF07Am4vKOJmbs=; b=VCvcQwNgAwvtg6k5HaKlSk/DWAF287dpGwC0Rn8Ss871lQXbEI2DnRHtdW2xQXmJGh 1n0yxr/aQ7X9PEd4x3a4rdhGLkK8/yVBNvq/kuJYFQ/MqrzWYRoAMq0xX/DVTmC4Ef4G Ytn4u/JkAGZur15HRZCJ9Q9rd2wC1JarucW9f8TKbKsDHtZcFgFZ0ziNyBOcbbhK+8At QJ/v1XvY0HOiHEfB7VRo3ZltFUZatWUXSOcapmU7lLnuSArdccf/tC+4RBLE2i4MmZW9 Zwrac2m2GafZGJRLTfO56KACyfl0NUTm6Wm28CV/gxR9yv4YqTGJ/1i/uWgHcUK5SVtI TWYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774867931; x=1775472731; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8tGCl9H2u0kxygEigoVcToA6cJ97rZF07Am4vKOJmbs=; b=KmyUSwoBQsSIGZjzeIZqpg/+wmFjuAYc/Me9EenigvwKz5O9s+YgAd5wSd7+3CTQ2D YtmUyKylEmOuvvJ21wSKbPmst2aZR0qMeSCxqBJoHuiYXNb9wVxj87HrsnMyVUCKhpj6 IlZT1UKksqYaTKPoNtY1uLF1mhbtmX4+rxrCWEK3yiAXjDOx6r7dbfZ4srhDLSmD8uiX nsw/WYEyvzaiqadQ5AoVPbur79pKldG0udqbHqBkGHE4Hj2RzvmYWLs5jNkQN9Nt4QJ8 /ihlksl+agoY+e5ZbduUIANmmSE25euOiphMVTie56pVn8HoK7C9MbI0U6UF3lGAXjBd 9iQg== X-Forwarded-Encrypted: i=1; AJvYcCXrsX6oaJH225BFa6UY0bJ7TJQ+59QgjL1c05NWng48d7p9GEktRr/Her88qX8wnN9DWVjkb8AcP6OyK+M=@vger.kernel.org X-Gm-Message-State: AOJu0YxV00G+UXk+zfa/AY8C2Mpp/AwMLgsryXgIxxmViR/OaRoMGQ2d VkLXgwsnyGzAfCr/mDlxusjaWbyDqimFBqjSNZBXljBUciDDNvIga+3ssnAazMiS1tc= X-Gm-Gg: ATEYQzxYlFiVNriyKKSZPmxnwNe2PmmMzOStM94ety15fRjFMq30mnenK6SVjbo7j18 DGjUb+slTr6RJ1ynLCsCVYx06n/aNl8C8JlixEVEjp7LVGQAP0FeTRYKOzAW/Uo2GNsITjvGB6p 5EhXdolIiug06Kp4qzB0dB2MvByaQwNvh11Bz7ZZUeCkgyhua/Jy8jaO7KixVT2+g/OB/o1GVKo HmO4BkRBFRMh8KMygWBpvvH8tkpjQCbbWQqcg5VvChZrV8C+3496WlHxQMSfAlF5M3BWpXNDZlM cmsTIySqOGsX3iurKbFJgwFN5Qyo5jU0/9qLYX5sqZhN4YY9DmcT4l0fhUnOB2wgOG1IXpuPhmo d6mDQLaq1XsCcKllaMcq3PQc7KsNRffPeJuVqWVXxExww9n+SRzwKPh/btHftE9nlcQB0CCIJTV GkpilG9qboDHry/60d4BWq7eX8HvFG X-Received: by 2002:a05:600c:a108:b0:485:3a27:a961 with SMTP id 5b1f17b1804b1-48727c82082mr167788605e9.0.1774867930830; Mon, 30 Mar 2026 03:52:10 -0700 (PDT) Received: from draszik.lan ([212.129.78.46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4873ab203e9sm78932785e9.0.2026.03.30.03.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 03:52:10 -0700 (PDT) Message-ID: <6f0be0a71c74e7a7959e9ad02e93aff1cb8ef712.camel@linaro.org> Subject: Re: [PATCH v8 02/10] dt-bindings: power: samsung: add google,gs101-pd From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Krzysztof Kozlowski Cc: Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Liam Girdwood , Mark Brown , Peter Griffin , Tudor Ambarus , Juan Yescas , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Date: Mon, 30 Mar 2026 11:52:08 +0100 In-Reply-To: <177409897339.266364.69715997034739052.b4-review@b4> References: <20260318-gs101-pd-v8-0-241523460b10@linaro.org> <20260318-gs101-pd-v8-2-241523460b10@linaro.org> <177409897339.266364.69715997034739052.b4-review@b4> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-8+build1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Krzysztof, On Sat, 2026-03-21 at 14:16 +0100, Krzysztof Kozlowski wrote: > On Wed, 18 Mar 2026 15:27:47 +0000, Andr=C3=A9 Draszik wrote: > > diff --git a/Documentation/devicetree/bindings/power/pd-samsung.yaml b/= Documentation/devicetree/bindings/power/pd-samsung.yaml > > index 9c2c51133457..3f1a2dc17862 100644 > > --- a/Documentation/devicetree/bindings/power/pd-samsung.yaml > > +++ b/Documentation/devicetree/bindings/power/pd-samsung.yaml > > @@ -44,11 +45,28 @@ properties: > > =C2=A0=C2=A0 power-domains: > > =C2=A0=C2=A0=C2=A0=C2=A0 maxItems: 1 > > =C2=A0 > > +=C2=A0 samsung,dtzpc: > > +=C2=A0=C2=A0=C2=A0 $ref: /schemas/types.yaml#/definitions/phandle > > +=C2=A0=C2=A0=C2=A0 description: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Distributed TrustZone Protection Contro= l (DTZPC) node. >=20 > For what purpose? It is part of the domain. Furthermore, TZ configuration is lost as part of power-domain power cycle, so this allows a driver to take necessary actions (inform the EL3 firmware). I believe this handle to be similar to e.g. the existing samsung,sysreg > Your patchset is organized in odd way - first patch for me, then not for > me, then again two patches for me. Please keep it consistent. Or better, > decouple since there are no dependencies according to cover letter. I'll update the cover letter to describe the dependencies. 4 depends on 2, and 2 depends on 1, hence the ordering. Cheers, Andre