From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B7AC6778C for ; Tue, 3 Jul 2018 15:40:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EEEB24A6A for ; Tue, 3 Jul 2018 15:40:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EEEB24A6A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933582AbeGCPkt (ORCPT ); Tue, 3 Jul 2018 11:40:49 -0400 Received: from gate.crashing.org ([63.228.1.57]:54248 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932615AbeGCPks (ORCPT ); Tue, 3 Jul 2018 11:40:48 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id w63Fdrkp007605; Tue, 3 Jul 2018 10:39:56 -0500 Message-ID: <6f0c3d6d81202e385fee55a2c8aaec18d1d2acda.camel@kernel.crashing.org> Subject: Re: [RFC PATCH 1/4] dts: misc: Add bindings documentation for bmc-misc-ctrl From: Benjamin Herrenschmidt To: Greg KH Cc: Andrew Jeffery , linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, joel@jms.id.au, Eugene.Cho@dell.com, a.amelkin@yadro.com, stewart@linux.ibm.com, openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Wed, 04 Jul 2018 01:39:53 +1000 In-Reply-To: <20180703143109.GB2043@kroah.com> References: <20180703070413.28756-1-andrew@aj.id.au> <20180703070413.28756-2-andrew@aj.id.au> <20180703075009.GA27649@kroah.com> <20180703143109.GB2043@kroah.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.3 (3.28.3-1.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-07-03 at 16:31 +0200, Greg KH wrote: > On Wed, Jul 04, 2018 at 12:16:49AM +1000, Benjamin Herrenschmidt wrote: > > On Tue, 2018-07-03 at 09:50 +0200, Greg KH wrote: > > > On Tue, Jul 03, 2018 at 05:04:10PM +1000, Andrew Jeffery wrote: > > > > Signed-off-by: Andrew Jeffery > > > > --- > > > > > > I can't take patches without any changelog text at all :( > > > > Greg (and replying to your other comments as well)... > > > > This is an RFC series, it's not meant for you to take at this point, > > it's about discussing the overall approach to exposing BMC random > > "tunables" as explained in patch 0 of the series. > > > > Yes the individual patches aren't yet at the level of polish for a > > formal submission, we (naively ?) thought that's what the whole RFC tag > > is about :-) > > Oh come on, putting a basic "here is what this patch does" comment > should be part of every patch, otherwise what is there to comment on if > we don't know what is going on in the patch itself? Well, it adds documentation :-) You can just read the patch which is ... the documentation :) > > Anyway, I provided a bunch of feedback to the "real" patch in this > series... Yes, you did that's fine. Thanks. Cheers, Ben.