From: David Ahern <dsahern@gmail.com>
To: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>,
linux-kernel@vger.kernel.org
Cc: ltc-kernel@rdgml.intra.hitachi.co.jp,
"森谷真寿美 / MORITANI，MASUMI" <masumi.moritani.ju@hitachi.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Masami Hiramatsu" <mhiramat@kernel.org>
Subject: Re: [PATCH] perf sched: fix wrong conversion of task state
Date: Thu, 28 Jul 2016 08:26:45 -0600 [thread overview]
Message-ID: <6f116f1a-bcca-d32c-09b1-8464b16e9210@gmail.com> (raw)
In-Reply-To: <000001d1e87d$9b28e680$d17ab380$@hitachi.com>
On 7/27/16 9:10 PM, Tomoki Sekiyama wrote:
> But that means we cannot handle preemption correctly as far as
> sched:sched_switch
> event uses TASK_STATE_MAX to mark preempted tasks.
>
> Should we stop using TASK_STATE_MAX for preempted tasks in ftrace and
> use (1 << 63) or something that doesn't change on kernel version instead?
ftrace printing is within the kernel so it has consistency.
It is the save data and analyze later use case that can not assume
TASK_STATE_MAX means preemption since the value of TASK_STATE_MAX is
kernel version dependent.
next prev parent reply other threads:[~2016-07-28 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 12:54 Tomoki Sekiyama
2016-07-27 14:18 ` David Ahern
2016-07-27 15:58 ` 関山友輝 / SEKIYAMA，TOMOKI
2016-07-27 16:03 ` 関山友輝 / SEKIYAMA，TOMOKI
2016-07-27 16:50 ` David Ahern
2016-07-28 3:10 ` Tomoki Sekiyama
2016-07-28 14:26 ` David Ahern [this message]
2016-07-29 2:30 ` 関山友輝 / SEKIYAMA，TOMOKI
-- strict thread matches above, loose matches on Subject: below --
2016-07-27 12:52 Tomoki Sekiyama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f116f1a-bcca-d32c-09b1-8464b16e9210@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltc-kernel@rdgml.intra.hitachi.co.jp \
--cc=masumi.moritani.ju@hitachi.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=tomoki.sekiyama.qu@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®