From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B1FC3C3449 for ; Tue, 18 Aug 2026 10:16:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787048195; cv=none; b=qJBcIKTghh5VfdPMOw88gJCB+iSSBG+EZxHFrldutWXWmNOU2BuHQCXHsRBf4/UA2H1pxN+ZJjjnQk8bk5Hy6uSOieX0+KCGEcJU3CDmJ0pW554uBwXU21SSatipHOSrdmQ/LaHmX4ueaMGf5VR6fJndvXeXjvOQ1EM+reYxHAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787048195; c=relaxed/simple; bh=NjdeBq83ZgzUZH446kdw0norRIo1mBoehc01XWmr2mw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ICIwiL5p3IR26dUJ2bjsRBlfXZJ0jsumnmDLs1cddyd5UFf2v/Gx41imad1J2iJhmExsjYTGfNf+akP1bbrdSAtsQcgWyHkV6xq/6WuXfhQhNPAt+i3dOR14iZOEcwH26rDcnF6b3XCITTGikF+PpGg3yeQ5kf2hre2CGvy4dgY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TgP2Ndtx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iuDw8IZ3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TgP2Ndtx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iuDw8IZ3" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IABZwP3979120 for ; Tue, 18 Aug 2026 10:16:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= R7gxToVkREhPO6dQI34HddITtzydFov0LPEzCVWHmA0=; b=TgP2Ndtx33vsCXf2 jHtVVdnOXv/sHLMw1LbpDKjhI7H5PRJaRwJyho/UKK6kRoOPxLvUbLO4ip//A9gu xCMqU0pkrcmIvMeXX4GIbNTaDDdr7KH8Wq+dZ6GJP+GzsB4cfgdIiQX7J5teIx9c ZTYqswQ4h/mH0vQQbypj9iyRn50tpjNXsm0CvlERw490WIsgC79h5vveamZPhxf9 e+7NycubgZfVBmB2DOWL1nk3KloM480cCTG3VV0TwP/yJA33tZy+pVoDYJ+YdhXe oolWFhvnxMMF0DPvbxLsadQsq6Uu9uO/MYfIDcYht0pYzr1e64KbbD2JKeaMYhS/ EJcWyg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4ebpswr0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 10:16:32 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93102454272so4517585a.1 for ; Tue, 18 Aug 2026 03:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787048192; x=1787652992; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=R7gxToVkREhPO6dQI34HddITtzydFov0LPEzCVWHmA0=; b=iuDw8IZ3N1FNfaTbiDHdykUk4LFfQ0hMWUvPuJn0xLCcI/b4oh+IU5ZV1EYq0FeYIu 1G7TDDcH1tc6bgsHKxVadS1kIrZUizQX6nDfqI4Aao0lJE0tUNfEvFkkDoEaKq/GOeFq 6yQfrkA3zsGWc1sD4D9DcVJ/wvGG82eOPNqj+hzAPnuEwvoEHLB4931ttB0APjplqliE KLcNnB2LrvSiw7FYLQ9BZj78a3lEvuYbJctu2+RBkG9jxc1bcGY34t/oogT81jVajtxI LvhiMsHoJulGALptAEynorQkOS5AKjBQ99+Tsxpi80ZSTkzA332CR1rdAFan6/8YD1wz CEOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787048192; x=1787652992; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=R7gxToVkREhPO6dQI34HddITtzydFov0LPEzCVWHmA0=; b=KGrU1FOXiCkOun2i2q6ccuvkNKrcFM9hrfoacct/wL2s6XrkwtVslVQUXkcU/KWRAb 4AOsApCqIYfouKWLr9l+UcAjQmW22N7MaZUNwmrgK+g4+aPO4Ady8ioE+nK7PT14dIR/ HatHC+1zzXjV4PU5fbVGHmckW+ZRTt3TOcNyHpFRhGDe2kLgFFLtNDjMW1kltJzjDJzt fnOLGa1FLz3DDeMjmfDEC7BdP7inyaxo+3Oh+ctcKqWy1A/i+R3l+krl03RC+TXIq+co PsJgZSChXS/o/n6fEahO2J2G6BTA1AuNOqNl2gC59jogLof1cEZ8qvKAgK9//7jADAgr VAuQ== X-Forwarded-Encrypted: i=1; AHgh+Rr6KmRE/K8TZFYdBVuojM5R8UykrgHceTwnE8f1u/M4JaTLTYxp8Lf33pGu4XtMD4TyFQ5Bzz1h1Y0Z5L8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxoy8zkydBctf7KQklQU1GkFmzjg6W4MBa+z1wldiuxgYo6tZYP WDBVpMR2Csqsp9Og16Xx6Of8NG6ZgSRkCRkckTcoV5DnuBVwUEXRUr4OZJNf/FoRGVW/eDJuQiB 3MOdAxDemEMI43le333SJMasD3NTUmyARhj/aF9s9ofPuBPO+h/1J38q/WLDeV1jDQh8= X-Gm-Gg: AR+sD12cjNsLpO1MiRhpOvr5whWBPzJQUGcQCS8nz7Ezp7ctSWL1MTFT8J/j0AJp6HR Rk35IlSnBecP910W8S9Irp/yMaEPPt+lM6U9+RTl2420muOFGdqeZm5+hsFnbWX6ulll5PC3YQo 342o9uHqVBGdEma8dHHUttsg+oWK2QQ9zVswSPIydVk3thz1D8TBnKsMUWUeeUZ5I+BOysrUIaj WHXO7s0okfPhFqShKi707uqkZ6iJwRNHLnJa0Aa/lV5MUewf0inR9def4UZRARezPudAn26X0qq siNWnkfLMJUmOGx+G0SFOiTzbDiwNUwomTW9m4mJQQgB/xcFl8ukI5iNYb5YBg6CNRNKfMGbp6T 2nsuujD7E2kGoNxDyoLVBksdB X-Received: by 2002:a05:622a:190a:b0:51c:2324:666 with SMTP id d75a77b69052e-52d85425e6fmr251850151cf.3.1787048192309; Tue, 18 Aug 2026 03:16:32 -0700 (PDT) X-Received: by 2002:a05:622a:190a:b0:51c:2324:666 with SMTP id d75a77b69052e-52d85425e6fmr251849621cf.3.1787048191916; Tue, 18 Aug 2026 03:16:31 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c217ff7e231sm164114966b.20.2026.08.18.03.16.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 03:16:31 -0700 (PDT) Message-ID: <6f11fda5-43ed-46ff-851e-e571be749a31@oss.qualcomm.com> Date: Tue, 18 Aug 2026 12:16:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/10] ARM: dts: qcom: msm8974: add the HSIC USB controller To: Dmitry Baryshkov , Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> <20260810-msm8974-usb-hsic-v1-9-e5f93ea76ffa@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260810-msm8974-usb-hsic-v1-9-e5f93ea76ffa@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: aPpfZ8XXHtJmJJj_xnqp9NtYwucFkjoR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDA3NCBTYWx0ZWRfX/4eWFaxEn6ip vNdzbhpL17zy/1v64SUn06n7TyCI4Fu4w3z5QzrnhIqZ6rtCKWWweO4uTjhvZ6uDnMrT3SgSIQs kJ3NoyItpRV1WObD1Y4xRsJtNeb5yGTv95EvKnQsaa30ObhaVaaFDaNERal2oGVor5IGDGwT2bA NWMjU6blCJUiQec9071Td3pA8wNQqx329yAJkF9ub8YOaEK+R5YZZf6ncFPZf5lvBTfxkDW4obY jYlhFfXxoleyfhlY16/rgM2n5gZjnxvbHXW0sKssBDUgMnzdzIOljCorO1dbBNo7B/NEdy9NVS/ 86xe6tPqYJ0oLU8wzXx/jL9yODyHpMPyiVCxg9Y5YmrQqegSF6/RwsoGIblDbClR4RxBNXMj6pu Wd9PKfm8pAKYk87h6HmQwXmXXtFTRfnazGrF5lZmFGt8wDuXri6Ahx3pXRaE5WDW5MPSVaEqxEs d36/DSqvrkul3viJTcw== X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDA3NCBTYWx0ZWRfX3mw6HMrOVp7q VtLhrXcEl32mrnn1q8d4KVsFOtfeW3OPupEK/zhVeb1PhK1IDxJWX4rw6hZPJUcLr2JfMNzNRSN RhLQ5QvZs2g32+xslMQbC+yU6Z6USjY= X-Authority-Analysis: v=2.4 cv=FsU1OWrq c=1 sm=1 tr=0 ts=6a843100 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=7gRAf5yVggz7YA7u_AMA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: aPpfZ8XXHtJmJJj_xnqp9NtYwucFkjoR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-18_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 phishscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180074 On 8/10/26 5:42 PM, Dmitry Baryshkov wrote: > The MSM8974 HSIC USB host - a third Chipidea controller with a > dedicated HSIC PHY on the special hsic_strobe/hsic_data pads - is not > described, leaving boards with HSIC-attached hubs or modems without > upstream support. > > Add the controller and PHY nodes. The PHY is a ULPI bus driver present > inside the ulpi subnode. > > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Dmitry Baryshkov > --- [...] > + usb_hsic: usb@f9a00000 { > + compatible = "qcom,ci-hdrc"; I see the driver determines whether the controller is a HSIC one by querying the compatible string of the PHY.. fancy.. would it be desirable to have a separate compatible for the controller itself, or is it more or less the same vs a non-hsic one? > + reg = <0xf9a00000 0x200>, > + <0xf9a00200 0x200>; > + interrupts = , > + ; > + assigned-clocks = <&gcc GCC_USB_HSIC_SYSTEM_CLK>, > + <&gcc GCC_USB_HSIC_CLK>, > + <&gcc GCC_USB_HSIC_IO_CAL_CLK>; > + assigned-clock-rates = <75000000>, Do you have any docs that would detail whether we can run with the slower, 60 MHz clock here? > + <480000000>, > + <9600000>; > + clocks = <&gcc GCC_USB_HSIC_AHB_CLK>, > + <&gcc GCC_USB_HSIC_SYSTEM_CLK>; > + clock-names = "iface", "core"; > + resets = <&gcc GCC_USB_HS_HSIC_BCR>; > + reset-names = "core"; > + power-domains = <&gcc USB_HS_HSIC_GDSC>; > + phys = <&usb_hsic_phy>; > + phy-names = "usb-phy"; > + phy_type = "ulpi"; > + dr_mode = "host"; > + ahb-burst-config = <0>; need required-opps Konrad