From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 790A53EB103 for ; Tue, 28 Jul 2026 08:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785226860; cv=none; b=XgI/HwdQO7Pj4kULzCrwKIm3xmpFa+seiHZfxAOUgtsSOivvGHPabmo5UGBUf9UuWnq5UbpFdLq4Uql9x/tjkNAZu5bfhFVRvJXGr6F+yyLTCl0d+b3URSwB/yG9M8w50KC6hutFgyl+3grGAE8XnkFN3iZPzaUvx4iN9ibI9qI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785226860; c=relaxed/simple; bh=5F+9d6zSwaI23ajpCCP4JCHQTIKUiBdtuz68jRALsbE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GJI80c1RoTMi11d30cEgk/t/By/QPo6KZSK0Stb3l+7D2V+iAa5Lb3voaH9gh76kFc083UDafHyHWoFGmsk4jHAUuW3XP1X/xpaFvZV/8q1Z5EM2pf3XmcjGbUGskrpXPwEcnBVsVdeTfIXk/EAWPn4/hNhplmlLBihha2oO+7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b=LiFE3X53; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b="LiFE3X53" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-47f6609c657so1679745f8f.2 for ; Tue, 28 Jul 2026 01:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20251104.gappssmtp.com; s=20251104; t=1785226856; x=1785831656; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eyYlZFVCc06FCgom6L11YucB1au+iuvrVnF7FufZeZ4=; b=LiFE3X53PKjlppVshtdIvq6mm8/K1SYEYVlC8Gj6w9KAyK0qSyuSzoLljaGGLtFkur k5uZki9yc7jRDgCXDsnv+9YIlAqEPJEl176KGtJr/R46zQ6wpwhAV9RvAtEPxyCLEM1p LzZYRRPs5DNl624SgJRy12wdK5ta65u5RBETJh5FM5shJYHxiHNAxo+AF7ea39ACTxky 98CWzFmn805PNPXY8op6Wbs3KDp7wArJf2Ro9gNY69sTm2WwtxySe6yeRoaSNycoecR9 VK4ZSMKFz6YPEmOhbKsuS5MagBL2niCQhbkkUp2Bizh4iI9wWAoWPCX7j+ITOaglmkVz ZiWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785226856; x=1785831656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=eyYlZFVCc06FCgom6L11YucB1au+iuvrVnF7FufZeZ4=; b=iOm36kA2rAGtQbrlmI2ooktuCGKRscRJniAruETDoTrQdRlvwKMBi+BKonk4dwBZpO 24GcQYCiE1rOuN+0aNuUHiE3bN3a+9g7w/3M/27qr+TUxfyi2Yw1A5YMIyowy6LoA1bl qj0QAf2Ajg+BvEcu2FrxTB4kNNFhC+LFCrofS4D4YOYxy19VPSjVtjh1kQX35dMwv5/Y mbEOqtfVynUYyUfsJvque/ZGDURMUnaywGnHlX4qnNlTRq+0yowNxU4+wdEOvjf3ndoF Czqewt+CGsoguiYWxyZLJscI1Tqik+mkZv20NfJqTWrxcxt2H6lQ/fu7PfkfacQr3Ogh SDgA== X-Forwarded-Encrypted: i=1; AHgh+Rp6EgZJwh9Ke/iIWAg5xDKCrX+XBQQPgsFJimrMVh/2n9WhIqF8B8plLLs3P9b33w1RJnKk5F5rkr8V/Q8=@vger.kernel.org X-Gm-Message-State: AOJu0YzmO0boFGh0AukdnzwjOW06TROlvZkFg/fwD6ObX0CTXXYUxMCU k9Dm2pVv4H1o0Iol7QW13Je01rcwpUSyUA4E/DKSDRLBs/rVSQtrEGryQjEnXZ/3Vw== X-Gm-Gg: AR+sD10h+wtc6Fj/V158BeDiF531wy90CpHymyRRTiPBRpRIayB0ayl1ua192DRSxDd c9t/bSPAyDmZBPqQBn9Th6clSmUJYnUWAQ8x7Ekd+9W83f3OUoNy79U8fNL9DtyjavJDTM1jY4c QTrVHRrlXvrTRiTvGBpaDYqRM5UwpcaMvRt0W3cWFDo3HXGsxUBDY8EDzDUOgd8C5f5tDfw5wKg liPb/un1x5eHBcPa+592Mep8osbMTGNI4rwvbIRg9xUiDfFT9Mn3JkFYMpwW+ADNDo35K7eU2WZ /ZwIfgzkc4I6i5ProlBP1T+yqrSfSW1222wvSmbb1xej+KYZH+w0gJ+Smy2bnlTPAhOgb+dmEJ5 kYkhmaXWJccN3DnYF3GcFzI0r9CYMLtbQCeWsLqg7xalea0Yn0mYcz1VCWs2g3NP+r169AbaRwN BLIQ6XpNzYtg75at8LtV5I8axErb6XlKhLFNuGcIyMGHFoOA== X-Received: by 2002:a05:600c:4708:b0:495:5de0:d87 with SMTP id 5b1f17b1804b1-496c65a907cmr14079295e9.36.1785226855632; Tue, 28 Jul 2026 01:20:55 -0700 (PDT) Received: from horizon.localdomain ([216.128.28.240]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-496b388d5b4sm208150465e9.3.2026.07.28.01.20.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 01:20:55 -0700 (PDT) From: Sean Rhodes To: chrome-platform@lists.linux.dev Cc: Corentin Chary , "Luke D. Jones" , Denis Benato , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Prasanth Ksr , Jorge Lopez , Mark Pearson , "Derek J. Clark" , Joshua Grisham , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Sean Rhodes , Huacai Chen , "Michael S. Tsirkin" , Chen-Yu Tsai , Tzung-Bi Shih , Brian Norris , Julius Werner , Thomas Zimmermann , Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Krzysztof Kozlowski , Bjorn Andersson , Geert Uytterhoeven , Dmitry Baryshkov , Arnd Bergmann , Eric Biggers , Luca Weiss , Michal Simek , Sven Peter , Florian Fainelli , Bjorn Helgaas , Takashi Sakamoto , Danilo Krummrich , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Titouan Ameline de Cadeville , Kees Cook , dri-devel@lists.freedesktop.org, Oliver Lin Subject: [PATCH v10 1/4] platform/x86: Sort firmware attributes class includes Date: Tue, 28 Jul 2026 09:20:46 +0100 Message-ID: <6f133bb3fc42d2408037033aefcd2cad6d724470.1785226809.git.sean@starlabs.systems> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move firmware_attributes_class.h into the main include block and sort the affected includes. This lets the header move replace each include in place. Suggested-by: Derek J. Clark Signed-off-by: Sean Rhodes --- drivers/platform/x86/asus-armoury.c | 2 +- drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 9 +++++---- drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 9 +++++---- drivers/platform/x86/lenovo/think-lmi.c | 5 +++-- drivers/platform/x86/lenovo/wmi-other.c | 2 +- drivers/platform/x86/samsung-galaxybook.c | 3 ++- 6 files changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c index 495dc1e31d40..f3d8c5a85762 100644 --- a/drivers/platform/x86/asus-armoury.c +++ b/drivers/platform/x86/asus-armoury.c @@ -20,6 +20,7 @@ #include #include #include +#include "firmware_attributes_class.h" #include #include #include @@ -34,7 +35,6 @@ #include #include "asus-armoury.h" -#include "firmware_attributes_class.h" #define ASUS_NB_WMI_EVENT_GUID "0B3CBB35-E3C2-45ED-91C2-4C5A6D195D1C" diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c index ab46a023cc34..4ff9003c6589 100644 --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c @@ -8,18 +8,19 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include -#include #include -#include +#include "../../firmware_attributes_class.h" +#include #include +#include +#include #include #include #include + #include "dell-wmi-sysman.h" -#include "../../firmware_attributes_class.h" #define MAX_TYPES 4 -#include struct wmi_sysman_priv wmi_priv = { .mutex = __MUTEX_INITIALIZER(wmi_priv.mutex), diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c index 27fd6cd21529..1965a329be48 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c @@ -7,16 +7,17 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#include +#include "../../firmware_attributes_class.h" #include -#include #include +#include +#include #include #include #include + #include "bioscfg.h" -#include "../../firmware_attributes_class.h" -#include -#include MODULE_AUTHOR("Jorge Lopez "); MODULE_DESCRIPTION("HP BIOS Configuration Driver"); diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86/lenovo/think-lmi.c index e215e86e3db7..9e4b3e973de9 100644 --- a/drivers/platform/x86/lenovo/think-lmi.c +++ b/drivers/platform/x86/lenovo/think-lmi.c @@ -13,14 +13,15 @@ #include #include +#include #include +#include "../firmware_attributes_class.h" #include #include #include #include -#include #include -#include "../firmware_attributes_class.h" + #include "think-lmi.h" static bool debug_support; diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86/lenovo/wmi-other.c index fbb32bf404f2..fdebaa0a9992 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -33,6 +33,7 @@ #include #include #include +#include "../firmware_attributes_class.h" #include #include #include @@ -50,7 +51,6 @@ #include "wmi-capdata.h" #include "wmi-events.h" #include "wmi-helpers.h" -#include "../firmware_attributes_class.h" #define LENOVO_OTHER_MODE_GUID "DC2A8805-3A8C-41BA-A6F7-092E0089CD3B" diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x86/samsung-galaxybook.c index 6382af0b106c..74103c00b0c8 100644 --- a/drivers/platform/x86/samsung-galaxybook.c +++ b/drivers/platform/x86/samsung-galaxybook.c @@ -14,6 +14,7 @@ #include #include #include +#include "firmware_attributes_class.h" #include #include #include @@ -27,8 +28,8 @@ #include #include #include + #include -#include "firmware_attributes_class.h" #define DRIVER_NAME "samsung-galaxybook"