From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46934C41536 for ; Thu, 1 Apr 2021 18:06:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33779611EF for ; Thu, 1 Apr 2021 18:06:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237881AbhDASEt (ORCPT ); Thu, 1 Apr 2021 14:04:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31656 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236268AbhDARoQ (ORCPT ); Thu, 1 Apr 2021 13:44:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617299056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xpun99tvWb1lx2RACJU6X8cw0dJvrT8bzWLMZnVlAdk=; b=BNSCE9vYkFpkCSWwwpnQRBzOWrNfRr2mRufSWK5jSjTe0wUQ+gvLXDI/sZZ+gDKLgwkJEF V0WXjCMh35J0XVFW2SyKz4xiPD/b3wqgeeunlAojTxD8IiyTlciI4bqhl728cXdLnW7ywi uSJIPOh6GbD+En9gr5lZcXvg5dGRsw8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144-3NdpqpWyM32lZEnJ4PXn3w-1; Thu, 01 Apr 2021 09:43:13 -0400 X-MC-Unique: 3NdpqpWyM32lZEnJ4PXn3w-1 Received: by mail-wm1-f71.google.com with SMTP id f9so1375235wml.0 for ; Thu, 01 Apr 2021 06:43:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xpun99tvWb1lx2RACJU6X8cw0dJvrT8bzWLMZnVlAdk=; b=DGtIjxCmSIPNnk6ULagoaOqj9bgx1w0qG40IzaEJ5rT8YvaNkhmYQRFnuiRWOkjIKG d7wsA806yHhYXmxVD0n4SHC31yggf//F11pZlAPXCCAbm0AoP1Icm/I0kwzc1AGmRl6u qQSTjrGvMirCb7LM1iDm3xrMyKPZE3Xqvd3/3QPPHxN3j64hME3U4aC3FS460Rwvfhqy ebf6VhPTMAbW7MtvhHSlkKy1EX7XUnPzaHubbq7o3oYctCqF5P9gRUB3eBk70YDJE7X6 u3yn1KzvEdifGlH5HyJM8VT0nCnfV7s5rNOZ1NuLBYovyniWo6HC0TDAeAFcCG6FOS63 Wrtw== X-Gm-Message-State: AOAM532WIPAFOQO6e0uJEsUOQ9z/q6+Hcwb2HWtbaqmm9mricHoG7mbL 7J2taW5KvF+4YNee/DZBSTZKw4BxvOCiJ+mD4pKBeEKKoUaEAOniRYFgF/3G5R0ffGv+twRopQy EszimpWZePbPWSkJsiqjbTCbl X-Received: by 2002:a1c:49c2:: with SMTP id w185mr8144711wma.163.1617284591746; Thu, 01 Apr 2021 06:43:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy74Z45BwFltJfqODTBF4QpnKZOLKhdk7mXnXxGmt5DzRb4wc5TlQU8xGt7xNshzePaYeV6yg== X-Received: by 2002:a1c:49c2:: with SMTP id w185mr8144686wma.163.1617284591546; Thu, 01 Apr 2021 06:43:11 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id r1sm12960441wrj.63.2021.04.01.06.43.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Apr 2021 06:43:10 -0700 (PDT) Subject: Re: [PATCH v2 2/2] KVM: nSVM: improve SYSENTER emulation on AMD To: Vitaly Kuznetsov , Maxim Levitsky , kvm@vger.kernel.org Cc: Wanpeng Li , Jim Mattson , Ingo Molnar , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Thomas Gleixner , Borislav Petkov , Sean Christopherson , Joerg Roedel References: <20210401111928.996871-1-mlevitsk@redhat.com> <20210401111928.996871-3-mlevitsk@redhat.com> <87h7kqrwb2.fsf@vitty.brq.redhat.com> From: Paolo Bonzini Message-ID: <6f138606-d6c3-d332-9dc2-9ba4796fd4ce@redhat.com> Date: Thu, 1 Apr 2021 15:43:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <87h7kqrwb2.fsf@vitty.brq.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/21 15:03, Vitaly Kuznetsov wrote: >> + svm->sysenter_eip_hi = guest_cpuid_is_intel(vcpu) ? (data >> 32) : 0; > > (Personal taste) I'd suggest we keep the whole 'sysenter_eip'/'sysenter_esp' > even if we only use the upper 32 bits of it. That would reduce the code > churn a little bit (no need to change 'struct vcpu_svm'). Would there really be less changes? Consider that you'd have to look at the VMCB anyway because svm_get_msr can be reached not just for guest RDMSR but also for ioctls. Paolo