From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A46DC1494D8; Tue, 21 Jan 2025 14:54:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737471243; cv=none; b=OO86lYmBlRBabDKK5blNbCNSH3J3OtMTqfrORj16BXpGOq4x+cXW6BfEZVJNto0WwPKX9LaPrabR27JXt1x/l21xxjMRU1uY665poudihphmfduqgJWTRm6I7XIeqYruUxxrSPR7UDe35mwQD3XmANQDoJAKYTXZg+eBNhV7Dc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737471243; c=relaxed/simple; bh=rsHq8jBxb143mGUXgh4V0lyo3/IWWBCtONuS5emlwIk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hbihFaybftGEi1puPaQrrc1yAa18A7jwnp+qdMiWGk+am+mDylXQU7lsIUGCsnR9YwC7iHX7sI28ok4zwgLAnbV0eLsjDzjXTvPpajCY4Uy06QD4kdkkxCpHJUSwEsKT2xK6cyUwJF9rHUR6ERug/RZaEKJZgvWg4DRXlW38jIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=0JkgvKr3; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="0JkgvKr3" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=jOdz1pir69ic1MtrrgXIbkYUZ+D5XBf/KaHWQiuYNhM=; b=0JkgvKr3zX/SWfsisMO3nGTokE GBPyL/5K4mu5uZdxFzuQLtxeeqt5LvSbTfVqPLZ8xtvKJgbTjEB+OAHzVF+mFZhfGQa70P7uiYPWE ttLFJov1r/nl9YFVDq3wDu9m7IwJZ6zUBzT9L5akMyDvRg+YiD8DhyUGqnld7RWt1Exc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1taFdP-006fA0-WD; Tue, 21 Jan 2025 15:53:44 +0100 Date: Tue, 21 Jan 2025 15:53:43 +0100 From: Andrew Lunn To: Andrea della Porta Cc: Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v6 08/10] misc: rp1: RaspberryPi RP1 misc driver Message-ID: <6f16b0ea-ebb7-4692-bfc0-79052f079bc1@lunn.ch> References: <550590a5a0b80dd8a0c655921ec0aa41a67c8148.1736776658.git.andrea.porta@suse.com> <2025011722-motocross-finally-e664@gregkh> <2025012143-rippling-rehydrate-581b@gregkh> <2025012157-bonsai-caddie-19b2@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > > Well where are those externs defined at? Shouldn't there be a .h file > > for them somewhere in the tree if they really are global? > > Those symbols are deined in drivers/misc/rp1/rp1-pci.dtbo.S (added by > this patchset) and created by cmd_wrap_S_dtb in scripts/Makefile.lib. Could cmd_wrap_S_dtb be extended to actually produce a header? But that might confuse static analysers? Andrew