From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83B073A6F0A for ; Mon, 13 Apr 2026 08:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776068376; cv=none; b=Qg+MmAK4bMlpAuIZLShfAh/TQKM++fYhHiIdymGDagj8ky9/32ZjkW6sWZbUz+FgPPuhK7udg2XlaRqqS3gySt2qvhXwTTABUFq1G7NSr6+h6kgHcAgJ5vu+VbqP4UiLs7SuHwrdmKM0m9skyJhYmBvuptBQMX1/ZsMTibbj0QA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776068376; c=relaxed/simple; bh=v3hG7y4yRnCYTDHJfLv+RlRSI64kcVeuoGzuMOR0SSQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Rp1zHwPPYSl5X/9lDeS53Z+epETcuoeqX5WZIjypoKcFf+53ls2uZKDOZ8FQBRqp03QMRU8KfIcFGr7TlrU7LsMNdX84Ow1as7iz/+Dbm1jEdF0Ueh5YIVM6g/IO0Ry4BjZsnfxK34zWg17D6pNs3fcn7yjKjtu87ItZlYFB0eM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z6K9vlYU; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=N2e4JDGt; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z6K9vlYU"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="N2e4JDGt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776068374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JmMy5pwfWIKm0sICiknZ66RitSHNtSjbkUjOxwmD6Zg=; b=Z6K9vlYUi8wX1MS6QFlqYmbR1knROCd9KrXSAFxyKDkWbnwtqVAmgC72w03CuIRg4kIBLJ tFxHL5mcALghMMJM6/+8nYH4ppxCx2VkVkY50/y5jasS5/d/uIc3DnEsEDBmmGAAWCmdwp 2y/c/VyqePh/TlpO8vQphFde0Of1yOg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-zyHRLeyBNF2ee2MqhWbTaQ-1; Mon, 13 Apr 2026 04:19:33 -0400 X-MC-Unique: zyHRLeyBNF2ee2MqhWbTaQ-1 X-Mimecast-MFC-AGG-ID: zyHRLeyBNF2ee2MqhWbTaQ_1776068372 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-488c2764f83so27631445e9.2 for ; Mon, 13 Apr 2026 01:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776068372; x=1776673172; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=JmMy5pwfWIKm0sICiknZ66RitSHNtSjbkUjOxwmD6Zg=; b=N2e4JDGty6YJVrYmVOAWGku47BVmutQFVGMJ11/3wivPBQJ5sgIuEXgP8KsN8pPvHh MJ53OylZZoK75YWfelw+ifgvLTR0cJDazUtaQYLbiTYkvDmv+S/l9dD/e5BeNQpTegyt TX+56HB7l/92KXcWY1je32OAblSvNzUDIhwszHgbfWLPO+TjbwWhWq+3XPqx6vGtdXI3 FHt+d7kMw663sDOMlw1SE9i2Nvy5DWXCcVppqjaTh2dY0So7dLHX0YdKSleI5n08h/eN w9Hm0jEYXUs5jq9+IalRULJm3GXFs1mEhLCbbvWbaDfaeUV6OwLXZCLDLHpDQ/42ad8C PjAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776068372; x=1776673172; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JmMy5pwfWIKm0sICiknZ66RitSHNtSjbkUjOxwmD6Zg=; b=KfLmF/cjcUjn8SEEzsyjX5nYy9qRD8DWqNKtfFpYI0Go5Z413dDZEeMypcJXTOeMF5 1+qiVRSqsYlYGQIMl6LtFhl07bEmhxUtueE4R1KFMjJLttdVrGLN0VMHGw9IrNUA/Pi8 44GMYXKBpSoj3tw1+VSGEdmOYu6IxMJFrbPJcUppqUVjVrYvoqqXLfy226vk77xYY8b7 9/i8bRTQ+KAnZMCeaOQXju7IyEJcIwufXhLQo+Hd8Fb/PwQ+ZB2Ea9uX7tV8cv1if932 FDSObCrObrkuasABGtHVXm94RZ2+xXe8+iG0uOAKiiFkvm3JDeioAxcD5mPBaOZ78de9 MvpA== X-Forwarded-Encrypted: i=1; AFNElJ+haSubd0/WLSuY24zJDHpai/hP4z8X+yxLO0b5lmybOuYCcjKyu/lYQvFtHoRUiFCgrH1o1rivvQI1A10=@vger.kernel.org X-Gm-Message-State: AOJu0YyoizjIIACY7Hq/yp9hA2+Ll1KsFN5N6RXwvGrVwMjFcbLp885X FmZLrHbo634vFKmvG8L3S64QaxwupipOoinMeCYJMK/FEkAIeVocAlnt38IOsHGlc02Cy8Z6RQ4 HIXGkKXaVaJtvBF8GhVsyUcYk298Yr3YqKpIh60fMj1Q/oLmKV+6F+QDxZNxYx2Q8reMVCpkoem D5 X-Gm-Gg: AeBDiesiNVDRjk+xxsTDyw/lH9EZnpYmgU6jILuOcSIx31dZbbU1aINWBBoTz1PCKV9 l7Zaog/eJ9Y/rC8FqO8qcxAAXRXsDRCnOFi5hClJyUWQN+c7wBR2JXKuYzKaB0+ry0k7D+lmFGJ XKEVf5As8IK3DvTPqAzSv+Sq8WC9co9NPvujQ4xgKqxkeuMkkx2603B0gFKd47IVnvshEgI//eo YvPwU3ZNAtEvXiRxof9aQSp0YFIpl9586htB3lR2Hsz/IPLmJWLjO0SiOGPARFEzCELZbTBuTby eQW4iPfo8WiA9QVDLxlV76SJW1VSMILAgX8s0UYEFcSU57XrUkW/2zbLioffVIUlJlsK6vtX4Q7 5xq+vTcXquZVDkMeU7Q2n4u1QS1FOafAINeflcIBR7jhqfj/gkBNSdfVxavugZJybjHBMtw0Hyu PEc9aOJCOp2PTga1U= X-Received: by 2002:a05:600c:c0c9:b0:487:1826:d89b with SMTP id 5b1f17b1804b1-488d67e262cmr110720585e9.9.1776068371773; Mon, 13 Apr 2026 01:19:31 -0700 (PDT) X-Received: by 2002:a05:600c:c0c9:b0:487:1826:d89b with SMTP id 5b1f17b1804b1-488d67e262cmr110720215e9.9.1776068371293; Mon, 13 Apr 2026 01:19:31 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d67b4a46sm195475725e9.4.2026.04.13.01.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 01:19:30 -0700 (PDT) Message-ID: <6f183cc9d2befcdaec3901be31f7af6c6bbb5022.camel@redhat.com> Subject: Re: [RFC PATCH 1/4] rv/tlob: Add tlob model DOT file From: Gabriele Monaco To: wen.yang@linux.dev, Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 13 Apr 2026 10:19:29 +0200 In-Reply-To: <64122474633aa17d872a7dc6233d7794e80f2784.1776020428.git.wen.yang@linux.dev> References: <64122474633aa17d872a7dc6233d7794e80f2784.1776020428.git.wen.yang@linux.dev> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-04-13 at 03:27 +0800, wen.yang@linux.dev wrote: > From: Wen Yang >=20 > Add the Graphviz DOT specification for the tlob (task latency over > budget) deterministic automaton. >=20 > The model has three states: unmonitored, on_cpu, and off_cpu. > trace_start transitions from unmonitored to on_cpu; switch_out and > switch_in cycle between on_cpu and off_cpu; trace_stop and > budget_expired return to unmonitored from either active state. > unmonitored is the sole accepting state. >=20 > switch_in, switch_out, and sched_wakeup self-loop in unmonitored; > sched_wakeup self-loops in on_cpu; switch_out and sched_wakeup > self-loop in off_cpu. >=20 > Signed-off-by: Wen Yang > --- Interesting monitor! Thanks. I'm going to go through it more in details later, but let me share some ini= tial comments. > =C2=A0MAINTAINERS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0 3 +++ > =C2=A0tools/verification/models/tlob.dot | 25 +++++++++++++++++++++++++ > =C2=A02 files changed, 28 insertions(+) > =C2=A0create mode 100644 tools/verification/models/tlob.dot >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index 9fbb619c6..c2c56236c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -23242,7 +23242,10 @@ S: Maintained > =C2=A0F: Documentation/trace/rv/ > =C2=A0F: include/linux/rv.h > =C2=A0F: include/rv/ > +F: include/uapi/linux/rv.h > =C2=A0F: kernel/trace/rv/ > +F: samples/rv/ > +F: tools/testing/selftests/rv/ > =C2=A0F: tools/testing/selftests/verification/ > =C2=A0F: tools/verification/ This change doesn't belong here, the patch itself is not adding those file,= you should probably move it later. > =C2=A0 > diff --git a/tools/verification/models/tlob.dot > b/tools/verification/models/tlob.dot > new file mode 100644 > index 000000000..df34a14b8 > --- /dev/null > +++ b/tools/verification/models/tlob.dot > @@ -0,0 +1,25 @@ > +digraph state_automaton { > + center =3D true; > + size =3D "7,11"; > + {node [shape =3D plaintext, style=3Dinvis, label=3D""] > "__init_unmonitored"}; > + {node [shape =3D ellipse] "unmonitored"}; > + {node [shape =3D plaintext] "unmonitored"}; > + {node [shape =3D plaintext] "on_cpu"}; > + {node [shape =3D plaintext] "off_cpu"}; > + "__init_unmonitored" -> "unmonitored"; > + "unmonitored" [label =3D "unmonitored", color =3D green3]; > + "unmonitored" -> "on_cpu" [ label =3D "trace_start" ]; > + "unmonitored" -> "unmonitored" [ label =3D > "switch_in\nswitch_out\nsched_wakeup" ]; > + "on_cpu" [label =3D "on_cpu"]; > + "on_cpu" -> "off_cpu" [ label =3D "switch_out" ]; > + "on_cpu" -> "unmonitored" [ label =3D "trace_stop\nbudget_expired" ]; > + "on_cpu" -> "on_cpu" [ label =3D "sched_wakeup" ]; > + "off_cpu" [label =3D "off_cpu"]; > + "off_cpu" -> "on_cpu" [ label =3D "switch_in" ]; > + "off_cpu" -> "unmonitored" [ label =3D "trace_stop\nbudget_expired" ]; > + "off_cpu" -> "off_cpu" [ label =3D "switch_out\nsched_wakeup" ]; > + { rank =3D min ; > + "__init_unmonitored"; > + "unmonitored"; > + } > +}