From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758078AbdEOM21 (ORCPT ); Mon, 15 May 2017 08:28:27 -0400 Received: from mout.web.de ([212.227.15.14]:58474 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753765AbdEOM20 (ORCPT ); Mon, 15 May 2017 08:28:26 -0400 Subject: [PATCH 2/4] pcmcia: pd6729: Delete an error message for a failed memory allocation in pd6729_pci_probe() From: SF Markus Elfring To: linux-pcmcia@lists.infradead.org Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: <07cd817c-3045-72d8-34e2-e81b73efc291@users.sourceforge.net> Message-ID: <6f241ada-c3a4-2dc1-206a-ead47de4214e@users.sourceforge.net> Date: Mon, 15 May 2017 14:27:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <07cd817c-3045-72d8-34e2-e81b73efc291@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:SHPsIsWqdtsp1rY/Uje8bhoN2zea3tES4XsfZQQhXoCBKOnsPj9 Kga2/cFG5ohb/J092AqyNEG/13xKW1ExmwIdRqC8l9cp2jAFIrBA6W8Ov8oFjiGke/KCZhv UVNpU3MktZOMXH2VgUYBRVzUVYC9vTp2fpl6x7UHG1K3Npu2VwvNjGt/Mm3mtq/vycTz3y4 1Y6dYFrUEU9/V1t0z11uA== X-UI-Out-Filterresults: notjunk:1;V01:K0:s2TzDO2kLB4=:T4XvseZqNzUcpG8iLL53a9 1Dp/Rt7iWqTJtDpFYvYUrFMUFZ3uV9WICWfY3XlJeY+QLlc7Im97vNJGTV5xVT4rtCYQg3ES2 wBgtQmqKdj82p7a+tVFls75GmlOP4NwHtmYAzuXtciSMe/rbeMfqgJAmhj8gBfkM6txLrhTIx 3F/seKsQIiDhiMMinoR0seXrdBRQgsugHMj0bFvC74rU5hGvkoB9neSbMEUBEQ3Tme01gqYHz uh3Cx5P5qEkOXzEungb3FSDnRK/ZpkORy3GHXNfN3OU5aQ4Vb6AdV6/F8ZCuwoSdKxRzV6cRK zZwCL75SUgFugXhhk651Z7txcLpWkNEVg0nXT1sFctPghMy/XcYNtVeE+2PRBZkRMAxh4IU9h wdo3PHW2/stAyXey0NgHYnEN3/ue32XxG72/dXvWQpASWWkdV+8wIqbY4jnmmBEVa2vgKHacq oJnauN/+g70TnENTlLbpm1fIKMTH8xlf91GWSfTiKa2fJ/ruB6fLZJf73Lbx4vm4SiO6WWEwx LkZmH9H7sXpKo7Rs1QlbOD/A2HKgIgfen57AS18PoRk1GAlpo9MMK9+l4dleXnbYcQOItUj2I if1w7Nae+cHALxaJAg8EF8XTbLpgDF3xrGMlg5Yj7BHnaM1hozXf4YexAJQlxinU77p8SKW66 JJNGvLE+IiwnsYtaXBq6rwIEoh9Hgb8shClTWA2vhupiG2UrLfbesTk/nuN/X/ywscLb7jANT +oCS17/bBGjjeSdbu49JfEaJj/eBi7Z+3+jnlvN9lC4DQqZoJiMAbkUkuWgtwpjrafDjy83Vg zTxsLhA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 15 May 2017 12:44:23 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/pcmcia/pd6729.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c index 289a5e74e852..a723ffbbd691 100644 --- a/drivers/pcmcia/pd6729.c +++ b/drivers/pcmcia/pd6729.c @@ -632,7 +632,5 @@ static int pd6729_pci_probe(struct pci_dev *dev, - if (!socket) { - dev_warn(&dev->dev, "failed to kzalloc socket.\n"); + if (!socket) return -ENOMEM; - } ret = pci_enable_device(dev); if (ret) { -- 2.13.0