From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02488C32771 for ; Wed, 28 Sep 2022 12:45:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233366AbiI1MpM (ORCPT ); Wed, 28 Sep 2022 08:45:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231703AbiI1MpK (ORCPT ); Wed, 28 Sep 2022 08:45:10 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7F6B29801 for ; Wed, 28 Sep 2022 05:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664369106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uufQYKHlB4NMDLgfrNjl6fs7TYc608vt4M1Drzs/IdQ=; b=EgSsMitTgjGRcjmAMhpxJb53Mx89pVWvUoqi5VIh7JEtc9jGR/l4oLZNDTGoGhvR2Nkxbb xxTvdBUswWTU8QljEnbyY3TnBvbuCbP/MwoPt70eT9ipTv8DkimOrz6uK+dlf0iovhpL9X j+5nUT7lY3KpXDY15z3+FvHzOSbi/UI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-251-DQtItYFTM1uLlF5u0_5VYg-1; Wed, 28 Sep 2022 08:45:04 -0400 X-MC-Unique: DQtItYFTM1uLlF5u0_5VYg-1 Received: by mail-wm1-f72.google.com with SMTP id y15-20020a1c4b0f000000b003b47578405aso521303wma.5 for ; Wed, 28 Sep 2022 05:45:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=uufQYKHlB4NMDLgfrNjl6fs7TYc608vt4M1Drzs/IdQ=; b=TMifZVALW1zNRA39VCyVGP9KdHm+95kQ5HipXY5XaqaH95jeH104prfgWzrFix1ott oKlmARKqRcaRfwTV9+v/+s7J6hLUDSkSsaplCR93RLCPSP7AW+STo1QwZu8ufRN11b0e tmXMgH5xMX95a/ZcQxw9g7LEEl1MCm+Wvz06nXaDp4zVKvcrHRVu3xSLZW4iXFBxZQKF b+W3opy4vKEkS67AROqm0eUq0HKerfzgpq1TPR/ce4ThlSqafF8VdeZIq80UMziedxNO SJyVlAOnPx2TGKuC1zagemfNx51APar8efsE/GgM2+QKYPUy7MmKYHU+gL8hTnRglJBe kI1A== X-Gm-Message-State: ACrzQf1Pqmsg46mqYu3DQ014dvjFEWPpxOxHuez08H/IUsZpqKHIlHU0 szEt+dZaiwo3ALbvlpOdsDgAWAkPR60JEoI1jO/FXcB+wGP8MnsAvupJYgzl+nYSAu38LB3HySJ v5lnO0t74lrDn4KTnC4M/VLVt X-Received: by 2002:a5d:54ce:0:b0:22a:e653:654 with SMTP id x14-20020a5d54ce000000b0022ae6530654mr20853566wrv.134.1664369103797; Wed, 28 Sep 2022 05:45:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6DXGXWYtOD1tp72GMv95ymx/s3vXL+wcRLQZFw20ZkjuJBEtRIWnmJ9pGR6pi/ghRFhlc6iA== X-Received: by 2002:a5d:54ce:0:b0:22a:e653:654 with SMTP id x14-20020a5d54ce000000b0022ae6530654mr20853525wrv.134.1664369103389; Wed, 28 Sep 2022 05:45:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:1100:add9:5f61:6b94:7540? (p200300cbc7041100add95f616b947540.dip0.t-ipconnect.de. [2003:cb:c704:1100:add9:5f61:6b94:7540]) by smtp.gmail.com with ESMTPSA id p13-20020a05600c1d8d00b003b332a7bf15sm1635047wms.7.2022.09.28.05.45.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 05:45:02 -0700 (PDT) Message-ID: <6f2615f2-27c6-34e5-77f3-166d0e7b6182@redhat.com> Date: Wed, 28 Sep 2022 14:45:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH -next v4 1/3] selftests/memory-hotplug: Add checking after online or offline Content-Language: en-US To: zhaogongyi , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kselftest@vger.kernel.org" Cc: "akinobu.mita@gmail.com" , "corbet@lwn.net" , "osalvador@suse.de" , "shuah@kernel.org" References: From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Reviewed-by: David Hildenbrand >> >> >> I am questioning the stability of the offlining test, though. >> Offlining a random memory block can fail easily, because "->removable" is not >> expressive: >> >> # tools/testing/selftests/memory-hotplug/mem-on-off-test.sh >> Test scope: 2% hotplug memory >> online all hot-pluggable memory in offline state: >> SKIPPED - no hot-pluggable memory in offline state >> offline 2% hot-pluggable memory in online state >> trying to offline 2 out of 96 memory block(s): >> online->offline memory0 >> tools/testing/selftests/memory-hotplug/mem-on-off-test.sh: line 78: echo: >> write error: Invalid argument offline_memory_expect_success 0: unexpected >> fail >> online->offline memory10 >> online->offline memory11 >> >> >> I guess this test will almost always fail nowadays. > > Offline some memory node maybe failed as expected, but the error message is a bit annoying. Ah, I see it now. We try offlining two and fail offlining the first one. Can we silence that warning in that case somehow? -- Thanks, David / dhildenb