From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3541635 for ; Tue, 16 Sep 2025 22:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=96.67.55.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758063490; cv=none; b=P0pw4iqVeuVNN3FZvAWLpaa+sdZR8n90MbKvYxQuJqv3HVBbNeumuqpv0FyJJ+0tXgPZZe29VZvcE8lYbGWlbzbccL3CVZjOudJ2FqkJmVMUUUBp5gvhQ/JiV+g1m0XsK7eS26RAl9BACljPKb/dgOZMqQrwNuKmQfWiFEx1Av0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758063490; c=relaxed/simple; bh=962Ya8WbZIcFc3rK6+ItlnR0V3Bzyc7brf0QRJ6xPtE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=TSuav3DIyyyNpkDVLz/p3ijF1tWQ5tcMPdEUNxEKoOouc47C5W4h8s4+B/WDv2MBOE4apUPBg/+qx7sIp2jX4d1Cj8Aed8SVt+xfsGRDXOukK7D6ev7C6poJvz2m3WuHh6F0WVb2v9W6HedcX5Dxd1hEWaGd1Dn0G9CimLPOd34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com; spf=pass smtp.mailfrom=surriel.com; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.b=CdJQYLee; arc=none smtp.client-ip=96.67.55.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=surriel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.b="CdJQYLee" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=surriel.com ; s=mail; h=MIME-Version:Content-Transfer-Encoding:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=962Ya8WbZIcFc3rK6+ItlnR0V3Bzyc7brf0QRJ6xPtE=; b=CdJQYLee3GQh+wKmt21VERifqu 6Av289A+zkiPEcjm6ZnN8BoKTYLKZ2+ITCjU+U4ydipm+NcvRBPvqHW3QcW3xTjBVADIMANoMNhXp 4cIfbuN8LOzUFypuh3D9P1dEZLtEJdpcC43uZqPbE74uy/aX6GxV4nPqhfCY0m3wZAHdMyQJTDqdg WphqZxbJMol0LgnG/sYUihaq7ZMkstU3W7J4GHIEID8+GYzzzsm/Trd8mBmf/mYdZJp0iOz7B0SVb 34h4+fIQDDPDMw98eVnB+dN0y/PDC4oHuC7+o/IzkZkpkNpz2MHu5rg7zLmgHPwgBxqHGtvkkOQRA o5YcdK2w==; Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1uyecK-000000001Qv-3GIS; Tue, 16 Sep 2025 18:57:44 -0400 Message-ID: <6f2708406372450edb39ed6ed5a5d0bc112c84af.camel@surriel.com> Subject: Re: [RFC PATCH 05/12] mm/cma: add helper functions for CMA balancing From: Rik van Riel To: Frank van der Linden , akpm@linux-foundation.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: hannes@cmpxchg.org, david@redhat.com, roman.gushchin@linux.dev Date: Tue, 16 Sep 2025 18:57:44 -0400 In-Reply-To: <20250915195153.462039-6-fvdl@google.com> References: <20250915195153.462039-1-fvdl@google.com> <20250915195153.462039-6-fvdl@google.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2025-09-15 at 19:51 +0000, Frank van der Linden wrote: >=20 > +/* > + * Provide the next free range in a cma memory range, as derived > + * from the bitmap. > + * > + * @cmr: memory range to scan > + * @start_pfn: the beginning of the previous range > + * @end_pfn: the end of the previous range, zero for the first call > + * > + * The caller can adjust *end_pfn end use it as a starting point. > + */ The function documentation does not really make it clear that start_pfn and end_pfn are also used for the function OUTPUT, and that the return value indicates whether or not a next area was found. Same for cma_next_noncma_pagerange. Other than that, this looks reasonable so far. --=20 All Rights Reversed.