From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CED1D30D406 for ; Thu, 30 Jul 2026 06:37:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785393432; cv=none; b=UZ4ymYzmd9FGltdLKi/1sivdfO6AXN/LcewrgpHuvFEiJA6M59QveOC8790N6wD4LvH6dL78hkrn8NW9VWPm/2A+sDz5Q9t479zYGHafWD30G3gbObhgs48llLsaF21zepp4CzENwSKKLRYeXWJwhILzsKZj+PBJEIGNoCOjqcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785393432; c=relaxed/simple; bh=143qVcfHrDUndtdM+/SnV2vC7F35FUc3Kc9bqs9KHT0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K+pPSTRL9DI+GRkCz0bwV782UnY5JBKFX6qNgdmdckRHp0j9VKC4DuJ4TlHlPPmfQOOILV36I0gyJkuhBQIwkZIGLjadIVx1kMM0x6Ep19JiksmS8fD7cemRcgtPZ+UT0M0g1elipqn33XH49Ok/UF0noVareIOCyJarlNcXXOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TvszRTw2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EiswUGuR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TvszRTw2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EiswUGuR" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66U6b0Ht1189090 for ; Thu, 30 Jul 2026 06:37:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6/UOShqbHnV7Ke1cD00vlv35wu1bLj2I4lxM25OdUZA=; b=TvszRTw2kHk5SD7Y m+VGxf/yguCwWTSiZg9FVjbmDotbWjZhNkVEFe3fcYTTSXfJdHX3/xu3h4ad2XiI 2/+yr4luMgp4VF7ak2Vf7iY+8VYLXrtnFBNZVkX6Mio7pwA8wE3aFDZn4CTEBfpR Oa4TsIFZ2ptSBS1cY0P/CpC5j++lZ88DjyxD2zatgrHbSC3GYlxkg601imFOyiMw Q9ss/7dDPgao5yigLKHGy8PAAoDSz4KVHSK9YR596OUoIRVx5wOVVtIoG3w+hWrn aqCC4IohOteltobyui0Djth6C1ELRZwEALlVCt5hsdQWOIpd1I7kkI74ba+i8+Fz OFFwcw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr1fe00gh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 06:37:11 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb733fc5024so2575781a12.2 for ; Wed, 29 Jul 2026 23:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785393430; x=1785998230; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6/UOShqbHnV7Ke1cD00vlv35wu1bLj2I4lxM25OdUZA=; b=EiswUGuRdyfj7K6MDuLf4wmn2uQXu0u5uARka1Q2Ag2IYZzH5L3f4OdJTXEQ3CN8Nz Ma+kaLH+i0fW4i5wc5N5WUjZlo8/LYX2CkEItKfheTYjgqeX2jz7Np5r6JDPXf0kl5Lr K5zrkG5JeYjfHVIPBNhAiqXNgrAShAQqaWTr0QgdoCAK/wTPbdSFvWIo/LQ9wOcEUWTd vyh4OkX9JzS6FUqFtUXhUjf97jJxyCDp2n/4X3QwlHc6OH6hgukcaZh4B2eTnDYlmyAb FWFvGIsQT1xYT3XMwu5y33v5vEgLiGz6qocFrq0CxaC//ouYFsjsl/lyUYhkyMeIDpwf WDsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785393430; x=1785998230; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6/UOShqbHnV7Ke1cD00vlv35wu1bLj2I4lxM25OdUZA=; b=PPlT2JG9LrSrGGJTF/i8BeX2kXZq+w3QpFTT/Dvh11Fjg2Sr3b7gaO0IAfDnG67Kdc ChbOfjpeqo5PVLZIUl7r11kgBc4Sm2xFFr05hqVbhAbDzAxH2r9r1oMfafi7XEh0Ry3H IkfgOT8tz2pVnSDyUTrVkjTcednRjrK5oTHl/hqhwZbzb9splGm1KAbWBzvhKnycayz0 w0a44ASIAQwJhS9CYo/UQjGG4k3UX0m6Y/hrDczJP8HM0/zkFxCvSbGP9MPbLzAMhJgf X+QQi002H3HNWTYovoCpxutpltW3FaA/ADbHeQSthL7L7bl40wjuJVQTCVp+ITc3V4vH Vr7A== X-Forwarded-Encrypted: i=1; AHgh+RpbQh+4qGOkGlIMQlKGodiIpL0xDcEkKh/kZlfGPDD2mJcjsf42HoWJVti1krAku18CdvihuluMBs1jbi8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyw0DQi/UIfLGvRDUdVroKlch072SjbXAvuLr6UsvICW4Y08P0n WX8v1ZG8TJAREORbODWn4W8AQQiFvByYqXEdoDu5a7otsv/QWm9i504A9vlrzGefahCnvpG2rU/ Nq/h7p8cYz8eBnHPhXjHIbVTNN5NAmRelHPhxAtVcwFSpfcNLyvmqZBZ6SA/69bhxAqpbRRK6IJ g= X-Gm-Gg: AR+sD111UHSUO1aD7HFi798k0/7OGHIsOfOuBD5kHEEMiBCeC92kms6oxEbaTnQ3J8b gjHZO/0VY4V0OGJUYjT0J2orha5q6ajBrWQVox83oQktBX0xEdVauwSnudfAyutsXcDjQX99SIV 7txl36nwSOcDkAM3WLtfThJtmfO0QcBQrBwp9ZDlOycC7gG9cdBmzHP2+hV963+lVpWykaRT8YS 8nPcxX4hRViYGRMVZJ5LsJsyQWcDtgRjJy8ptyUHTT4yYhN2azz9FqxGp/gWN9QlLsjf0kCHjUF RhV8p42MupyEPdACQRr6Aj8+tYI25X5/97UQCGCF9NKYsDPz+urDQtyCVqYbslubGEbfGbYBJb4 tFTY6kxUXoIGcrO36ehvkA5KCykm6Lb1JskA64nM27h9c3WY6cOnnaZU6lKHPzjUQlIod+a9P/s PKTulIkMpBSeJRLA== X-Received: by 2002:aa7:88c9:0:b0:848:2f73:9002 with SMTP id d2e1a72fcca58-84ebc4247cfmr1485956b3a.75.1785393430544; Wed, 29 Jul 2026 23:37:10 -0700 (PDT) X-Received: by 2002:aa7:88c9:0:b0:848:2f73:9002 with SMTP id d2e1a72fcca58-84ebc4247cfmr1485930b3a.75.1785393430157; Wed, 29 Jul 2026 23:37:10 -0700 (PDT) Received: from [10.190.200.192] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84ea0373cd3sm2457635b3a.42.2026.07.29.23.37.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 23:37:09 -0700 (PDT) Message-ID: <6f2fc314-9e39-4bf7-b1ce-b51dd564daf7@oss.qualcomm.com> Date: Thu, 30 Jul 2026 12:07:04 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] platform: arm64: qcom-hamoa-ec: Verify required I2C adapter functionality To: Konrad Dybcio , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20260728-ec_add_more_commands-v1-0-771abd65ee1a@oss.qualcomm.com> <20260728-ec_add_more_commands-v1-5-771abd65ee1a@oss.qualcomm.com> Content-Language: en-US From: Anvesh Jain P In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDA0NSBTYWx0ZWRfX2GUswMfdAFVT t4IvBVd2EsX97rsE4GlpiZqZYwH0lMzNYmN1yqavqIg5KlHjpgyO9AbvRJpXAaxwLp58ntCFc+e 0M9Nn860zSES57yZDeukrijAhTdcXqkkkVLtdLhoJlTgAig8repHXLR8/3cIX6UfKiRedZDapDF HYraYF5xyX7NrJNFOXwjyjsIQ/83Sq6lkFjhyXWZ4o/JjHhfH3JOiEY1x+BCfVcaLWCQhVWVeKB yOb60IH7X9G2bd6R0UKKUFulfdSdf58GQwFl2mqrAGJqjRdCCTFLZHEBfkyuAX6OMBBhbVYmm2Q 7f0fEOfV0DJl31fk3pGhTUHPKnfBlpBmQPeemH3fZZVJl1HW6M0vzKz8hEqvcXj3L+UpUrJuQJ6 FhpAYDEIHvE4fz9WnaT/v35fitGxYL+loJSJMZmfNsSTkTMPJZA0U+TM1S4uw46T91EGxp2ZUqC jRaIpC7mdwLQwIr/pqQ== X-Authority-Analysis: v=2.4 cv=IaO3n2qa c=1 sm=1 tr=0 ts=6a6af117 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=CFGf0PpD_GUA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EJZTz2ZzxWxwHnGGTj8A:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-ORIG-GUID: F3KbEeUELDc5dTbqtqH6mWtyuUCtVhCu X-Proofpoint-GUID: F3KbEeUELDc5dTbqtqH6mWtyuUCtVhCu X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDA0NSBTYWx0ZWRfX048NWEBh/GFk vQyTfTILK3yonT7deCyaF39o18+BVmvSP3BDULZIb75KTFpEsZ6zpqc2KGVvRtRLnwyRxzBKU8h Y3f6XL+J1FwNCGh1CmCWr2cfVHWYgDM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_02,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300045 On 7/29/2026 4:38 PM, Konrad Dybcio wrote: >> + if (!i2c_check_functionality(client->adapter, >> + I2C_FUNC_I2C | I2C_FUNC_SMBUS_BYTE_DATA | >> + I2C_FUNC_SMBUS_WRITE_I2C_BLOCK)) >> + return -EOPNOTSUPP; > return dev_err_probe(dev, -EOPNOTSUPP, "I2C adapter missing required functionality\n") Ack, will switch to dev_err_probe() there so a probe failure due to missing adapter functionality actually shows up in dmesg. -- Best Regards, Anvesh