mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Jerry Hoemann <jerry.hoemann@hpe.com>, erosca@de.adit-jv.com
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [V3 PATCH 0/2] selftests: watchdog: Add get/set/pre timeout
Date: Wed, 26 Sep 2018 15:37:34 -0600	[thread overview]
Message-ID: <6f3a8fe3-1ec4-ed8b-99a2-1dba7553c1fc@kernel.org> (raw)
In-Reply-To: <1537996989-13092-1-git-send-email-jerry.hoemann@hpe.com>

On 09/26/2018 03:23 PM, Jerry Hoemann wrote:
> Add command line arguments to call ioctl WDIOC_GETTIMEOUT,
> WDIOC_GETPRETIMEOUT and WDIOC_SETPRETIMEOUT.
> 
> Changes  v2
> 1) Update usage to include argument
> 2) Update usage to give example.
> 3) Made printf of WDIOC_GETTIMEOUT distinct from WDIOC_SETTIMEOUT
> 4) Made WDIOC_GETTIMEOUT a "one shot"
> 5) Made printf of WDIOC_GETPRETIMEOUT disnct from WDIOC_SETPRETIMEOUT
> 6) Made WDIOC_GETPRETIMEOUT a "one shot"
> 
> Change v3
> 1) Printf says errno, but prints the string version of the error.
>    Make the printf consistent.
> 2) As above error was cut/paste from prior printf in application
>    add new patch 1 to fix the existing printf first.
> 
> Jerry Hoemann (2):
>   selftests: watchdog: Fix error message.
>   selftests: watchdog: Add gettimeout and get|set pretimeout
> 
>  tools/testing/selftests/watchdog/watchdog-test.c | 41 +++++++++++++++++++++---
>  1 file changed, 36 insertions(+), 5 deletions(-)
> 

Thanks for the patches. Applied to linux-kselftest next for 4.20-rc1

btw -for future reference, the convention is [PATCH v3] not [V3 PATCH]

thanks,
-- Shuah

      parent reply	other threads:[~2018-09-26 21:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 21:23 Jerry Hoemann
2018-09-26 21:23 ` [V3 PATCH 1/2] selftests: watchdog: Fix error message Jerry Hoemann
2018-09-26 21:23 ` [V3 PATCH 2/2] selftests: watchdog: Add gettimeout and get|set pretimeout Jerry Hoemann
2018-09-26 21:37 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f3a8fe3-1ec4-ed8b-99a2-1dba7553c1fc@kernel.org \
    --to=shuah@kernel.org \
    --cc=erosca@de.adit-jv.com \
    --cc=jerry.hoemann@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®