From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D5BEE6424 for ; Fri, 15 Sep 2023 07:04:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232426AbjIOHEW (ORCPT ); Fri, 15 Sep 2023 03:04:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229693AbjIOHEV (ORCPT ); Fri, 15 Sep 2023 03:04:21 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 051DDE0 for ; Fri, 15 Sep 2023 00:04:16 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-501be2d45e0so3067156e87.3 for ; Fri, 15 Sep 2023 00:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694761454; x=1695366254; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xHiiw2zLmDDKdBpJJDRZPiiiZQs08sZNPmWWWLIoN4o=; b=RrgEbkwA2AVjCwnK3qad1t0RKawdDXzgVP9FM1Q7Ebe7TGbAJd1nQVrWMMECDoMHJs rLrCD07B8W06Wy5bL8CDSN+EeBssTIuUbZRXA4+NNJrNtO7NB1DYNm6R795Ow5PA7OK0 +3dFwej10XHCKjHr1BbRFp+XBa+xkVjXUcuOQl8NC1CFjbwidrDOkjIdoVLifBeUJakb YKXY4r1DHd9FZ4DmMrHZiyJItDjSE0WOmqCR8X271MBDcNfS65uYB1BiST7nojY9w+VS XS8GbcSjrXN1h2IgAvmgqcMZMnwGCqqFYvfbvEGnqAC2IfnZc/UiTTgykRoxAp6i0JaC 28og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694761454; x=1695366254; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xHiiw2zLmDDKdBpJJDRZPiiiZQs08sZNPmWWWLIoN4o=; b=JVMM0iKQLsE6Is3u1aVajsRelMjajmV+Tc3vgSUM8gDLRVz0cyxQVQJzRIubGtx0Jg Oo2y+StbKrkt3HBGSOgnZ6W2WYK0WjhDD1h5ZCNjnmwSYfIrGy3cxvcn9PJRaZNhN+2I mt/J4iBqRM+FPfg9HBLAnanyNsEED2RqoLNBd0DI3MVBsPDkRZd+n09+szTnlYwqkKG7 QcTYrLgi7ef3sKagNCRpNqXOVPi3BL4knnUPxEPz148fuMVr3v6Jy9B9du0ugpTxPV2m gZUmF5VPC3J+QZpG9VNcPQlsUs1jQmnUhGw9Wx6R1W9OcfnXHg0/kYS5lHo0gK3Ezg/A jnTA== X-Gm-Message-State: AOJu0Yy9iP3BHUC2DhV3vDl03eX3hsMYNKMrQOoHc8+daozpU4+n2VYk MKPt5RWm1fjx7EDCGomOC8TYgg== X-Google-Smtp-Source: AGHT+IHg6sh6ARvRYSwuyoF2hmtnjsmopqC9TmkEeYtf8f4hqHAhSC4oiX7GDCdXqzTzoglQYBrSmQ== X-Received: by 2002:a05:6512:2082:b0:4fb:772a:af12 with SMTP id t2-20020a056512208200b004fb772aaf12mr617044lfr.21.1694761454189; Fri, 15 Sep 2023 00:04:14 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id v21-20020aa7dbd5000000b005256771db39sm1818148edt.58.2023.09.15.00.04.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Sep 2023 00:04:13 -0700 (PDT) Message-ID: <6f40ee72-b763-c58d-44df-ea40d1309820@linaro.org> Date: Fri, 15 Sep 2023 09:04:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl Content-Language: en-US To: Tengfei Fan , andersson@kernel.org, agross@kernel.org, konrad.dybcio@linaro.org, linus.walleij@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_tsoni@quicinc.com, quic_shashim@quicinc.com, quic_kaushalk@quicinc.com, quic_tdas@quicinc.com, quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com, kernel@quicinc.com References: <20230915015808.18296-1-quic_tengfan@quicinc.com> <20230915015808.18296-2-quic_tengfan@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230915015808.18296-2-quic_tengfan@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/09/2023 03:58, Tengfei Fan wrote: > Add device tree binding Documentation details for Qualcomm SM4450 > TLMM device. > > Signed-off-by: Tengfei Fan ... > + > +patternProperties: > + "-state$": > + oneOf: > + - $ref: "#/$defs/qcom-sm4450-tlmm-state" > + - patternProperties: > + "-pins$": > + $ref: "#/$defs/qcom-sm4450-tlmm-state" > + additionalProperties: false > + > +$defs: > + qcom-sm4450-tlmm-state: > + type: object > + description: > + Pinctrl node's client devices use subnodes for desired pin configuration. > + Client device subnodes use below standard properties. > + $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state > + unevaluatedProperties: false > + > + properties: > + pins: > + description: > + List of gpio pins affected by the properties specified in this > + subnode. > + items: > + oneOf: > + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9])$" This is still wrong. How many GPIOs do you have? Please open existing bindings for recent device (e.g. sm8550) and look how it is done there. ... > + > +examples: > + - | > + #include > + tlmm: pinctrl@f100000 { > + compatible = "qcom,sm4450-tlmm"; > + reg = <0x0f100000 0x300000>; > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&tlmm 0 0 137>; > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupts = ; Missing example pieces. Again, please base your work on other recent files. > + }; > +... Best regards, Krzysztof