From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ABC939FCE for ; Sat, 28 Mar 2026 16:36:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774715771; cv=none; b=uUBk2AoxwyeEcJAoT3VcL0gLeIox75mLhV/F8QrHh9e+EGq97nF2tYHhlfiiTY6QY1vdRlQsnUqtbM7h6zGfdqQ5f4/AlQsIuOi+wJuKc8/I3Gq1BvE7yk9tSB8YJh6/+GI82AVS2euyoKZC2msf19MMYINJyj53ehuA9inE+pA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774715771; c=relaxed/simple; bh=93XagFVPNl3duxbBvxcwUDBo3vyzqKak8SMWenv0TS4=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=TiF/cIdzPIlWN44aKfjG1E5SkJrMPgzx59C+5QoaLF0LFsc32P48+lm2Q1yA/VQf1F3i/5sTpGbHXcFMMPCZPfeNKhJq8q3gYZKgozYEru8R1v3CG5jP417wpoamlZ/Q5k/7XMqI6Uye/Ld59qn3JVFBt3g+hbnxaxkNebhcF28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ELVUI2MD; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ELVUI2MD" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-38a43f1f978so27170561fa.3 for ; Sat, 28 Mar 2026 09:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774715768; x=1775320568; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=y7pyXU2qFzEOnU8j2MDB/XlKYkbXJkeDxLklHnoWscA=; b=ELVUI2MDroZTR6E/s7uuxVYzyxUGLN4Adn8NkYWJWAaVMnttI2F/Ai4yRQ10Xl+l5I c0k4He9c0Bp9v4TVAIzDMdSd+ZhIVKb+bEtahOORlGo0LVpJpKdQtwnkah7tBVAFtDhc gE7Xr6z/ITdc6GqTyFpejzDB9xF8BBj2s/pmdYIHdkO7mYHCwKKtxqgrXZfTQTrO5cLA Uda3CaqucDhNwHhDFDq+JtBBLCm65k9s7gONI1NZVa8A1yJXpQ1wRWEEVVP2Ye6EDKnO LLCFAJ3D0WuNtlr8i7oqoodx07kMSvOCERks+RD/G85Qri6wkZNWY4xr1Y9mOKrOP1m6 04eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774715768; x=1775320568; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y7pyXU2qFzEOnU8j2MDB/XlKYkbXJkeDxLklHnoWscA=; b=FXaXZetTk2zzZh8WDpPC0SRVKtjECk1P/tHREO4Sq8MUtDvLUeTrsZSTO3mRgN9hz9 DTVQrS7fDQen3EOUceOsdH4+1FOiRQQzpjJjXFsHqW9XwgDORwhXHSiX34MZyzb7d0pQ dnz20l+pCFDawk67C/o1pd3VpNb1bRPBqUKqOol8pbqFi0WU/c5HtMFPRByoi5O9+sfE z6KZYsi8pzAEcRgz5PLF+eEoBsOyMvgNXruNGu8SU+D5dQBDd+Cvna8q8rRC24RsSP49 JshnYXK8+F/hBnTFpCIJNfRsxRyIEMmrmek3CM5eZ9vkOtpAHYgVrGXd8teKRhy177UE jQ3g== X-Forwarded-Encrypted: i=1; AJvYcCUCe45bPuKdR2SpwYQa/YVYdv7viV5wmHN9XhGNnNsu9fyLwi2x0DoWxAnMRjNKmzTCDVlpZD3SvuaQXMU=@vger.kernel.org X-Gm-Message-State: AOJu0YwZBm0gWT523DJgAkbGDLAh5Ocs7gNaIgytaLtM/6LNwEkhagZ2 B7MCKbFfHgKO3GfcjerV6r0DHw8oPBjtPEfpKsgQe9G11ZN3ung5pgsEVEfxsg== X-Gm-Gg: ATEYQzxeNk98mRP/9muUY0WmxogcgSSDxhWjvF1TzhjpSpxEUm4VFI9zohxZfLPiqlg RpPgsmmTPbGQFz+mirOgV98uQr7HonfHC5U9Q9kc1/JH3KJTMpDnbvS8bD5kIZlgRhlwtTv3GkI ecq1n4pVJGMpt4NsXspZEd5Io9MZCrt4YDLcl1k9sjUAkP0UJWENxYbNBHCmpOfM0DQUT0eId7a IgSdeqPUhaKZB42sJkb9PnYFJbie3sMpOxy4+TB4gYN79Du+iUJtm/Bbph4rX9MQ3n+WuXV8nFY akZlmV9V5KbrB+fQz14o2Uu9wcw/T4Vp9wA02VzDCBMIee8eTVJrMPRe6QbGNPjjBjQnhN64hCg XJVMxVHMPGzaqj+bOFZGXjDz7UJZV0YiNrraTRA12DC+ktU/NiKcSjYdcMkM4pflI6KEpB+W4gj K+ASjZATMUt+7SdBAlMCAjm4rxoxNzCdjr8fraXzXOA5Lx/9rkrjLTD4eDitU0YLA+nVptOX1L/ bSirwqoASj8hp1Fay/4zzlDoJkjhRFQSZe0fX7lWSjy8E+EdJ16dbb8tF2PE6NQUkVcNy6nQ0+Y Cq16DOyY0yLRTOOz+pnsgMjAl3tZI3oEmS7kkpbY7WmX X-Received: by 2002:a17:907:1c1e:b0:b98:5b6b:9138 with SMTP id a640c23a62f3a-b9b50363003mr311019166b.19.1774693320670; Sat, 28 Mar 2026 03:22:00 -0700 (PDT) Received: from ?IPV6:2001:1c00:20d:1300:1b1c:4449:176a:89ea? (2001-1c00-020d-1300-1b1c-4449-176a-89ea.cable.dynamic.v6.ziggo.nl. [2001:1c00:20d:1300:1b1c:4449:176a:89ea]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b7b1e3aeesm62735466b.48.2026.03.28.03.21.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Mar 2026 03:22:00 -0700 (PDT) Message-ID: <6f42d92b-a26d-49a4-bef7-2227c252eea7@gmail.com> Date: Sat, 28 Mar 2026 11:21:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net: phy: air_en8811h: add AN8811HB MCU assert/deassert support From: Eric Woudstra To: "Lucien.Jheng" , andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn@mork.no Cc: frank-w@public-files.de, daniel@makrotopia.org, lucien.jheng@airoha.com References: <20260326153518.8387-1-lucienzx159@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/27/26 5:41 AM, Eric Woudstra wrote: > static int __air_pbus_reg_write(struct mdio_device *mdio, u32 pbus_address, > u32 pbus_data) > { > int ret; > > ret = __mdiobus_write(mdio->bus, mdio->addr, AIR_EXT_PAGE_ACCESS, > (u16)(pbus_address >> 6)); > if (ret < 0) > return ret; > > ret = __mdiobus_write(mdio->bus, mdio->addr, (pbus_address >> 2) & 0xf, > (u16)pbus_data); > if (ret < 0) > return ret; > > ret = __mdiobus_write(mdio->bus, mdio->addr, AIR_PBUS_DATA_HIGH, > (u16)(pbus_data >> 16)); > if (ret < 0) > return ret; > > return 0; > } > > static int air_pbus_reg_write(struct mdio_device *mdio, u32 pbus_address, > u32 pbus_data) > { > int ret; > > mutex_lock(&mdio->bus->mdio_lock); > > ret = __air_pbus_reg_write(mdio, pbus_address, pbus_data); > if (ret < 0) > dev_err(&mdio->dev, "%s 0x%08x failed: %d\n", __func__, > pbus_address, ret); > > mutex_unlock(&mdio->bus->mdio_lock); > > return ret; > } > > static int __air_pbus_reg_read(struct mdio_device *mdio, u32 pbus_address, > u32 *pbus_data) > { > int ret, pbus_data_low; > > ret = __mdiobus_write(mdio->bus, mdio->addr, AIR_EXT_PAGE_ACCESS, > (u16)(pbus_address >> 6)); > if (ret < 0) > return ret; > > ret = __mdiobus_read(mdio->bus, mdio->addr, (pbus_address >> 2) & 0xf); > if (ret < 0) > return ret; > pbus_data_low = ret; > > ret = __mdiobus_read(mdio->bus, mdio->addr, AIR_PBUS_DATA_HIGH); > if (ret < 0) > return ret; > > *pbus_data = (ret << 16) + pbus_data_low; > > return 0; > } > > static int air_pbus_reg_read(struct mdio_device *mdio, u32 pbus_address, > u32 *pbus_data) > { > int ret; > > mutex_lock(&mdio->bus->mdio_lock); > > ret = __air_pbus_reg_read(mdio, pbus_address, pbus_data); > if (ret < 0) > dev_err(&mdio->dev, "%s 0x%08x failed: %d\n", __func__, > pbus_address, ret); > > mutex_unlock(&mdio->bus->mdio_lock); > > return ret; > } > > With: > > #define AIR_PBUS_DATA_HIGH 0x10 Small correction using upper_16_bits() and lower_16_bits(): static int __air_pbus_reg_write(struct mdio_device *mdio, u32 pbus_address, u32 pbus_data) { int ret; ret = __mdiobus_write(mdio->bus, mdio->addr, AIR_EXT_PAGE_ACCESS, (u16)(pbus_address >> 6)); if (ret < 0) return ret; ret = __mdiobus_write(mdio->bus, mdio->addr, (pbus_address >> 2) & 0xf, lower_16_bits(pbus_data)); if (ret < 0) return ret; ret = __mdiobus_write(mdio->bus, mdio->addr, AIR_PBUS_DATA_HIGH, upper_16_bits(pbus_data)); if (ret < 0) return ret; return 0; } static int air_pbus_reg_write(struct mdio_device *mdio, u32 pbus_address, u32 pbus_data) { int ret; mutex_lock(&mdio->bus->mdio_lock); ret = __air_pbus_reg_write(mdio, pbus_address, pbus_data); if (ret < 0) dev_err(&mdio->dev, "%s 0x%08x failed: %d\n", __func__, pbus_address, ret); mutex_unlock(&mdio->bus->mdio_lock); return ret; }