From: Yonghong Song <yhs@meta.com>
To: David Vernet <void@manifault.com>, bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
tj@kernel.org
Subject: Re: [PATCH bpf-next 3/5] bpf: Replace bpf_cpumask_any* with bpf_cpumask_any_distribute*
Date: Mon, 12 Jun 2023 08:22:01 -0700 [thread overview]
Message-ID: <6f4402cd-3f05-373c-93c3-581491fd5116@meta.com> (raw)
In-Reply-To: <20230610035053.117605-3-void@manifault.com>
On 6/9/23 8:50 PM, David Vernet wrote:
> We currently export the bpf_cpumask_any() and bpf_cpumask_any_and()
> kfuncs. Intuitively, one would expect these to choose any CPU in the
> cpumask, but what they actually do is alias to cpumask_first() and
> cpmkas_first_and().
>
> This is useless given that we already export bpf_cpumask_first() and
> bpf_cpumask_first_and(), so this patch replaces them with kfuncs that
> call cpumask_any_distribute() and cpumask_any_and_distribute(), which
> actually choose any CPU from the cpumask (or the AND of two cpumasks for
> the latter).
>
> Signed-off-by: David Vernet <void@manifault.com>
Acked-by: Yonghong Song <yhs@fb.com>
next prev parent reply other threads:[~2023-06-12 15:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 3:50 [PATCH bpf-next 1/5] bpf: Add bpf_cpumask_first_and() kfunc David Vernet
2023-06-10 3:50 ` [PATCH bpf-next 2/5] selftests/bpf: Add test for new " David Vernet
2023-06-12 15:20 ` Yonghong Song
2023-06-10 3:50 ` [PATCH bpf-next 3/5] bpf: Replace bpf_cpumask_any* with bpf_cpumask_any_distribute* David Vernet
2023-06-12 15:22 ` Yonghong Song [this message]
2023-06-10 3:50 ` [PATCH bpf-next 4/5] selftests/bpf: Update bpf_cpumask_any* tests to use bpf_cpumask_any_distribute* David Vernet
2023-06-12 15:22 ` Yonghong Song
2023-06-10 3:50 ` [PATCH bpf-next 5/5] bpf/docs: Update documentation for new cpumask kfuncs David Vernet
2023-06-12 15:23 ` Yonghong Song
2023-06-12 15:19 ` [PATCH bpf-next 1/5] bpf: Add bpf_cpumask_first_and() kfunc Yonghong Song
2023-06-12 22:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f4402cd-3f05-373c-93c3-581491fd5116@meta.com \
--to=yhs@meta.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®