From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22CA1221739 for ; Fri, 19 Sep 2025 12:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758286275; cv=none; b=B8m7M4jTMCftGz0Dal8Vi64FZqWektBJA30+xDC3HSShq/X5OcErRBC7ItrDL0LeQ7Xd2Dplix774KvXSHI8RTTzVvGmRe8y6kD09JAfZqZwPU+geP+VAW6COmC4fo+gq3Hx6HWone2Oe8el/cV9w7jnSiXix8q53TwbiXZAQfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758286275; c=relaxed/simple; bh=JdODiL5FM14Ag8mnxpLjf19nf6aY99jgQO8dU6zFAtY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=bqQOibrorPORZQlRTLyeBGEQFdwIlak2vf7TW1PeArdYh0pMR4vKfoNSXaJm8Kdy8g/dC7Bk1Gt0x/ffTD5AHgLABa+24OJadkV/ZYyDWZj34dfis8fQ2pdLmQzpytiCXvvowCNp0ZExkU4ilhMapfO6hvOs9/5YDeFUyhqXtOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=gyUrPvrN; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="gyUrPvrN" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id B7ED2C007B9; Fri, 19 Sep 2025 12:50:54 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 6BB22606A8; Fri, 19 Sep 2025 12:51:11 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E2EEB102F177A; Fri, 19 Sep 2025 14:51:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1758286268; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references:autocrypt; bh=QVKigQyMTAamR3deX4aA1EPmSgjjkF2p4VHZRs9pNNw=; b=gyUrPvrNtWJa0beEj8V3yClCXcP7z1GY8RqWg0Ly3iZNl3hFHOlpvo/TGYRBhUjNyS74FK NvNU3Bw4OgCWesdzfljlVtCQ4Ch97KIeh1kaK6pat2z2huk/MDe98L0h+KsUYqtvDkmuQl 9fhao3MvFCd3cUosdrKpDvErSgbbTLmQbegqZ3bP+VxT81zO5oohW/ZkavT4wU+uACjFL4 Flpb4vCQ4Ol0bXTHkxqcKSCiWsUXo7RikFojfEDIQpC91Loq6rOF4eEsxPG9OvnDTk+XC8 LtCfKD36tjNrEiCPrm3kcm90RsfU4AB5gp/pLZlUEruleZbUKBSek6TSLhxJ/A== Message-ID: <6f464154-8de3-4d7b-8d5c-30150b0d1aec@bootlin.com> Date: Fri, 19 Sep 2025 14:51:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Louis Chauvet Subject: Re: [PATCH RFC v2 09/20] drm/colorop: Factor out common paths from colorops helpers To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Haneen Mohammed , Melissa Wen Cc: Alex Hung , wayland-devel@lists.freedesktop.org, harry.wentland@amd.com, leo.liu@amd.com, ville.syrjala@linux.intel.com, pekka.paalanen@collabora.com, contact@emersion.fr, mwen@igalia.com, jadahl@redhat.com, sebastian.wick@redhat.com, shashank.sharma@amd.com, agoins@nvidia.com, joshua@froggi.es, mdaenzer@redhat.com, aleixpol@kde.org, xaver.hugl@gmail.com, victoria@system76.com, uma.shankar@intel.com, quic_naseer@quicinc.com, quic_cbraga@quicinc.com, quic_abhinavk@quicinc.com, marcan@marcan.st, Liviu.Dudau@arm.com, sashamcintosh@google.com, chaitanya.kumar.borah@intel.com, mcanal@igalia.com, kernel@collabora.com, daniels@collabora.com, leandro.ribeiro@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Simona Vetter References: <20250917-mtk-post-blend-color-pipeline-v2-0-ac4471b44758@collabora.com> <20250917-mtk-post-blend-color-pipeline-v2-9-ac4471b44758@collabora.com> Content-Language: en-US, fr Autocrypt: addr=louis.chauvet@bootlin.com; keydata= xsFNBGCG5KEBEAD1yQ5C7eS4rxD0Wj7JRYZ07UhWTbBpbSjHjYJQWx/qupQdzzxe6sdrxYSY 5K81kIWbtQX91pD/wH5UapRF4kwMXTAqof8+m3XfYcEDVG31Kf8QkJTG/gLBi1UfJgGBahbY hjP40kuUR/mr7M7bKoBP9Uh0uaEM+DuKl6bSXMSrJ6fOtEPOtnfBY0xVPmqIKfLFEkjh800v jD1fdwWKtAIXf+cQtC9QWvcdzAmQIwmyFBmbg+ccqao1OIXTgu+qMAHfgKDjYctESvo+Szmb DFBZudPbyTAlf2mVKpoHKMGy3ndPZ19RboKUP0wjrF+Snif6zRFisHK7D/mqpgUftoV4HjEH bQO9bTJZXIoPJMSb+Lyds0m83/LYfjcWP8w889bNyD4Lzzzu+hWIu/OObJeGEQqY01etOLMh deuSuCG9tFr0DY6l37d4VK4dqq4Snmm87IRCb3AHAEMJ5SsO8WmRYF8ReLIk0tJJPrALv8DD lnLnwadBJ9H8djZMj24+GC6MJjN8dDNWctpBXgGZKuCM7Ggaex+RLHP/+14Vl+lSLdFiUb3U ljBXuc9v5/9+D8fWlH03q+NCa1dVgUtsP2lpolOV3EE85q1HdMyt5K91oB0hLNFdTFYwn1bW WJ2FaRhiC1yV4kn/z8g7fAp57VyIb6lQfS1Wwuj5/53XYjdipQARAQABzSlMb3VpcyBDaGF1 dmV0IDxsb3Vpcy5jaGF1dmV0QGJvb3RsaW4uY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI CwIEFgIDAQIeAQIXgBYhBItxBK6aJy1mk/Un8uwYg/VeC0ClBQJod7hIBQkJ0gcjAAoJEOwY g/VeC0ClghwP/RQeixyghRVZEQtZO5/UsHkNkRRUWeVF9EoFXqFFnWqh4XXKos242btk5+Ew +OThuqDx9iLhLJLUc8XXuVw6rbJEP5j5+z0jI40e7Y+kVWCli/O2H/CrK98mGWwicBPEzrDD 4EfRgD0MeQ9fo2XJ3Iv+XiiZaBFQIKMAEynYdbqECIXxuzAnofhq2PcCrjZmqThwu8jHSc55 KwdknZU3aEKSrTYiCIRrsHHi1N6vwiTZ098zL1efw7u0Q8rcqxHu3OWNIAeKHkozsMy9yo1h h3Yc7CA1PrKDGcywuY4MrV726/0VlrWcypYOCM1XG+/4ezIChYizpAiBNlAmd7witTK0d2HT UNSZF8KAOQRlHsIPrkA5qLr94OrFHYx6Ek07zS8LmVTtHricbYxFAXnQ5WbugNSE0uwRyrL/ Kies5F0Sst2PcVYguoWcHfoNxes6OeU3xDmzclnpYQTanIU7SBzWXB1fr5WgHF7SAcAVxPY8 wAlJBe+zMeA6oWidrd1u37eaEhHfpKX38J1VaSDTNRE+4SPQ+hKGDuMrDn0mXfcqR5wO7n1Z Q6uhKj3k6SJNksAWh1u13NP0DRS6rpRllvGWIyp+653R03NN8TE9JNRWAtSqoGvsiryhQyCE FlPOsv6+Ed/5a4dfLcO1qScJwiuP/XjFHAaWFK9RoOX52lR4zsFNBGCG6KUBEADZhvm9TZ25 JZa7wbKMOpvSH36K8wl74FhuVuv7ykeFPKH2oC7zmP1oqs1IF1UXQQzNkCHsBpIZq+TSE74a mG4sEhZP0irrG/w3JQ9Vbxds7PzlQzDarJ1WJvS2KZ4AVnwc/ucirNuxinAuAmmNBUNF8w6o Y97sdgFuIZUP6h972Tby5bu7wmy1hWL3+2QV+LEKmRpr0D9jDtJrKfm25sLwoHIojdQtGv2g JbQ9Oh9+k3QG9Kh6tiQoOrzgJ9pNjamYsnti9M2XHhlX489eXq/E6bWOBRa0UmD0tuQKNgK1 n8EDmFPW3L0vEnytAl4QyZEzPhO30GEcgtNkaJVQwiXtn4FMw4R5ncqXVvzR7rnEuXwyO9RF tjqhwxsfRlORo6vMKqvDxFfgIkVnlc2KBa563qDNARB6caG6kRaLVcy0pGVlCiHLjl6ygP+G GCNfoh/PADQz7gaobN2WZzXbsVS5LDb9w/TqskSRhkgXpxt6k2rqNgdfeyomlkQnruvkIIjs Sk2X68nwHJlCjze3IgSngS2Gc0NC/DDoUBMblP6a2LJwuF/nvaW+QzPquy5KjKUO2UqIO9y+ movZqE777uayqmMeIy4cd/gg/yTBBcGvWVm0Dh7dE6G6WXJUhWIUtXCzxKMmkvSmZy+gt1rN OyCd65HgUXPBf+hioCzGVFSoqQARAQABwsOyBBgBCAAmAhsuFiEEi3EErponLWaT9Sfy7BiD 9V4LQKUFAmh3uH8FCQnSA1kCQMF0IAQZAQgAHRYhBE+PuD++eDwxDFBZBCCtLsZbECziBQJg huilAAoJECCtLsZbECziB8YQAJwDRdU16xtUjK+zlImknL7pyysfjLLbfegZyVfY/ulwKWzn nCJXrLAK1FpdYWPO1iaSVCJ5pn/Or6lS5QO0Fmj3mtQ/bQTnqBhXZcUHXxZh56RPAfl3Z3+P 77rSIcTFZMH6yAwS/cIQaKRQGPuJoxfYq1oHWT0r7crp3H+zUpbE4KUWRskRX+2Z6rtNrwuL K1Az1vjJjnnS3MLSkQR4VwsVejWbkpwlq5icCquU5Vjjw0WkVR32gBl/8/OnegSz7Of/zMrY 8GtlkIPoCGtui1HLuKsTl6KaHFywWbX4wbm5+dpBRYetFhdW4WG+RKipnyMY+A8SkWivg2NH Jf88wuCVDtLmyeS8pyvcu6fjhrJtcQer/UVPNbaQ6HqQUcUU49sy/W+gkowjOuYOgNL7EA23 8trs7CkLKUKAXq32gcdNMZ8B/C19hluJ6kLroUN78m39AvCQhd4ih5JLU7jqsl0ZYbaQe2FQ z64htRtpElbwCQmnM/UzPtOJ5H/2M7hg95Sb20YvmQ/bLI23MWKVyg56jHU1IU0A/P7M9yi9 WbEBpIMZxLOFBUlWWTzE+JvyDh+cjyoncaPvHLDwP13PGEJHYMgWZkvzgSc3tGP6ThUgZjsz 9xW/EvzWOVswYwREyZv3oK5r3PVE6+IYDUd7aBsc5ynqqYs27eemuV4bw8tlCRDsGIP1XgtA pT1zD/0dT+clFbGoCMaIQ5qXypYoO0DYLmBD1aFjJy1YLsS1SCzuwROy4qWWaFMNBoDMF2cY D+XbM+C/4XBS8/wruAUrr+8RSbABBI/rfiVmqv0gPQWDm676V8iMDgyyvMG2DotMjnG/Dfxj w9WVnQUs/kQSPD8GZCZZ3AcycFmxN24ibGHo4zC947VKR5ZYdFHknX+Dt92TdNDkmoBg2CEm 9S2Skki9Pwyvb/21zCYq/o4pRMfKmQgpF2LT2m51rdtmNg9oj9F4+BJUmkgyNxMyGEA1V1jM xQaVX4mRY61O4CimPByUDp2EH2VaEr2rEwvHszaWqFJdSQE8hdSDc4cqhik7rznNBjwgZAzq cefLctAVnKjasfKEWp0VhgkIVB8/Sos4S8YaG4qbeGviSfIQJ2GO1Vd9WQ2n1XGth3cY2Qwk dIo13GCFJF7b6y0J13bm+siRpPZQ3aOda7pn07GXqREjFsfq5gF04/9am5x/haehPse2yzcP wDN7ORknPndzxrq3CyB7b/Tk1e8Qx+6HU/pnMb4ZqwwMwZAMk24TZpsgg28o9MQiUNzad0h2 gIszbeej9ryrtLHxMzyK8yKhHoI2i2ovxy5O+hsWeAoCPE9xwbqnAjLjOn4Jzd/pPovizrq/ kUoX66YgvCuHfQMC/aBPLnVunZSP23J2CrkTrnsUzw== In-Reply-To: <20250917-mtk-post-blend-color-pipeline-v2-9-ac4471b44758@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Le 18/09/2025 à 02:43, Nícolas F. R. A. Prado a écrit : > Factor out the common code paths from the colorop helpers so they can be > reused by the post-blend colorop helpers. > > Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Louis Chauvet > --- > drivers/gpu/drm/drm_colorop.c | 145 ++++++++++++++++++++++++++++-------------- > 1 file changed, 99 insertions(+), 46 deletions(-) > > diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c > index 1384a259605fa4945aa74402901886d7e1fde0d1..db137169effa6cd9e6d5805f65bdfd1cc6882075 100644 > --- a/drivers/gpu/drm/drm_colorop.c > +++ b/drivers/gpu/drm/drm_colorop.c > @@ -91,8 +91,9 @@ static const struct drm_prop_enum_list drm_colorop_lut3d_interpolation_list[] = > > /* Init Helpers */ > > -static int drm_plane_colorop_init(struct drm_device *dev, struct drm_colorop *colorop, > - struct drm_plane *plane, enum drm_colorop_type type, uint32_t flags) > +static int drm_common_colorop_init(struct drm_device *dev, > + struct drm_colorop *colorop, > + enum drm_colorop_type type, uint32_t flags) > { > struct drm_mode_config *config = &dev->mode_config; > struct drm_property *prop; > @@ -105,7 +106,6 @@ static int drm_plane_colorop_init(struct drm_device *dev, struct drm_colorop *co > colorop->base.properties = &colorop->properties; > colorop->dev = dev; > colorop->type = type; > - colorop->plane = plane; > colorop->next = NULL; > > list_add_tail(&colorop->head, &config->colorop_list); > @@ -154,6 +154,20 @@ static int drm_plane_colorop_init(struct drm_device *dev, struct drm_colorop *co > return ret; > } > > +static int drm_plane_colorop_init(struct drm_device *dev, > + struct drm_colorop *colorop, > + struct drm_plane *plane, > + enum drm_colorop_type type, uint32_t flags) > +{ > + int ret; > + > + ret = drm_common_colorop_init(dev, colorop, type, flags); > + > + colorop->plane = plane; > + > + return ret; > +} > + > /** > * drm_colorop_cleanup - Cleanup a drm_colorop object in color_pipeline > * > @@ -206,31 +220,13 @@ EXPORT_SYMBOL(drm_colorop_pipeline_destroy); > * @flags: bitmask of misc, see DRM_COLOROP_FLAG_* defines. > * @return zero on success, -E value on failure > */ > -int drm_plane_colorop_curve_1d_init(struct drm_device *dev, struct drm_colorop *colorop, > - struct drm_plane *plane, u64 supported_tfs, uint32_t flags) > +static int drm_common_colorop_curve_1d_init(struct drm_device *dev, struct drm_colorop *colorop, > + u64 supported_tfs, uint32_t flags) > { > struct drm_prop_enum_list enum_list[DRM_COLOROP_1D_CURVE_COUNT]; > int i, len; > > struct drm_property *prop; > - int ret; > - > - if (!supported_tfs) { > - drm_err(dev, > - "No supported TFs for new 1D curve colorop on [PLANE:%d:%s]\n", > - plane->base.id, plane->name); > - return -EINVAL; > - } > - > - if ((supported_tfs & -BIT(DRM_COLOROP_1D_CURVE_COUNT)) != 0) { > - drm_err(dev, "Unknown TF provided on [PLANE:%d:%s]\n", > - plane->base.id, plane->name); > - return -EINVAL; > - } > - > - ret = drm_plane_colorop_init(dev, colorop, plane, DRM_COLOROP_1D_CURVE, flags); > - if (ret) > - return ret; > > len = 0; > for (i = 0; i < DRM_COLOROP_1D_CURVE_COUNT; i++) { > @@ -260,6 +256,41 @@ int drm_plane_colorop_curve_1d_init(struct drm_device *dev, struct drm_colorop * > > return 0; > } > + > +static int drm_colorop_has_supported_tf(struct drm_device *dev, struct drm_mode_object *obj, > + const char *name, u64 supported_tfs) > +{ > + if (!supported_tfs) { > + drm_err(dev, > + "No supported TFs for new 1D curve colorop on [PLANE:%d:%s]\n", > + obj->id, name); > + return -EINVAL; > + } > + > + if ((supported_tfs & -BIT(DRM_COLOROP_1D_CURVE_COUNT)) != 0) { > + drm_err(dev, "Unknown TF provided on [PLANE:%d:%s]\n", > + obj->id, name); > + return -EINVAL; > + } > + > + return 0; > +} > + > +int drm_plane_colorop_curve_1d_init(struct drm_device *dev, struct drm_colorop *colorop, > + struct drm_plane *plane, u64 supported_tfs, uint32_t flags) > +{ > + int ret; > + > + ret = drm_colorop_has_supported_tf(dev, &plane->base, plane->name, supported_tfs); > + if (ret) > + return ret; > + > + ret = drm_plane_colorop_init(dev, colorop, plane, DRM_COLOROP_1D_CURVE, flags); > + if (ret) > + return ret; > + > + return drm_common_colorop_curve_1d_init(dev, colorop, supported_tfs, flags); > +} > EXPORT_SYMBOL(drm_plane_colorop_curve_1d_init); > > static int drm_colorop_create_data_prop(struct drm_device *dev, struct drm_colorop *colorop) > @@ -280,29 +311,16 @@ static int drm_colorop_create_data_prop(struct drm_device *dev, struct drm_color > return 0; > } > > -/** > - * drm_plane_colorop_curve_1d_lut_init - Initialize a DRM_COLOROP_1D_LUT > - * > - * @dev: DRM device > - * @colorop: The drm_colorop object to initialize > - * @plane: The associated drm_plane > - * @lut_size: LUT size supported by driver > - * @lut1d_interpolation: 1D LUT interpolation type > - * @flags: bitmask of misc, see DRM_COLOROP_FLAG_* defines. > - * @return zero on success, -E value on failure > - */ > -int drm_plane_colorop_curve_1d_lut_init(struct drm_device *dev, struct drm_colorop *colorop, > - struct drm_plane *plane, uint32_t lut_size, > - enum drm_colorop_lut1d_interpolation_type lut1d_interpolation, > - uint32_t flags) > +static int > +drm_common_colorop_curve_1d_lut_init(struct drm_device *dev, > + struct drm_colorop *colorop, > + uint32_t lut_size, > + enum drm_colorop_lut1d_interpolation_type lut1d_interpolation, > + uint32_t flags) > { > struct drm_property *prop; > int ret; > > - ret = drm_plane_colorop_init(dev, colorop, plane, DRM_COLOROP_1D_LUT, flags); > - if (ret) > - return ret; > - > /* initialize 1D LUT only attribute */ > /* LUT size */ > prop = drm_property_create_range(dev, DRM_MODE_PROP_IMMUTABLE | DRM_MODE_PROP_ATOMIC, > @@ -334,17 +352,40 @@ int drm_plane_colorop_curve_1d_lut_init(struct drm_device *dev, struct drm_color > > return 0; > } > -EXPORT_SYMBOL(drm_plane_colorop_curve_1d_lut_init); > > -int drm_plane_colorop_ctm_3x4_init(struct drm_device *dev, struct drm_colorop *colorop, > - struct drm_plane *plane, uint32_t flags) > +/** > + * drm_plane_colorop_curve_1d_lut_init - Initialize a DRM_COLOROP_1D_LUT > + * > + * @dev: DRM device > + * @colorop: The drm_colorop object to initialize > + * @plane: The associated drm_plane > + * @lut_size: LUT size supported by driver > + * @lut1d_interpolation: 1D LUT interpolation type > + * @flags: bitmask of misc, see DRM_COLOROP_FLAG_* defines. > + * @return zero on success, -E value on failure > + */ > +int > +drm_plane_colorop_curve_1d_lut_init(struct drm_device *dev, struct drm_colorop *colorop, > + struct drm_plane *plane, uint32_t lut_size, > + enum drm_colorop_lut1d_interpolation_type lut1d_interpolation, > + uint32_t flags) > { > int ret; > > - ret = drm_plane_colorop_init(dev, colorop, plane, DRM_COLOROP_CTM_3X4, flags); > + ret = drm_plane_colorop_init(dev, colorop, plane, DRM_COLOROP_1D_LUT, flags); > if (ret) > return ret; > > + return drm_common_colorop_curve_1d_lut_init(dev, colorop, lut_size, > + lut1d_interpolation, flags); > +} > +EXPORT_SYMBOL(drm_plane_colorop_curve_1d_lut_init); > + > +static int drm_common_colorop_ctm_3x4_init(struct drm_device *dev, struct drm_colorop *colorop, > + uint32_t flags) > +{ > + int ret; > + > ret = drm_colorop_create_data_prop(dev, colorop); > if (ret) > return ret; > @@ -353,6 +394,18 @@ int drm_plane_colorop_ctm_3x4_init(struct drm_device *dev, struct drm_colorop *c > > return 0; > } > + > +int drm_plane_colorop_ctm_3x4_init(struct drm_device *dev, struct drm_colorop *colorop, > + struct drm_plane *plane, uint32_t flags) > +{ > + int ret; > + > + ret = drm_plane_colorop_init(dev, colorop, plane, DRM_COLOROP_CTM_3X4, flags); > + if (ret) > + return ret; > + > + return drm_common_colorop_ctm_3x4_init(dev, colorop, flags); > +} > EXPORT_SYMBOL(drm_plane_colorop_ctm_3x4_init); > > /** > -- -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com