From: Krzysztof Kozlowski <krzk@kernel.org>
To: Aleksander Jan Bajkowski <olek2@wp.pl>,
jdelvare@suse.com, linux@roeck-us.net, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, fe@dev.tdt.de,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: convert lantiq-cputemp to yaml
Date: Wed, 13 Aug 2025 11:24:50 +0200 [thread overview]
Message-ID: <6f46e420-832a-4c6e-b1e9-d797b0425834@kernel.org> (raw)
In-Reply-To: <20250813091924.1075488-1-olek2@wp.pl>
On 13/08/2025 11:19, Aleksander Jan Bajkowski wrote:
> +---
> +$id: http://devicetree.org/schemas/hwmon/lantiq,cputemp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lantiq cpu temperature sensor
> +
> +maintainers:
> + - Florian Eckert <fe@dev.tdt.de>
> +
> +properties:
> + compatible:
> + const: lantiq,cputemp
> +
> +required:
> + - compatible
> +
I think this reads and writs to some IOMEM space, so you really need
here 'reg'. That's the problem with such old bindings... binding is
broken, DTS is half-baked or non-existing, driver has 20 years.
BTW, why converting this old binding? Do you have any interest in
actually running MIPS?
I assume you did not check Rob's dt-convert branch to avoid
duplicated... because he did convert EXACTLY this binding. And more from
Lantiq.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-13 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 9:19 Aleksander Jan Bajkowski
2025-08-13 9:24 ` Krzysztof Kozlowski [this message]
2025-08-13 9:52 ` Aleksander Jan Bajkowski
2025-08-13 16:17 ` Krzysztof Kozlowski
[not found] ` <ea558f80-959c-477c-9ca5-5c9635b03e56@wp.pl>
2025-08-14 6:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f46e420-832a-4c6e-b1e9-d797b0425834@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fe@dev.tdt.de \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=olek2@wp.pl \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®