From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C34962BD587 for ; Tue, 9 Jun 2026 13:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781011596; cv=none; b=jM0q2pAkgkpiC2tWXn0jPsw7+RYabMltmcv/SQKCJKY0qoX1YagyGo87ISMupMoTpDMedmDYOpGul+1ij0meY7s+uHCFy6ncWrkdMh9VT4hZjdzFsiD6AOdlNUk+vGq85bBq3DrdAVMzq/UT+iPzTCiCoSbIhYJRv/XnS9kiUu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781011596; c=relaxed/simple; bh=ZaS16NqBLf85S7mXyE0T5MBWE7dC4iKHxYJUfo8lKo0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=osIAnwX0e5sK4vGOlvOETWAxM6yxBDYAI7pCfv01xG5JxBfY8BGY6MCF4wqmrW6/VpKYg/QFdjOfz4y1LnCTrYmVt7iIqnuZUx+iZDWvYyOS7sSBoGwqNW22SpiwVzA288MnZ8WH1P6Bj3FdXjBFkgmLzT2inRwticma3aseC9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bP2rw/br; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G6Yx1JzQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bP2rw/br"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G6Yx1JzQ" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659CmLxq2588047 for ; Tue, 9 Jun 2026 13:26:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fodeJ2QdboYj6AqCWNyQFWBP9D5W0x7wQGzJ+z4Dj0o=; b=bP2rw/brlwC6MpAn KOQE7tAJ46wWd0GziVu5Wf5bKNomDFDz0NLcdZoeXMhIOE6nLgHWt9DCZOuKGtIr Zn3cS7/axWao3HZr1p66Y9F8c3vOFy/qGcvjQCXOYDcok/t33Ba68KsiUoGySuke xoORlx/7W2K0VN+SESdQ0hqsZ6gnNDnX1H2dmirSwqLGNPkNjHoO7LyTrDNNODDj Ql5V6SX429vtyCt6aOHmf3i5az2ZLcMb6Q7evbNjigrxoIUXeXFufasWgKCi+vVg pOsiwFX+lIeZOyPgpUeuPrB4D8B3YhZJKvyF3YSGPizwVYOxUrHJgq6yI4DxoWpp s7Fzvg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epee4hgr8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 13:26:33 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-36d979441eeso4806548a91.0 for ; Tue, 09 Jun 2026 06:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781011593; x=1781616393; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fodeJ2QdboYj6AqCWNyQFWBP9D5W0x7wQGzJ+z4Dj0o=; b=G6Yx1JzQREtAXFJbh92UrDeu57GyB/UIp+EEIpCwEt3g1IoIug20wqRBsz7eYM3FSR +zn3OhtRKNv6HWvWx47QwXJgq4x4guk4ADLMCtuj9ZMGskFH8GthHEHEnfzXoOspqsEL /DaGkkFel0Xl245/qUSZH7zpjQs6Ybmt9MOGMDF9FJXAoAuGVSv3hbO/zqTee+/pt/7l ximkgWTo9vOt7wtVNeUdJ9FkcC4bsO6z2c1GHy1sSywTLAJKSXRXVGTp2ByYf8gijbKD /ZJwl6KcrPXxpYtzSq9MEU2bppX0ZUfGyXavFHmJDeM/Ib8KgLZQgiSih2vhtINgXX5N 5fJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781011593; x=1781616393; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fodeJ2QdboYj6AqCWNyQFWBP9D5W0x7wQGzJ+z4Dj0o=; b=dKjeh54J9DjhTnoY2C4e178YeCrdCJXbZBScRQeL9Z22uveB+WfaLUB/aofAdxsTwX fLJkihn9U3XCohZDdxqwn4/OvmLuxl9ZSRB7Pjh8H/SC4GjXzJ+pyNDlRCmr1ytG2c2K 8Kj32Vqg8zcelcb6yACGk1TzbBX6P+je3Leyxd3qOocTxLIe8jmGITSxtaVZ8eylcm3E rGFTpiA4Gz2AiyPZj+Aya0nbkM2mPJpU4vce2Yp3IgvWhh9CF4G8xXqT/fj1+VfBaouQ wF4bQT8pWMaEZOSoHn0aM4vaAKBbraFKTjDHzw2T9KHd8/As+a0Mh+GEvbZPmi3vqWIx k3eg== X-Forwarded-Encrypted: i=1; AFNElJ8SW7ZGxARozqBkRIpPMBUHWzFA0xx+BsioNsIQqkqCxn+JVUAFZSDHu6zyRGhkWgbxxk2M3AfTcx2UbYw=@vger.kernel.org X-Gm-Message-State: AOJu0YzIWIr7qlIoVU87XNaqFZGh5xh7RUUtjfIrC1tf9PlV3nSxqcPB qZhds/uJunjMPiJucK2IKTO3Dir/GtpPgK3cORxjBAi7g7uJJ3UTnx7ljPr+5G+/T63TsdzOiA8 csncFvD+yqe2eUo+rYeJ6hV2pFRrks6XjVil4xwUxJ+XcllAXG53dK9cTcFJhrARTbxo= X-Gm-Gg: Acq92OEJ576PpS6o9lXVQfxqg4XyEb4VT5dPg1fY+tQpRplulM+hFQG3WVTxKarelDK ISF/rFSKBmTNYp8MD87Ku09vcc8wFtqzO6g1WFCF5PoXjFiKDsvGBvGjulN6CDnaLbr96dlznbk m4soVYWmCFwrSIcGFVZrGkNs4mUGtLNymKdN0qbTyqgjUbSb+hnSubPr7jlofoEzWW9qBa6J9ez r9TZ1gwKFxZ84zSUSpsv4wSs3pa6lOOonl6bRaoY6+zEFNNiYJevWraJaFWP5yiDqNRlvgKyVQb EKHuHgS0Hu1vTprBuTojgH08pgpVwZbKhO7MkJJj7220J9n2AQH/TjkGkaG3nsdZzC99Pqp0F8L 0NSYg6rpvHS2oeN/S/fSLgPzYsh3jzlYo70xKYcc1211jpvzJTDeP06qnZYedppmNXrY= X-Received: by 2002:a17:90b:6c3:b0:36d:6308:12fa with SMTP id 98e67ed59e1d1-370f0386f18mr22250710a91.18.1781011592613; Tue, 09 Jun 2026 06:26:32 -0700 (PDT) X-Received: by 2002:a17:90b:6c3:b0:36d:6308:12fa with SMTP id 98e67ed59e1d1-370f0386f18mr22250649a91.18.1781011591914; Tue, 09 Jun 2026 06:26:31 -0700 (PDT) Received: from [10.92.193.107] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f68bf99dcsm19245474a91.0.2026.06.09.06.26.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 06:26:31 -0700 (PDT) Message-ID: <6f4da6a1-c456-4b3b-87c3-d1db592ad5ad@oss.qualcomm.com> Date: Tue, 9 Jun 2026 18:56:26 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] powercap: qcom: Add SPEL powercap driver To: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J. Wysocki" , Bjorn Andersson , Konrad Dybcio , Daniel Lezcano Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Gaurav Kohli References: <20260519-qcom_spel_driver_upstream-v1-0-75356d1b7f94@oss.qualcomm.com> <20260519-qcom_spel_driver_upstream-v1-2-75356d1b7f94@oss.qualcomm.com> <69ad1327-8ef2-41c3-b07f-61d00e862904@oss.qualcomm.com> Content-Language: en-US From: Manaf Meethalavalappu Pallikunhi In-Reply-To: <69ad1327-8ef2-41c3-b07f-61d00e862904@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=PIs/P/qC c=1 sm=1 tr=0 ts=6a281489 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=H6GCtRmxFJq2rLhnTBcA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: dZDgGztwl7cDW5vmli3tWy1i0_0l0lU4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDEyNyBTYWx0ZWRfX1FDTLC7sbeb7 RDuc9hFjyifEiDlfCQ3nJkTJBtAKHiOF7cY27FkOG0raQtGF+V+XW4r3XkKZL1ljp9Y5+cd/dNs tFrM7Mk7MTigKw8nayHNuP6dUW6mx0N9dDwnEx5HMLFP06/Bv4gUMA3nqILT4pm1m1gidXOMA9J fBEBG6QjCoJY0Dh/zR/O6gcfmjdp5fW294JUkLye5MnXr4GmtWDoC89uUGJi9HXVTv8LcTF8we5 OGlfUs9oMslcXEAaUf/KyfCvokW2QauB2hWpJA5hOrBTXcUkIm5XKknBpjM9HPNxDbA8Y9XE9/2 teiGxPQAYjko0EAHRdpLed8+sh/FbOKY17JuJqdp5Xuodx15VXuazSJOGesY1nZ/8Y5O9Hz+dtb 0FDMItQzzVH4zN6bvFoDtZ2x3kTiEXgA5+OQ4f2qS3K9zXuV8xiv4bImmXPuLwdHOXum93JbUE1 2ppB86FuPEhR4Pa/s6g== X-Proofpoint-ORIG-GUID: dZDgGztwl7cDW5vmli3tWy1i0_0l0lU4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090127 Hi Konrad, On 5/21/2026 4:49 PM, Konrad Dybcio wrote: > On 5/19/26 12:49 PM, Manaf Meethalavalappu Pallikunhi wrote: >> The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware >> based power monitoring and limiting capabilities for various power >> domains including System, SoC, CPU clusters, GPU, and various other >> subsystems. >> >> The driver integrates with the Linux powercap framework, exposing SPEL >> capabilities through powercap sysfs interfaces. >> >> Signed-off-by: Manaf Meethalavalappu Pallikunhi >> --- > > [...] > >> +static const char *const spel_domain_names[] = { >> + "sys", "soc", "cl0", "cl1", "cl2", "igpu", "dgpu", "nsp", >> + "mmcx", "infra", "dram", "mdm", "wlan", "usb1", "usb2", "usb3", >> +}; > > If the domain data is not going to change for future platforms (but > e.g. only the offsets will), which I doubt, please use designated > initializers It can change platform to platform. > > Otherwise, please coalesce the names and offsets in a struct ACK Thanks, Manaf > > Konrad