mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: Nicolai Buchwitz <nb@tipi-net.de>, Simon Horman <horms@kernel.org>
Cc: <netdev@vger.kernel.org>, <justin.chen@broadcom.com>,
	<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<opendmb@gmail.com>, <florian.fainelli@broadcom.com>,
	<bcm-kernel-feedback-list@broadcom.com>,
	<vikas.gupta@broadcom.com>, <rajashekar.hudumula@broadcom.com>,
	<bhargava.marreddy@broadcom.com>, <fmancera@suse.de>,
	<markus@blochl.de>, <arnd@arndb.de>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: bcmgenet: convert RX path to page_pool
Date: Thu, 4 Jun 2026 14:31:43 -0700	[thread overview]
Message-ID: <6f5544f0-a24a-4898-ac7d-004a29b3d204@intel.com> (raw)
In-Reply-To: <2373b19cef00246c737f687685f0ead7@tipi-net.de>

On 6/4/2026 12:39 PM, Nicolai Buchwitz wrote:
> Hi Simon
> 
> On 4.6.2026 19:32, Simon Horman wrote:
>> From: 'Simon Horman' <horms@kernel.org>
>>
>> This is an AI-generated review of your patch. The human sending this
>> email has considered the AI review valid, or at least plausible.
>> Full review at: https://netdev-ai.bots.linux.dev/sashiko/
> 
> Thanks, I will have a look and respond individually per addressed feedback.
> 
> Out of interest, how does this sashiko instance differs from sashiko.dev?
> The later doesn't flag anything in its review [1], so I'm just curious what
> I might can add to my local pre checks.
> 

Your review on sashiko.dev is here:
https://sashiko.dev/#/patchset/20260602094248.4130712-1-nb%40tipi-net.de

And on netdev its at here:

https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260602094248.4130712-1-nb%40tipi-net.de

On sashiko.dev, the review used
gemini/gemini-3.1-pro-preview, but on the netdev instance it used
bedrock/global.anthropic.claude-opus-4-7

So at a minimum it definitely uses different models, but it might also
be using different context files as well, I know the netdev review had
its own context files from when it predated sashiko as a whole, so I
don't know if those are still fed in or differ.

Looking at the raw logs, the system prompts used are slightly different,
so that also likely plays a part in the differing results.

Additionally, repeating runs can sometimes end up with different/new
results because of the nature of LLMs relying on some randomness when
picking next tokens from its weighted outputs. Even using the same model
can give different results if you repeat the run.

> [1] https://sashiko.dev/#/patchset/20260602094248.4130712-1-nb%40tipi-
> net.de
> 
>> [...]
> 
> Regards,
> Nicolai
> 


  reply	other threads:[~2026-06-04 21:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02  9:42 Nicolai Buchwitz
2026-06-04 17:32 ` Simon Horman
2026-06-04 18:54   ` Simon Horman
2026-06-04 19:39   ` Nicolai Buchwitz
2026-06-04 21:31     ` Jacob Keller [this message]
2026-06-04 20:05   ` Nicolai Buchwitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f5544f0-a24a-4898-ac7d-004a29b3d204@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhargava.marreddy@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=fmancera@suse.de \
    --cc=horms@kernel.org \
    --cc=justin.chen@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@blochl.de \
    --cc=nb@tipi-net.de \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=rajashekar.hudumula@broadcom.com \
    --cc=vikas.gupta@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome