mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Andreas Kemnade <andreas@kemnade.info>
Cc: Lee Jones <lee@kernel.org>, Sebastian Reichel <sre@kernel.org>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v3 2/3] power: supply: Add bd718(15/28/78) charger driver
Date: Fri, 29 Aug 2025 15:27:18 +0300	[thread overview]
Message-ID: <6f56b7b6-8b21-4353-bbca-acf7f9b42ceb@gmail.com> (raw)
In-Reply-To: <6341e004-880c-4a81-811d-a8b367aab39d@gmail.com>

On 29/08/2025 09:35, Matti Vaittinen wrote:

>> Some of these look like they should immediately shut down the
>> system, I suppose the battery charger does this autonomously
>> but it should probably also trigger an emergency shutdown
>> of Linux, right?
> 
> Yes. The shutdown for charging, or, in some cases for all power outputs, 
> is automatically handled by the PMIC hardware. (Well, I am not sure 
> about the 'over-current' IRQ, will see if I can find out more about it).

Just to conclude this - I got a confirmation from the ROHM hardware 
engineers that exceeding the set limit and causing the over-current and 
the coulomb counter monitoring interrupts do not change the hardware 
charging state. [CC_MON and OCUR events in the data sheet, if someone 
has that ;) ].

The CC_MON1 will however cause a change in the charging LED state. Eg, 
exceeding this limit will turn off the AMBLED and turn on the GRNLED - 
when the LEDs are controlled by the HW state machine. (I have some very 
faint memory that the LEDs could also be forced ON by software). I 
suppose the reason for this is that the CC_MON1 was designed to be used 
as a "coulomb counter near full capacity" alarm.

Yours,
	-- Matti

  parent reply	other threads:[~2025-08-29 12:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21 18:23 [PATCH v3 0/3] power: supply: add charger for BD71828 Andreas Kemnade
2025-08-21 18:23 ` [PATCH v3 1/3] mfd: bd71828, bd71815 prepare for power-supply support Andreas Kemnade
2025-09-03 12:23   ` Lee Jones
2025-09-03 21:04     ` Andreas Kemnade
2025-09-11  9:47   ` (subset) " Lee Jones
2025-08-21 18:23 ` [PATCH v3 2/3] power: supply: Add bd718(15/28/78) charger driver Andreas Kemnade
2025-08-28  7:45   ` Linus Walleij
2025-08-28 13:01     ` Matti Vaittinen
2025-08-29  6:35     ` Matti Vaittinen
2025-08-29 11:15       ` Andreas Kemnade
2025-08-29 12:27       ` Matti Vaittinen [this message]
2025-09-16 17:39   ` Sebastian Reichel
2025-08-21 18:23 ` [PATCH v3 3/3] MAINTAINERS: Add entry for BD71828 charger Andreas Kemnade
2025-08-22  5:15   ` Matti Vaittinen
2025-08-22  5:17   ` Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f56b7b6-8b21-4353-bbca-acf7f9b42ceb@gmail.com \
    --to=mazziesaccount@gmail.com \
    --cc=andreas@kemnade.info \
    --cc=krzk@kernel.org \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®