From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E713B23392A for ; Fri, 17 Jul 2026 00:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784249564; cv=none; b=gSdkwTogipawifxJmrJzfqamC5Mc/IIAW4JDHJH9kt9NR/R+3fi/02NQFUkckCKUTi9XiCX+hTu4JBDAWxirE1+DzUn+aopq3y1gZosbnlURFd1EC53LKal56lV/PSvVpzgCZSQ8rZJKlRAwiLo+Nt6Y/yE7FvemE/Gl6MlQJAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784249564; c=relaxed/simple; bh=aHQNy5jx6+KvZcmdvYxJNOzec8SkCztlyUo9vKQmNnI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PzqvnwZFtiG/0yq2CuIlOZ4a5ch2CN7Z3GgXTJ3PVFYrfaJZKkHMqq9zgMWuIhwRyaRAW4yjk/ppfpJWlWcHLaAEW93FTSZnscLLj9lU+gGn8D+d9lHu130x2faihuSoSLsLazeBla/dWUDraKPM9V/kZnQZuHPJYvQGTmKgPHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=S55kCl3N; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nS9f4TDe; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S55kCl3N"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nS9f4TDe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784249561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A77kqTT6RG06qU9VfBbjIwsnkZcXnKT3rnXPGJRMQPg=; b=S55kCl3N36Lgu0EJi/BGZz/pzGFdvnZNcHrO9mfgMoVkTo9IUkODkkuwPejleQ1OIEm5Ox OLZ4oJnHolsH0VXk463LeZ5Joz8rN0OHOiXSD0Dgxnj7YYXWNq31Iv7grSgvcJgnyfTUnP 8NjM3CQIlyjzlxgk64qBbeFnkZRfebU= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-z26XjyreM7SyJNxQ-UYycw-1; Thu, 16 Jul 2026 20:52:40 -0400 X-MC-Unique: z26XjyreM7SyJNxQ-UYycw-1 X-Mimecast-MFC-AGG-ID: z26XjyreM7SyJNxQ-UYycw_1784249559 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38dde0df80bso9079238a91.3 for ; Thu, 16 Jul 2026 17:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784249559; x=1784854359; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A77kqTT6RG06qU9VfBbjIwsnkZcXnKT3rnXPGJRMQPg=; b=nS9f4TDePlrs5gcmFAOVa2i42oeeVK5HfA6ehii89hDdnr6F6SMD6QFM/aWLK2VSaC 2gva4K4CKnWj9/KoRdYbnLXcwf5pi2aU4YVIU7bd6VMWwi3uIhul/OUCHJzJOYqN7Nkd Xd8qtF7IsGFsH56gIhsJqVnPV6XKXxO2AZGk3k+nomHLFzdPGxjNMl0pp/AcSdZVBc2H Y6fr1TJGAosBcN5bykFHZonU4X3z7R25HOsWPWlBqR/Ts/Qf+pvi7VvQ/f4ghSGJjNBO 0IIeEQ7wL+2Bqa82+mFpn5YoTG0F3AWXaZrclsBFebiPrBjpwusLdQuGQXWclCbS2dU7 5NJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784249559; x=1784854359; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A77kqTT6RG06qU9VfBbjIwsnkZcXnKT3rnXPGJRMQPg=; b=DLaFnL1m1kafCCIJzKnLFYc4cBAYz1uREifhZ3NIfjhEbGZ52hNV240BvYcRO1vqYX zSwduzfaUxctGZeEKWbvo+9ANbMxBEhqE0tDSdjEgzDma5D1kiftLFizTSrtdPDBTwra MGoMnNpMp853CG6nKg6wjPuadT3OUcJRo070/5+1lcleXZh6GY5Mjs6H6YTMzgsHxut7 SzAkjP/6Si//fkqP5n5bhXjM9vrB1OmR8324YN2p2uy+mA2zCWcWbDFx8wsCsmXiqTRi QAxJAEr2Yldh19ImoU/sqw65jIPPaxmIbcbBRUg9kyuMxYH+4wwATAqJGK2eV2bTal+F I0Qw== X-Forwarded-Encrypted: i=1; AHgh+Rp/z+8xJA/3krqyNWFNvZN/vUGPKh23KxZWi5EgVcvU++EBkCQNSv6/4NfIYRqkym3/KFqGVaFEswKtl2I=@vger.kernel.org X-Gm-Message-State: AOJu0YyjT0+51e42NTPTwNgCRXIabRZBxXZCpTqG/wlm/xMUObcFx8Ss vv+Lp1SAvQzyTBVZacZ2h2fZgFykd4jfLl423OrLtNCYF3MDsC3vgi5dH72dH50sqTrMRaXOod4 5nrH+qXLp4kJTeIAfhyZksPqPBpIwluKs96eVbhpDLOiT3R8Hfi9378lnfrgABFn7wvv+vqBvjA == X-Gm-Gg: AfdE7cmvfvpMaHOGss449HqeJRP9NgDry547bhuKZKLwUQEv6rxFZY1jI+YqY24NbY1 mE/3NdYhRVihtrno2jHI1sF06of0XCZo4LRWYtjYiO4+EiTIg67S+Tsp1M35/kA2BB8+HhpqslS qa5d88ycONY6TuDVXE+RAiHdj1PWzQuTsfzIWoEQ4z1QYgGo1ZXYkSD+5ehl/1a0LEbIcyJlCbd OpmstkCYC3mMSJAgTzL7dUaYyTFWQNvg2XMkYBU/wSMKs01GXMrBgnkFrcvXCyTg3GJidUqenCS /bMGIU1iCjphTR43sA2LK4420Tlp/yvfZeWmR7uVzb0yRZOlNFlK5bER7QUJc80NTqleWOrsjAH HlYf0F2E9BmEFNFrYJ+0wAB0ISLM2tGhpsOXPvIRQuOU= X-Received: by 2002:a17:90b:4fc3:b0:38d:dfd1:7c1 with SMTP id 98e67ed59e1d1-38e4b418a20mr419353a91.2.1784249559024; Thu, 16 Jul 2026 17:52:39 -0700 (PDT) X-Received: by 2002:a17:90b:4fc3:b0:38d:dfd1:7c1 with SMTP id 98e67ed59e1d1-38e4b418a20mr419337a91.2.1784249558530; Thu, 16 Jul 2026 17:52:38 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a20bf96sm637961eec.28.2026.07.16.17.52.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 17:52:37 -0700 (PDT) Message-ID: <6f5ac6c5-1779-496a-ac3d-c5f7a23c55ca@redhat.com> Date: Fri, 17 Jul 2026 10:52:32 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 03/11] arm_mpam: Set mpam_feat_msmon_mbwu_31counter when there are bandwidth counters To: Ben Horgan Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dave.martin@arm.com, andre.przywara@arm.com References: <20260710115546.29644-1-ben.horgan@arm.com> <20260710115546.29644-4-ben.horgan@arm.com> <45d93047-9f11-468a-bee9-777089fd4bb8@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <45d93047-9f11-468a-bee9-777089fd4bb8@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Ben, On 7/16/26 7:26 PM, Ben Horgan wrote: > On 7/16/26 05:18, Gavin Shan wrote: >> On 7/10/26 9:55 PM, Ben Horgan wrote: >>> If there are memory bandwidth counters then there are 31 bit counters even >>> if there are also 44 bit counters or 63 bit counters. >>> >>> Set the 31 bit bandwidth counter feature bit whenever there are bandwidth >>> counters. >>> >>> Fixes: fdc29a141d63 ("arm_mpam: Probe for long/lwd mbwu counters") >>> Signed-off-by: Ben Horgan >>> --- >>>   drivers/resctrl/mpam_devices.c | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >> >> It might be worthwhile to put some context in the commit log helping readers >> to correlate to the specification. What I found is something like below in >> section 8.2.1.2 Long MBWU counter and capture of ARM IHI 0099A.a: >> >> In MSMON_MBWU, the VALUE field is always 31 bits. If MSMON_MBWU_L is implemented, >> the length of the VALUE field is either 63 or 44 bits as set by MPAMF_MBWUMON_IDR.LWD. > > How about? > > When MPAMF_MSMON_IDR.MSMON_MBWU is 1, MSMON_MBWU is present and has a VALUE field of 31 bits. If > additionally, MPAMF_MBWUMON_IDR.HAS_LONG is 1, then MSMON_MBWU_L is also present and has a VALUE > field of 44 or 63 bits as indicated by MPAMF_MBWUMON_IDR.LWD. > Looks good to me, thanks! > Thanks, > > Ben > Thanks, Gavin >> >>> diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c >>> index acfa9a4dc2fc..11b10c3bc334 100644 >>> --- a/drivers/resctrl/mpam_devices.c >>> +++ b/drivers/resctrl/mpam_devices.c >>> @@ -930,9 +930,9 @@ static void mpam_ris_hw_probe(struct mpam_msc_ris *ris) >>>                           mpam_set_feature(mpam_feat_msmon_mbwu_63counter, props); >>>                       else >>>                           mpam_set_feature(mpam_feat_msmon_mbwu_44counter, props); >>> -                } else { >>> -                    mpam_set_feature(mpam_feat_msmon_mbwu_31counter, props); >>>                   } >>> + >>> +                mpam_set_feature(mpam_feat_msmon_mbwu_31counter, props); >>>               } >>>           } >>>       } >> >> Thanks, >> Gavin >> >