From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752580AbdG1QgQ (ORCPT ); Fri, 28 Jul 2017 12:36:16 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:63673 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbdG1QgP (ORCPT ); Fri, 28 Jul 2017 12:36:15 -0400 Subject: Re: [RESEND PATCH] soc: ti: ti_sci_pm_domains: Populate name for genpd To: Santosh Shilimkar References: <20170728163333.704-1-d-gerlach@ti.com> CC: Vignesh R , , From: Dave Gerlach Message-ID: <6f5e2270-af5f-faa3-0ec3-66948d911c87@ti.com> Date: Fri, 28 Jul 2017 11:35:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170728163333.704-1-d-gerlach@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.59.203] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 07/28/2017 11:33 AM, Dave Gerlach wrote: > Commit b6a1d093f96b ("PM / Domains: Extend generic power domain > debugfs") now creates a debugfs directory for each genpd based on the > name of the genpd. Currently no name is given to the genpd created by > ti_sci_pm_domains driver so because of this we see a NULL pointer > dereferences when it is accessed on boot when the debugfs entry creation > is attempted. > > Give the genpd a name before registering it to avoid this. > > Fixes: 52835d59fc6c ("soc: ti: Add ti_sci_pm_domains driver") > Signed-off-by: Dave Gerlach > --- Sorry for the noise, last patch had wrong email for Santosh and this one corrects it. keystone-k2g-evm is crashing on linux-next at boot due to patch mentioned in the change log, this patch fixes the ti_sci_pm_domains driver to avoid this. I will also soon send a patch to address what I think is an issue in the pm domain framework itself to avoid this crash from ever happening. Regards, Dave > > drivers/soc/ti/ti_sci_pm_domains.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/soc/ti/ti_sci_pm_domains.c b/drivers/soc/ti/ti_sci_pm_domains.c > index b0b283810e72..de31b9389e2e 100644 > --- a/drivers/soc/ti/ti_sci_pm_domains.c > +++ b/drivers/soc/ti/ti_sci_pm_domains.c > @@ -176,6 +176,8 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev) > > ti_sci_pd->dev = dev; > > + ti_sci_pd->pd.name = "ti_sci_pd"; > + > ti_sci_pd->pd.attach_dev = ti_sci_pd_attach_dev; > ti_sci_pd->pd.detach_dev = ti_sci_pd_detach_dev; > >