From: Juergen Gross <jgross@suse.com>
To: SeongJae Park <sj@kernel.org>, roger.pau@citrix.com
Cc: marmarek@invisiblethingslab.com, mheyne@amazon.de,
xen-devel@lists.xenproject.org, axboe@kernel.dk,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] xen-blk{front,back}: Advertise feature-persistent as user requested
Date: Fri, 26 Aug 2022 09:15:33 +0200 [thread overview]
Message-ID: <6f65961a-c276-d04f-385e-4146a752cfe9@suse.com> (raw)
In-Reply-To: <20220825161511.94922-1-sj@kernel.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 2095 bytes --]
On 25.08.22 18:15, SeongJae Park wrote:
> Commit e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter
> when connect") made blkback to advertise its support of the persistent
> grants feature only if the user sets the 'feature_persistent' parameter
> of the driver and the frontend advertised its support of the feature.
> However, following commit 402c43ea6b34 ("xen-blkfront: Apply
> 'feature_persistent' parameter when connect") made the blkfront to work
> in the same way. That is, blkfront also advertises its support of the
> persistent grants feature only if the user sets the 'feature_persistent'
> parameter of the driver and the backend advertised its support of the
> feature.
>
> Hence blkback and blkfront will never advertise their support of the
> feature but wait until the other advertises the support, even though
> users set the 'feature_persistent' parameters of the drivers. As a
> result, the persistent grants feature is disabled always regardless of
> the 'feature_persistent' values[1].
>
> The problem comes from the misuse of the semantic of the advertisement
> of the feature. The advertisement of the feature should means only
> availability of the feature not the decision for using the feature.
> However, current behavior is working in the wrong way.
>
> This patchset fixes the issue by making both blkback and blkfront
> advertise their support of the feature as user requested via
> 'feature_persistent' parameter regardless of the otherend's support of
> the feature.
>
> [1] https://lore.kernel.org/xen-devel/bd818aba-4857-bc07-dc8a-e9b2f8c5f7cd@suse.com/
>
> SeongJae Park (2):
> xen-blkback: Advertise feature-persistent as user requested
> xen-blkfront: Advertise feature-persistent as user requested
>
> drivers/block/xen-blkback/common.h | 3 +++
> drivers/block/xen-blkback/xenbus.c | 6 ++++--
> drivers/block/xen-blkfront.c | 8 ++++++--
> 3 files changed, 13 insertions(+), 4 deletions(-)
>
For the series:
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
prev parent reply other threads:[~2022-08-26 7:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 16:15 SeongJae Park
2022-08-25 16:15 ` [PATCH 1/2] xen-blkback: " SeongJae Park
2022-08-31 15:47 ` Pratyush Yadav
2022-08-31 16:17 ` SeongJae Park
2022-08-25 16:15 ` [PATCH 2/2] xen-blkfront: " SeongJae Park
2022-08-26 14:26 ` Maximilian Heyne
2022-08-26 21:20 ` SeongJae Park
2022-08-26 21:59 ` SeongJae Park
2022-08-27 0:27 ` SeongJae Park
2022-08-31 15:50 ` Pratyush Yadav
2022-08-31 16:20 ` SeongJae Park
2022-08-26 7:15 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f65961a-c276-d04f-385e-4146a752cfe9@suse.com \
--to=jgross@suse.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marmarek@invisiblethingslab.com \
--cc=mheyne@amazon.de \
--cc=roger.pau@citrix.com \
--cc=sj@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®