From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EFA9367F44 for ; Fri, 15 May 2026 01:23:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778808222; cv=none; b=tFzydiI7q4GlQoK1+sUpkQ0OF9b5VbBlMXzWmZhvmy+upseGOOBO40SdBE/J2kgrp9CCM//cccIujwlYC9KYyFGeUm8SZnwgMSbN4HubKEkH86ZIpW4ofNXYs3FN5A3MSN/fNPfoMWoi+L5tVS38RGX8pBXc/1GfyKAQXu0Q4D0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778808222; c=relaxed/simple; bh=xCFPu1zNnERScuds1BA/xDI7JtrElF8fFYPNfBb474E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iOdMEMnw3v2u5iTojB3Ux3O9rpvwqok6W87IyH23WBDtlQcBcP7Qfrj/16hjviNIGP7N7KW1N3cdS7B0UDEA+fGrNbTJPQQGHp81jWbMfIjHSdzPyN7Z6B854zWT8FliJ+6Xm1tD+tNrdSOxhFC0y6GN0ial0jCfhR2kMLxS9Hg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j56L0qm8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CYCSRJgI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j56L0qm8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CYCSRJgI" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64EIpKD03197968 for ; Fri, 15 May 2026 01:23:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GbRyF0yHF8n8xfJ6kWgsPZHepfaFdKar74Yr2tZG1yo=; b=j56L0qm8BMNVIf3Y gj0eN+2W9sAi7aK1lwSHVZyd6JP5ByEv6z5prnc56YDYmj8uOOEsaDXUES5YKYE8 pg9wboQvYOSh0cqXAKGDP+AarJmDlnFzzM0RTVCtPEHdRrR7s1QmF+NvEYkx+/AV PIw8RUu24tQ+5msdyGrCVdfW38BhgcDo0OQIOQcyWvLjwvGbTHT+ENVW4kBM71wI akHsAWXi3Fw5niBoyqy0VX1/t48HK8j4xr9DlYMjWaK5VKSRWh0/3Pd3Vo+0Rnon sk6sy/+JdgOtVwfwQA3uH3V8CguBN3rBDWbSz15venb0a4S8gpn7k7C0qLCDC8i8 N1tPvg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1q916f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 01:23:40 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8230d6d54a5so323705b3a.1 for ; Thu, 14 May 2026 18:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778808219; x=1779413019; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GbRyF0yHF8n8xfJ6kWgsPZHepfaFdKar74Yr2tZG1yo=; b=CYCSRJgIirgVy3f/xXnvXjBlLkT2vtxu2Pk40oFP0RYFE0NMggqbJu+jnez7Di+l+e Viz8G21Mr8VJcF3a/JsoCWShgBRVjBjlGc8sAGFff3ajlqgOk9RqXpiXbaSWwauTdJhG GIdQrXXtzeShPlLqGKfLAJWQP0rNPqMgoyCxcih0cbJJf2F9OqAIHk1C5wczDxgeyhJc mwgKwuuTge4mUgL0vmwj9wqEMLpEPsWUw8LDvCiKN8Q/2Sru1ofm/VLSphgFMUGYFFwd Tl9lMxtKIztY6F6taS3Zn1SwCuZfVHALZpkHyDE9dJePKbmp5STGH4//QTRgaCoQPuJV caOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778808219; x=1779413019; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GbRyF0yHF8n8xfJ6kWgsPZHepfaFdKar74Yr2tZG1yo=; b=FS7mXVm4WiOlcBtLTaNdkSthw00E5vmXffM5H38W3ovFwNEzBgciJp2DrjhqPEI198 e3n78Xg/Z8fy6yxb6CLACfo95AJECUZ+YuJZOTgEVSKDLSP1q9PzkpGMH0DN6SQqUqki LkVvoGYvivpnNTxY/ZWL+fRQdJxX2IFtZNQ2El2ESi7qBUW6DFzvaaNzO4Fd8W5RRRfG R0CDo12AGoj0DVdfXokj3rAEkqF1U9OiOng2Ao1dgrA5pLmFVMTuyCbtKg1mumx6wpqD +dFnsrfAaHiptU6dH8XAdQALvVO1cMtu3037qOy41YKL0NMrcwbB/xsU1I02VQu3Zu3k vNLA== X-Forwarded-Encrypted: i=1; AFNElJ/wSex3sQG4ARzMGqpRwkl/vLdhRKylZlqt3Gt/z5Y3rvlZiA88Mx+lCQ770WgkVyTIfSmMhVLmPAIP+CA=@vger.kernel.org X-Gm-Message-State: AOJu0YyDc2Dz1nXbk/RV3eLcDtJ4GAnHNci+KVp1lz7/khWKM2jxb/nb YRCx1dZxz+kaZrD4TqzHf76gQeID3XPA9yQLz2K/ZxliAIoKnRt/+WnXuLmdCFLgol0C3fKOC0f UjHutI1FGO4slHvaJNIfnn9plBMElcSs70NUvcHr/h4mpHgrp/3SjOfExaPWUofROrocbCVksrQ == X-Gm-Gg: Acq92OGjpsIy1aKonyXL9CB+SAitcgcXVliXJaWBK7SV/yMP875P79QWhauEP4ZyKls HsDZtpa6OQFOnqTgmCV9sl+SXWcVUqXDOs7evJTE5uekqNx6q617xh0SRrNN2/1aL7l62MPQwzi W5J2ZrP5auTc29p/bF2TW8TwOFY375SwuvCsZWU42Brl+2A1AZ4nQ0lJHtUV2wdJb7a76wNbdR1 JKnqMP5RVRVYoeAaGK/gCwvHlFncU8SQWhS8DRNj+uAWzQKOgM9WifvXHBZpvekthmq5YnksCO/ NVepROW4EKbTXWrYwF2T3M6AcjyA7rYqqUWtowNjUacDf0v2fBJO3RHFeyiXarMho4mLsFYdnMH wUKFbEgCt4XZmuIecsREAcEK1AByBLG0lx9/OIKBjQSlJZdtO6PTeM+7GjPwjxiGZ0wIdXwXgx/ thd4pCGLVU7bLKwY7VxfE= X-Received: by 2002:a05:6a00:3028:b0:82f:2aaa:c14c with SMTP id d2e1a72fcca58-83f18e770a7mr5240001b3a.16.1778808219198; Thu, 14 May 2026 18:23:39 -0700 (PDT) X-Received: by 2002:a05:6a00:3028:b0:82f:2aaa:c14c with SMTP id d2e1a72fcca58-83f18e770a7mr5239976b3a.16.1778808218670; Thu, 14 May 2026 18:23:38 -0700 (PDT) Received: from [192.168.0.74] (n1-41-240-65.bla22.nsw.optusnet.com.au. [1.41.240.65]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19663ff8sm4062970b3a.8.2026.05.14.18.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2026 18:23:38 -0700 (PDT) Message-ID: <6f67ffe9-41ca-4102-99be-440356ba672a@oss.qualcomm.com> Date: Fri, 15 May 2026 11:23:32 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tee: qcomtee: add missing va_end in early return qcomtee_object_user_init() To: Robertus Diawan Chris , jens.wiklander@linaro.org, sumit.garg@kernel.org Cc: linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com References: <20260513091031.145826-1-robertusdchris@gmail.com> Content-Language: en-US From: Amirreza Zarrabi In-Reply-To: <20260513091031.145826-1-robertusdchris@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 5wmufap4aIbVz5415fPK_b_IAQP2CCwz X-Authority-Analysis: v=2.4 cv=GulyPE1C c=1 sm=1 tr=0 ts=6a06759c cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=hi51d+lTLNy/RbqRqnOomQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=2fb_BHWLsD0z38efADMA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDAxMSBTYWx0ZWRfX8PCH2AFf6U5t XW/17c1WZg7wNAj5gLN99c3NQHbe9d7EGEeLEElS1qPbQoF5m/9xHuRDRgPuALXC8JDhm5jdd4f 2bD3l1o1SAIKnWZYes11A0vSp9jWloqfM39T8rLwihMu9Tt5WHqzNHY5Zi5MV+OslCmN2VudqmV Fc1FEszhKmCEPl98VM3eXpcYqoAaqHp+9saggT4Qfa9yvTDk4o2k3TE0sZ9yTdwHWyP6HLZiTl0 +jDrbpOUaAJz2rHEmgP+VbI/Amg0RYdCc7vVhB4P/e2jzkpZWCQub8PAC05jmKr6+bUpHE6qlUX EKFyk7Eli6IBNmLL5mp49/3tBbz9irXxI8Uv0bys2ugHal7DzC0BHDGjv9ikxyhQ2BNnmGZqQz1 j77YpA7AkeJs4rLbpz0t7tKuxRttAmGQekVD3LuXNJHxbfoA6D+toLIW5MqHtbJ99RxndH/oPhX HauHALF+jxSUfOxTTMg== X-Proofpoint-ORIG-GUID: 5wmufap4aIbVz5415fPK_b_IAQP2CCwz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-14_06,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 clxscore=1011 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150011 Hi, On 5/13/2026 7:10 PM, Robertus Diawan Chris wrote: > qcomtee_object_user_init() is a variadic function and when the function > return because there's no dispatch callback in QCOMTEE_OBJECT_TYPE_CB > case, there's no va_end to cleanup "ap" object initialized by va_start > and that can cause undefined behavior. So make sure to use va_end before > returning the error code when there's no dispatch callback. > > This is reported by Coverity Scan as "Missing varargs init or cleanup". > > Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver") > Signed-off-by: Robertus Diawan Chris > --- > I don't have the device, so I am not sure how to test this change. > Thank you. > > drivers/tee/qcomtee/core.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/tee/qcomtee/core.c b/drivers/tee/qcomtee/core.c > index b1cb50e434f0..901a31e8201f 100644 > --- a/drivers/tee/qcomtee/core.c > +++ b/drivers/tee/qcomtee/core.c > @@ -306,8 +306,10 @@ int qcomtee_object_user_init(struct qcomtee_object *object, > break; > case QCOMTEE_OBJECT_TYPE_CB: > object->ops = ops; > - if (!object->ops->dispatch) > - return -EINVAL; > + if (!object->ops->dispatch) { > + ret = -EINVAL; > + goto out; > + } > > /* If failed, "no-name". */ > object->name = kvasprintf_const(GFP_KERNEL, fmt, ap); > @@ -320,6 +322,8 @@ int qcomtee_object_user_init(struct qcomtee_object *object, > default: > ret = -EINVAL; > } > + > +out: > va_end(ap); > > return ret; > > base-commit: 5d6919055dec134de3c40167a490f33c74c12581 Reviewed-by: Amirreza Zarrabi Thanks. Amir