From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 9AC6923183F
	for <linux-kernel@vger.kernel.org>; Tue,  7 Jul 2026 04:58:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1783400283; cv=none; b=BqX+eedpgxdGibVcd2w+abC5JjBxQhjhFAxa/rqlMYz1DTApqiUAZf94ebKT9zdL0rbjZ3pQjCpcqYTUuu8Ck7nKEp6YvYSZe4DyGwTe5QZujETgCv32F8FvoGkNme3wDZtsfpcmcyKz4/80HMTH1Twm0YNeGwS+jjJb+5lUWKQ=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1783400283; c=relaxed/simple;
	bh=xvbL7kvG0VDsGKdPSXKFCr/Na/I99QDnXl/z867q6ns=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=ei7DfrfB2dWpozB2z6H1y674Tl8RguqpiBzcilVNEJ0OnJlK0/oV0JO10NQeOBy3UsfMRAotf8hFl7p7nsnyzOAbjM7y8XKFmA1ce3uizTROvUcV9A39IY5oApFOOejT7m5QzhCj9hQJPnD1W6Cw1SYHIk1dJE5S97iALYgzWMo=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=DRLmW3Iu; arc=none smtp.client-ip=217.140.110.172
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="DRLmW3Iu"
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90EEF1C01;
	Mon,  6 Jul 2026 21:57:57 -0700 (PDT)
Received: from [10.174.43.45] (unknown [10.174.43.45])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 92DD43F85F;
	Mon,  6 Jul 2026 21:57:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss;
	t=1783400281; bh=xvbL7kvG0VDsGKdPSXKFCr/Na/I99QDnXl/z867q6ns=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=DRLmW3Iuf07Npj/O/cDrlSVfLRplOTmmzrAyWqHn+praAlNGWHYSOGz9FiI5WAyRT
	 fLtqQm+INNflV8nXZQoHxalM4+MBsFhAuvZQPSp7VqFhEzKW4jQlYGI5lD1t5zwTXC
	 YNkgpqHqi1F0UxByS2f7dy+T9Hu7ZUk6tsqQh4xU=
Message-ID: <6f68a4b6-9f6b-471e-bd21-fd1591cb6a69@arm.com>
Date: Tue, 7 Jul 2026 10:27:54 +0530
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm: Standardize printing for pgtable entries
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, andriy.shevchenko@linux.intel.com,
 usama.arif@linux.dev, hughd@google.com,
 "David Hildenbrand (Arm)" <david@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
References: <20260707041703.658021-1-anshuman.khandual@arm.com>
 <akyGWZCRbasIX_wY@casper.infradead.org>
Content-Language: en-US
From: Anshuman Khandual <anshuman.khandual@arm.com>
In-Reply-To: <akyGWZCRbasIX_wY@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit



On 07/07/26 10:23 AM, Matthew Wilcox wrote:
> On Tue, Jul 07, 2026 at 09:47:03AM +0530, Anshuman Khandual wrote:
>>  	if (!pgd_present(*pgdp) || pgd_leaf(*pgdp)) {
>> -		pr_alert("pgd:%08llx\n", pgdv);
>> +		pr_alert("pgd: %s\n", pgd_str);
> 
> I don't like the extra space being introduced after the colon.
> It's normal practice to not do that.

Sure will remove that.
> 
> But in general, this looks a lot better.

Thanks !