From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77E52330D3B for ; Thu, 26 Mar 2026 13:18:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774531093; cv=none; b=djAw43pLy3j2ZiBcCg8aPqTbAq3KeCvJ1z79Ol3yWCNuKjHhteYJyqvsqPplQFs0UUs3eGtR7hdfsBEMQZS0loaeIFykNPMP9F3Mo0rXLggh3DczFr3XY+U0iGdVhRBjMUKR60NJp8EkOpxcFFVnmIkotShXFUvfc2ZCUnOV21Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774531093; c=relaxed/simple; bh=GVrAs+mbWwhG4Yrs5Y37N0As20DHfpTYfrsSSzI6gEY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EJx3jBkDW+PsIAmMVTtFwWacJEjKLB/jfzPHRTYh91fgwauc6BYDYygBNMKm0Dd+w/Dm2fphhPkF47jAmv29gfzwmfojg+rb2NF30Y6/gOGADDSmztORyZh8mn/t1ShuwcVOpGylWfZmQUo4hYfZq68OdaDKQZgRZ3QDhStG4Hk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IL6WnSxm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FxDwy5wq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IL6WnSxm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FxDwy5wq" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62QCaPKt051998 for ; Thu, 26 Mar 2026 13:18:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JtXH9taf87WO8xzgXDDb3Zjy+pCG7JpfvAodNb6v2H8=; b=IL6WnSxmED1MJgzW FQdMf4e4RFz+MLIT5qffNSmweyniSM119ealASPQveXSxxrybWuzhHqQH75rWiPE caP0QVufVW2HuV02FFHZUkqzZQXU419yuqZC2OvkUF7V7D6LVbpSjKI31Y+WSemy d/5Zutv9AJ4GI5gSEofpZPq2W+A4HzH6hog6OuJlDVuDuUb6FHd/azNb1EVxWBbl m/Hscc3w1Vj4t8at3kGkLh15lrbhojLdWVoSPeOx6AE8P9UJrm1X0xmjk/IJ6kQV ElprTywd98aD3Ing/iCdMvtXvAKzXIkwKn7pL973AV1CTeZaiIeoq5Bj5arESaut nwQfTQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4q1t2xkq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2026 13:18:11 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50925fed647so29708961cf.3 for ; Thu, 26 Mar 2026 06:18:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774531091; x=1775135891; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JtXH9taf87WO8xzgXDDb3Zjy+pCG7JpfvAodNb6v2H8=; b=FxDwy5wqJrjju6HRLxvH82RwrCZIC4KcTYDa009t6nbXSPHTrEdNSibWY5MZL3m2mj X4gtX2xxeTTFiSAMaInPyldPD+HiB8EBz52JReMUuG6ImcjHEs6nPSfZxXs2HflG7JRO uFkMI+BUXJ4jvle1o41i0Hdx5xVmTozCXxVugb5OllskTaG+qWVh4YUzYwns8fKL37gq qCtrIqYrJObfqyiDlrlun/46ycWDNv6oe/A5AGCc3kmmCWaGnAj0PNWtyuRpGUhJxWjA S7mcEhhXDI6EpBzV6UbHWRcQeDsbSqgfF4CJ2ygPAkbhfotIzUq+tfZXC3DaSMBMkqJO 0zOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774531091; x=1775135891; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JtXH9taf87WO8xzgXDDb3Zjy+pCG7JpfvAodNb6v2H8=; b=gg8U8JjXRRv3fflOZCoEy3NvYEz8k8YU8nxzX9lb6qocve3yfDug7GRGPNYjfaM4eb IaiAHLyE0q+AzpGyFyq/sETLJ1ykkZ62sp24l8vp3yOYdz5pvucoFAVAXr01E1GsrgzK HrTkLilctLVSVtvQn3YTx4xK2OY2MkFa6Y+279EaUAAOMo7V2Lui6YSrGY4CUPFTkbUw tk/OcF5Y/Xit5XIEYGlSc8sqdQQNSAATJ5dIOB+6vdVrL/Hq5ycTm/vLvAmdHSQpYGeX C+aVzp4T11X55z2UzgQEi4LVfi0OpGxFkLsv/jEETa0Q6LHY4YQXMpgYX2FHTbdRH+Rv /7uw== X-Forwarded-Encrypted: i=1; AJvYcCXHsTGigbFumduDiaLm/n7+HufUveFPsq0ALWWyhgb8qtdRDHdnB/LXIlLVGmeGdgb9kxP2e4tzm64J7Vc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+N6MzaByu05UEuDI/WhnYeotXjn6wCvTFGNZnOrTDw0iDqc2T kVuEZoQD1KNX8bolPIr4kGd1+GCTezpCN9MfcrITAgMaCvaJ0uGYzoGxZlmOiYahiwyrSLqQCXr m25pICLi6OZLdNOgdQMm5XqPg0D7UUlViTLlczU2Lm9lct42h2Xqmzp4FYlI26dOuSC4= X-Gm-Gg: ATEYQzxmEEG0htLUu/QUH27cTxSC2vV99j1boiT4tXbgTCqEqH8Ieux9CO7zBhYb+9Q jTfz17PL8Hn0kmHsW4ODxK/ylfjarkB4+cg9zZo6b+ZY1r1QXALkDNxMut/FmHYsyM6ZO0mL9Sn FHPmue9vk7GHUt4wGhIPpPIiwOvrath0A9iYwxN9OFiEQvnM6vNqp/OpgOBM7ZM6kBixzpj7PHY z6iK7qajDNo9gQlCRoFfuuUs1gR2l2S2UzqaBgfReyL1Ff9niy5doJkrNCDI5Y1fD9u+3rQNM8w DMLKnPNnWlApgUWS++6Xbz6xpbce4k4kHlYDvxWH7dvSU0cZw5bDFJs/aNsONniYIZWByBeQdyL MHXtzA1L3fgDtLh0HqFLPmXN5HFDJqJwNRWV79YZnv+uR7aUk X-Received: by 2002:ac8:754e:0:b0:50b:69c2:b86 with SMTP id d75a77b69052e-50b80d73a8bmr73580231cf.27.1774531090872; Thu, 26 Mar 2026 06:18:10 -0700 (PDT) X-Received: by 2002:ac8:754e:0:b0:50b:69c2:b86 with SMTP id d75a77b69052e-50b80d73a8bmr73579871cf.27.1774531090274; Thu, 26 Mar 2026 06:18:10 -0700 (PDT) Received: from [192.168.68.114] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-43b919e7372sm9397537f8f.34.2026.03.26.06.18.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 06:18:09 -0700 (PDT) Message-ID: <6f70ee7e-78bf-4f45-8fb7-00db13c5e9f7@oss.qualcomm.com> Date: Thu, 26 Mar 2026 13:18:08 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ASoC: qcom: audioreach: explicitly enable speaker protection modules To: Ravi Hothi , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Krzysztof Kozlowski Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com, ajay.nandam@oss.qualcomm.com References: <20260326113531.3144998-1-ravi.hothi@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20260326113531.3144998-1-ravi.hothi@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=e7cLiKp/ c=1 sm=1 tr=0 ts=69c53213 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ynJt5whLjcjaSQVNdSsA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: yD7iAnfo5WSL37PGzYtmr56ZYd_VrbzG X-Proofpoint-ORIG-GUID: yD7iAnfo5WSL37PGzYtmr56ZYd_VrbzG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI2MDA5MyBTYWx0ZWRfX+x6cnOKvPULR wLu9EK9A5+Khw8zZbqLWT1gTqEKtdsj7QPzkPd8FifbiroSkTOxxNNjMNhnhuS1YaVX9U5Zjxac 9Uy5+H1GYlk1C+ycj+TSBz+UQlTojEunxDx2Lp/z2YQBki+267VwaOyoYSgOf40CgJH+r7h3QU+ 7QS/kJhlJWfIqS9OS1bYs6766MpM01rf5L8bDqqp4eGO0iLDz4F162q4k4oBodvQpdijInhNbYO m2opJ0ouXiscj9qPILVmuZp/Kd9GnbEZr5r+qJQxZ5Weiy6mFsognI1DOTgZrmAMVgo3V4WZb8u QFAQKXk8U2xIoQ9yuqQ7Loma6OajKzxsCePBQD8L+tVV2swXkIoz5BISEpJdKk0lDfmcNHD88xC DydJzwwJCmM8xcmUTDIVyRln3ltqFFOcbboBbHctJPj5ezJ6LsAuOs20FRrl93nVfKSIusHukmU du7sRE/tQeFUKdE2zHQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_02,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 phishscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260093 On 3/26/26 11:35 AM, Ravi Hothi wrote: > Speaker protection and VI feedback modules are disabled by default. > Explicitly enable them when configuring speaker protection. > > Fixes: 3e43a8c033c3 ("ASoC: qcom: audioreach: Add support for VI Sense module") > Fixes: 0db76f5b2235 ("ASoC: qcom: audioreach: Add support for Speaker Protection module") > Signed-off-by: Ravi Hothi > --- lgtm, Reviewed-by: Srinivas Kandagatla > Changes in v2: > - Added fixes tag suggested by Dmitry. > - Link to v1: https://lore.kernel.org/all/20260325054408.1994556-1-ravi.hothi@oss.qualcomm.com/ > --- > sound/soc/qcom/qdsp6/audioreach.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/sound/soc/qcom/qdsp6/audioreach.c b/sound/soc/qcom/qdsp6/audioreach.c > index 241c3b4479c6..ff8cd55b0d89 100644 > --- a/sound/soc/qcom/qdsp6/audioreach.c > +++ b/sound/soc/qcom/qdsp6/audioreach.c > @@ -1365,9 +1365,14 @@ int audioreach_set_media_format(struct q6apm_graph *graph, > case MODULE_ID_SPEAKER_PROTECTION: > rc = audioreach_speaker_protection(graph, module, > PARAM_ID_SP_OP_MODE_NORMAL); > + if (!rc) > + rc = audioreach_module_enable(graph, module, true); > + > break; > case MODULE_ID_SPEAKER_PROTECTION_VI: > rc = audioreach_speaker_protection_vi(graph, module, cfg); > + if (!rc) > + rc = audioreach_module_enable(graph, module, true); > break; > > default: