From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88DEEE743C4 for ; Thu, 28 Sep 2023 21:16:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232374AbjI1VQD (ORCPT ); Thu, 28 Sep 2023 17:16:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232052AbjI1VQC (ORCPT ); Thu, 28 Sep 2023 17:16:02 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F18C819F for ; Thu, 28 Sep 2023 14:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695935711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=668WRSwzccSSZLdUmHKsncI+ABaAosHC/XXc6je1ZO4=; b=Q1InXibYE0BLxyvKRsIe5JHXuej5Juh6E+EC2xq2t/xNwZuwV+W+GKAmZ9QCnn8tXKlGJF KN+dYG7UCGGdrRlf+ifJYV43pc143/MkocHqxYTwuaGmKKyuxvc6ZTUEwDC+BVDUUtjuq0 Fb3C6moNh640zQSro+bCKuhuZfOCpnY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-Y6P4a-zbNrmR2LJE485gOQ-1; Thu, 28 Sep 2023 17:15:09 -0400 X-MC-Unique: Y6P4a-zbNrmR2LJE485gOQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-32480c0ad52so1588686f8f.0 for ; Thu, 28 Sep 2023 14:15:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695935708; x=1696540508; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=668WRSwzccSSZLdUmHKsncI+ABaAosHC/XXc6je1ZO4=; b=cucmIYprqX/p4F3W/gZFGB0dzAZCHAsyF2nrO2/ovlf+62HrutQ0YomJd2dJbGp8Er b3xr1AIQnfo2GrRBdlRJ+VCvwpiyHiqWxOhwWH7hJSLazJvgR6xVGy5aXQb3hXzTav1Y r50dKEJdJNUB50zTxkPuPEiG0kuDZkyskKDCnkT455ecpBBPpHSukMP+7axjLSAcwWLr kxUas+ejAgR2y9eLZKIrH8YRRy95H5Y0JFFizVj0JRfHkfS8wZOGeuYgaVff18QfhUtI SpGydOK0Ln+zXuIz8YyRPl1jinuYENkvAlLN6haGKBdiDW/5iVvyq2I0TsuBAJtLUc3w qkiQ== X-Gm-Message-State: AOJu0YxjCvsbN2YzZMEUdlYc16Cju+umUw4E+mZEJEn5JK8jWeYXKCQ7 zQABaNEZzi2T6ct9Ggin1YoUYYqzUgu9GSNRJT68FwKp+gpweG33FNUOPvmx1H4LOAlaZC+GU9u ISyU9epoLIlFjtC0jMGd89ajF X-Received: by 2002:a05:600c:ad3:b0:402:e68f:888c with SMTP id c19-20020a05600c0ad300b00402e68f888cmr2307041wmr.7.1695935708550; Thu, 28 Sep 2023 14:15:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEoLBoBW0RgQfcEdiTRVcDK8Jq1t72S30ZWZt45BMjO2TF/Kz5Taeo5wZ+kqpssbrMB8u+FAg== X-Received: by 2002:a05:600c:ad3:b0:402:e68f:888c with SMTP id c19-20020a05600c0ad300b00402e68f888cmr2307027wmr.7.1695935708175; Thu, 28 Sep 2023 14:15:08 -0700 (PDT) Received: from [10.10.158.202] ([213.144.205.82]) by smtp.gmail.com with ESMTPSA id p8-20020a7bcc88000000b003fbe4cecc3bsm955wma.16.2023.09.28.14.15.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Sep 2023 14:15:07 -0700 (PDT) Message-ID: <6f7530af-a160-620b-f3d4-a56dae1e0b46@redhat.com> Date: Thu, 28 Sep 2023 23:15:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 0/5] platform/x86: int3472: don't use gpiod_toggle_active_low() Content-Language: en-US To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Mika Westerberg , Andy Shevchenko , Linus Walleij , Daniel Scally , Mark Gross , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20230926145943.42814-1-brgl@bgdev.pl> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 9/28/23 20:40, Bartosz Golaszewski wrote: > On Thu, 28 Sept 2023 at 14:40, Hans de Goede wrote: >> >> Hi All, >> >> Here is a v2 of Bartosz' "don't use gpiod_toggle_active_low()" series. >> >> New in v2: >> - Rework to deal with ACPI path vs gpiod_lookup.key differences: >> acpi_get_handle(path) -> acpi_fetch_acpi_dev(handle) -> acpi_dev_name(adev) >> >> Regards, >> >> Hans >> >> >> Bartosz Golaszewski (2): >> platform/x86: int3472: Add new >> skl_int3472_gpiod_get_from_temp_lookup() helper >> gpio: acpi: remove acpi_get_and_request_gpiod() >> >> Hans de Goede (3): >> platform/x86: int3472: Add new skl_int3472_fill_gpiod_lookup() helper >> platform/x86: int3472: Stop using gpiod_toggle_active_low() >> platform/x86: int3472: Switch to devm_get_gpiod() >> >> drivers/gpio/gpiolib-acpi.c | 28 ----- >> .../x86/intel/int3472/clk_and_regulator.c | 54 ++-------- >> drivers/platform/x86/intel/int3472/common.h | 7 +- >> drivers/platform/x86/intel/int3472/discrete.c | 101 ++++++++++++++---- >> drivers/platform/x86/intel/int3472/led.c | 24 +---- >> include/linux/gpio/consumer.h | 8 -- >> 6 files changed, 93 insertions(+), 129 deletions(-) >> >> -- >> 2.41.0 >> > > Thanks Hans, this looks good to me. I'd let it sit on the list for a > week. After that, do you want to take patches 1-4 and provide me with > another tag? That sounds like a good plan to me, will do. Regards, Hans