From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wfout7-smtp.messagingengine.com (wfout7-smtp.messagingengine.com [64.147.123.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 392E383CA2 for ; Thu, 4 Apr 2024 11:43:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712231035; cv=none; b=nZQt7Iel8GofToEs0quMhutOX98vUzMhzj6LOy/ya1h6y4fDQe/VvcrVIhWSf/xSfvJ8txIOw4DybLM3hVnzUmiRpAEuOHd+tTmfu5qd4Sd5RpD/HMmatwHJhqYjIV8BA0XkcekpXCgjOCNu5HXpZykv1Jgu1BIbQtPziHGsmzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712231035; c=relaxed/simple; bh=JS/gyrihL+kmuZx19if6yfZwNbw5WpGkmW5rUpwhV1c=; h=MIME-Version:Message-Id:In-Reply-To:References:Date:From:To:Cc: Subject:Content-Type; b=mwnWsXR4xep8WwqEgVEihW+QzVFuDFhjIqFux6v1ksTF5iLuxE+kPtWfmkLRHNzYI1zIrL3TFruRguW+iDhatYePoaVVNAejaDlCb6gnKTNSvyXM8w/RHX7Yh1f8ULpHEJEjxFbmUGwSlLeshycLpuIh4MSCxg1Ua9d7xMwBdsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=CGoMWAsM; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=lFUVoPzS; arc=none smtp.client-ip=64.147.123.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="CGoMWAsM"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="lFUVoPzS" Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.west.internal (Postfix) with ESMTP id 87EDE1C00089; Thu, 4 Apr 2024 07:43:51 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Thu, 04 Apr 2024 07:43:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1712231031; x=1712317431; bh=1CDCHaWEhOkiYy29sYtgzdL6T7tUW4lcGYamlcwuiRA=; b= CGoMWAsMcxnS91IP2ezijTguxET+DbB/PlHjKKDN272tv37GjDpNXaOywim5Gsrk aqx2Wt0nZorSAPAr1yQaGdruX5+7A+UkkwGNNA/KZwX471xoSuV5qNuK5RjVx9if 0Mn9lWFi2NgjfmobKQ56bGyOu3vaUhuXNDCRLza3BtXLE5XIVycUZ96LvI4f6daM QGwB16ScbhKDW2J/veuk50i6C4HmckL6Wvoi+5JwmyjoZp7CxgTzU+Vd7XLLuz6F 2Bs7E6XFGMReQUFLAWoJ42B6uV3+UZSrASFlk/qJBxssqonexDaFNGAWLEhX88UK RFixypeC9SgfjnuvHGb5Xg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712231031; x= 1712317431; bh=1CDCHaWEhOkiYy29sYtgzdL6T7tUW4lcGYamlcwuiRA=; b=l FUVoPzSYVN/yp8KUfA519NK13OXcwH7OOVsJuD1VxLqrM9Gty33ekJSFhWRMfK4Z RWumwKWHpEKYNQJj2MLL9x51COonCbzikphr22HegyCOQoom7DGwlrzMtQQ67q7g IK9edbvGig74BPRXMRoXp0ECZMmAjluSmH0G4zlZ5y9fI3XatkZZcHwkk3R19sxl RUqN1F5loLbFfeCjDaiQhYtXwyiyYHghZpCak6cdanKjdjDTGfPoCK2FMnIbqfFf B804BMqlVaC73DElyBQ9XjZA6bQHDKk/NoIOptn6YIIllNvLmJrxaP9UQbNJb86/ NbUZFPdE0T+RqTo6Xg4xw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefkedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeegfeejhedvledvffeijeeijeeivddvhfeliedvleevheejleetgedukedt gfejveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 57F08B6008D; Thu, 4 Apr 2024 07:43:50 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-333-gbfea15422e-fm-20240327.001-gbfea1542 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <6f79f3bd-e60a-484a-92b7-f6a26f845809@app.fastmail.com> In-Reply-To: <2ffc8633-6ed8-4641-bd9f-313645dfff51@csgroup.eu> References: <20240403080702.3509288-1-arnd@kernel.org> <20240403080702.3509288-19-arnd@kernel.org> <66a1d5f1-d9b2-402c-826d-955370288037@csgroup.eu> <2ffc8633-6ed8-4641-bd9f-313645dfff51@csgroup.eu> Date: Thu, 04 Apr 2024 13:43:29 +0200 From: "Arnd Bergmann" To: "Christophe Leroy" , "Arnd Bergmann" , "linux-kernel@vger.kernel.org" , "Andrew Morton" , "Palmer Dabbelt" Cc: "Dave Hansen" , "Noah Goldstein" , "Charlie Jenkins" Subject: Re: [PATCH 18/34] lib: checksum: hide unused expected_csum_ipv6_magic[] Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Apr 3, 2024, at 11:03, Christophe Leroy wrote: > Le 03/04/2024 =C3=A0 10:58, Arnd Bergmann a =C3=A9crit=C2=A0: > >> On Wed, Apr 3, 2024, at 10:41, Christophe Leroy wrote: >> Yes, I usually prefer that approach, and I think I tried it first >> but ran into compile-time problems because csum_ipv6_magic() >> is declared conditionally. Let me try again, maybe I misremember >> what I did or I can remove some more #ifdef checks for this. > > FWIW, before replying I did a build check with pmac32_defconfig=20 > (powerpc) with CONFIG_NET removed. I was able to build=20 > lib/checksum_kunit.o and objdump shown there was no reference to=20 > csum_ipv6_magic() inside it. Right, got it now. I was confused a bit by CONFIG_NET vs CONFIG_IPV6 given that the common definition for csum_ipv6_magic() is in net/ipv6 but unlike other files there still gets build when IPV6 is disabled but NET remains turned on. I've done a little more randconfig testing to verify it, sending v2 now. Arnd