From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B4FEC433E1 for ; Tue, 25 Aug 2020 22:09:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10BF520706 for ; Tue, 25 Aug 2020 22:09:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726697AbgHYWI7 (ORCPT ); Tue, 25 Aug 2020 18:08:59 -0400 Received: from mga11.intel.com ([192.55.52.93]:59257 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbgHYWI6 (ORCPT ); Tue, 25 Aug 2020 18:08:58 -0400 IronPort-SDR: 9667FxVrWcuK2285vAdua5T3DsNPxQQ5vBV9/4FNIFczKUYLm5jGCUegNnZjj4R9NCsvIPvEi1 Kw1FSwFzIKtw== X-IronPort-AV: E=McAfee;i="6000,8403,9724"; a="153778139" X-IronPort-AV: E=Sophos;i="5.76,354,1592895600"; d="scan'208";a="153778139" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 15:08:58 -0700 IronPort-SDR: 1IyWrskjuUgB/aKrFItHb4VFvFk/xesFg5h3f0N52YRPlwC+AzLH96nET5w5P1DJgsDfHzXzWf WW57odA9zbmw== X-IronPort-AV: E=Sophos;i="5.76,354,1592895600"; d="scan'208";a="322935683" Received: from lmirelex-mobl.amr.corp.intel.com (HELO [10.209.158.229]) ([10.209.158.229]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 15:08:57 -0700 Subject: Re: [PATCH 1/4] regmap: sdw: move to -EOPNOTSUPP To: Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, vkoul@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com, Bard liao , Rander Wang , Ranjani Sridharan , Hui Wang , Guennadi Liakhovetski , Kai Vehmanen , "Rafael J. Wysocki" References: <20200825171656.75836-2-pierre-louis.bossart@linux.intel.com> <20200825214858.GK5379@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: <6f7e5830-4dd8-1ecc-20c3-df75bc9ef265@linux.intel.com> Date: Tue, 25 Aug 2020 17:08:55 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200825214858.GK5379@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> -ENOTSUPP is not a valid error code, use recommended value instead. > > What makes you say this - it's what regmap uses internally for > unsupported operations? This was flagged by scripts/checkpatch.pl (must be a new addition). # ENOTSUPP is not a standard error code and should be avoided in new patches. # Folks usually mean EOPNOTSUPP (also called ENOTSUP), when they type ENOTSUPP. # Similarly to ENOSYS warning a small number of false positives is expected. if (!$file && $line =~ /\bENOTSUPP\b/) { if (WARN("ENOTSUPP", "ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP\n" . $herecurr) && $fix) { $fixed[$fixlinenr] =~ s/\bENOTSUPP\b/EOPNOTSUPP/; } } I was just blindly making checkpatch happy and tried to keep regmap-sdw.c and regmap-sdw-mbq aligned.