From: Edward Cree <ecree.xilinx@gmail.com>
To: Joe Damato <jdamato@fastly.com>,
netdev@vger.kernel.org, saeedm@nvidia.com, tariqt@nvidia.com,
ecree@solarflare.com, andrew@lunn.ch, kuba@kernel.org,
davem@davemloft.net, leon@kernel.org, pabeni@redhat.com,
bhutchings@solarflare.com, arnd@arndb.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [net 1/2] net: ethtool: Unify ETHTOOL_{G,S}RXFH rxnfc copy
Date: Mon, 24 Jul 2023 20:27:47 +0100 [thread overview]
Message-ID: <6f7e5c45-9961-3ac2-69ae-434191c9e11c@gmail.com> (raw)
In-Reply-To: <20230723150658.241597-2-jdamato@fastly.com>
On 23/07/2023 16:06, Joe Damato wrote:
> ETHTOOL_GRXFH correctly copies in the full struct ethtool_rxnfc when
> FLOW_RSS is set; ETHTOOL_SRXFH needs a similar code path to handle the
> FLOW_RSS case so that ethtool can set the flow hash for custom RSS
> contexts (if supported by the driver).
>
> The copy code from ETHTOOL_GRXFH has been pulled out in to a helper so
> that it can be called in both ETHTOOL_{G,S}RXFH code paths.
>
> Fixes: 84a1d9c48200 ("net: ethtool: extend RXNFC API to support RSS spreading of filter matches")
> Signed-off-by: Joe Damato <jdamato@fastly.com>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
next prev parent reply other threads:[~2023-07-24 19:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 15:06 [net 0/2] rxfh with custom RSS fixes Joe Damato
2023-07-23 15:06 ` [net 1/2] net: ethtool: Unify ETHTOOL_{G,S}RXFH rxnfc copy Joe Damato
2023-07-24 19:27 ` Edward Cree [this message]
2023-07-23 15:06 ` [net 2/2] net/mlx5: Fix flowhash key set/get for custom RSS Joe Damato
2023-07-25 9:59 ` Tariq Toukan
2023-07-26 8:28 ` Joe Damato
2023-07-24 19:27 ` [net 0/2] rxfh with custom RSS fixes Edward Cree
2023-07-24 21:36 ` Joe Damato
2023-07-24 22:08 ` Jakub Kicinski
2023-07-25 8:40 ` Edward Cree
2023-07-25 20:47 ` Joe Damato
2023-07-27 15:49 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f7e5c45-9961-3ac2-69ae-434191c9e11c@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®