From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E54EC32A3D9 for ; Mon, 16 Feb 2026 16:14:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771258484; cv=none; b=JwFBmCJVCVOvb397vGVWB7WNSQmDnDaTRpBS4vRS6oghLRBgVleaKGMyBzwZj2bisRpxvzL1LLzph4V6IOnWql861J/g0WaAeWp7EY/aI+dvBKwLbwXxAiHPGycl3f4H2S8Eg35PpHabrNqta4/3qoFqtJvVYY2GXQ1W/p4jTx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771258484; c=relaxed/simple; bh=1y/SzGi0bkdIuCNmYpx1PNLEnxpgIhaBJEI0M2T8/EE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=ThpU3axkPTyjMBv3yugzl+j6OrEppRv2MjeBuFsmFJ5tJcqHlmkJsTPOmMgw9BYiX9JwE0Mpg5ypU2GCVx7LVZ50eiVi+js2TvnfGEiBPyfsOlAof4ZIv+dyqJZ9FNxVCZHucIpy2/03wtyt/AZo3Rb9Mz2Qa7qa7KQ4orTpphM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HinUgv7r; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HinUgv7r" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-4359a16a400so3336551f8f.1 for ; Mon, 16 Feb 2026 08:14:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771258481; x=1771863281; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=YBOE+Anr8vUR4aIW1HzZup3vQzErzRhY8eC+0tt761g=; b=HinUgv7rrJfSZXBpvcXxNqid9ZpoF9y4v9gKsd3vu2YVMm32Q0bFT38EUQy/lQZb04 vNzycNRlHhHrG21uP2EDJRo9paBgQpvv6JxhXqU4oBd8yt9TlLl7Bg2JWE/Kc1J9v1yK Cstqebn3UPBOBZc7JAtuamhg2lc5xD/ex8Dhv19njUGJT1/p46zUCfP9REKv9O1fItrw +/eR866x6lLK/4t0brUHxuiSqlUDeKvN3zIViA6N26z1l93E5wfgPPR6Ui/Iplw2nRFM 6qvmyaNBz5/HKRv2AdUEeo8+m9JdKrGOdDUyt/GbGRQyksCKl0dwSEfbcXR+pIZzCEy1 0U3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771258481; x=1771863281; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YBOE+Anr8vUR4aIW1HzZup3vQzErzRhY8eC+0tt761g=; b=dzU4ddnxU7kM4SKAEO0fkg4Gi9u7LBDYL+7P4E0O4vacrGfsHYpUCmqNnrI91eQhuk c/kJYShLuoPACA4CiPjjKF7wTaGRzeRreNqU4VYirTHmT+T3VLNuaoGyjq/MXPsNFJ50 G8via037qZw+Ob852C+eiDYIrnTV8bGYBtUlZyKdOfuGy+uQGY0Js76ySG7NTRqupOHy Wc53pcrybiHKVTw+kaYiKg6IZikt89ueLPNJuh7xWfNe8ZUv0Tb/fNcTfLe/Ock1zYza ZRYMLsAWFOQbJQJIrSTfWao/MZvfum+U5lC+c09uWhrJ7eg+TeeGZfvMRv4kkryjxW/k xdiA== X-Forwarded-Encrypted: i=1; AJvYcCUzU0ZU0TQ+Pg/gmKtPJR24o6sfKyGKsO/v+jO01SYQYQSHSBmLWF097zgsTSTFvXV2I8el0bRSVQHPnEU=@vger.kernel.org X-Gm-Message-State: AOJu0YyWG9VBTPyTfO+/RZ3h1tQicONMg6rl0oKYCC60F9YO0MdXp79H V7jZ7czmCb+vdxADApY+IDmPDuDxR5sZrLbFhyHQ6TNKYshdkUvbbcXqxnyPO/rxmK8= X-Gm-Gg: AZuq6aLNkgX1i/wWLu0S6tdFxUOLfAP1J4LxkQKFhJ4XO6NVN3dVeFcVhW1Z3jw+6eB gk4fiENn20AYPKUhO2Pk/LBqfWK65pCb7iI/m2Vl8M0D3+BxAAJDf4F5SfwGVoZ3DHTYhh/+cY4 zIrxC1GcVORW5GLSj35yUK2UiGqk3gK6+yvengu5+KCMNDCNvS84BFWznr3jcdRgjknQboHFN5H tDi07B9NOlQ7h0HTom7ZnG+XW9XtAiMXjPyqqkAa3sDepOhGdrkpoygHlufTnSmX4eRDjX9aarO a1TCqntWKcYfvVk5Vjj6y3740SOvCu2qulg017JkOEKvRiU5EepaM7KkphnrTr4RpO8lf9mgXH2 mlHcLwc0yLKywFm/dKRQFiYAFwyQJp8Kl7Q/dJjpmxFbRPNdJZ5p4cUOVCL2WY7/ylNBwv5r6MU pn0HPxNi/r5H8h0gFZQ+Yts156hQ2ZoJ/vZIUg5SaAjVEH/swkocCOJuPfpftDNYwIkM/thTnNU srD8Q== X-Received: by 2002:a05:6000:430c:b0:437:677b:4a24 with SMTP id ffacd0b85a97d-437978cdde0mr21787157f8f.15.1771258481138; Mon, 16 Feb 2026 08:14:41 -0800 (PST) Received: from ?IPV6:2a01:e0a:106d:1080:80b4:8b51:72a6:9e2a? ([2a01:e0a:106d:1080:80b4:8b51:72a6:9e2a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ac8209sm29732239f8f.30.2026.02.16.08.14.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Feb 2026 08:14:40 -0800 (PST) Message-ID: <6f8896e1-6bf9-4997-9bf3-d5fffbdd4701@linaro.org> Date: Mon, 16 Feb 2026 17:14:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v1 3/5] drm/panel: r61307/r69328: remove redundant checks To: Svyatoslav Ryhel , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260215085140.20499-1-clamor95@gmail.com> <20260215085140.20499-4-clamor95@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260215085140.20499-4-clamor95@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/15/26 09:51, Svyatoslav Ryhel wrote: > This is now done by the DRM framework itself. > > Signed-off-by: Svyatoslav Ryhel > --- > drivers/gpu/drm/panel/panel-renesas-r61307.c | 10 ---------- > drivers/gpu/drm/panel/panel-renesas-r69328.c | 10 ---------- > 2 files changed, 20 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-renesas-r61307.c b/drivers/gpu/drm/panel/panel-renesas-r61307.c > index 45afa44af114..2cc3bd66d6d4 100644 > --- a/drivers/gpu/drm/panel/panel-renesas-r61307.c > +++ b/drivers/gpu/drm/panel/panel-renesas-r61307.c > @@ -35,8 +35,6 @@ struct renesas_r61307 { > > struct gpio_desc *reset_gpio; > > - bool prepared; > - > bool dig_cont_adj; > bool inversion; > u32 gamma; > @@ -92,9 +90,6 @@ static int renesas_r61307_prepare(struct drm_panel *panel) > struct device *dev = &priv->dsi->dev; > int ret; > > - if (priv->prepared) > - return 0; > - > ret = regulator_enable(priv->vcc_supply); > if (ret) { > dev_err(dev, "failed to enable vcc power supply\n"); > @@ -113,7 +108,6 @@ static int renesas_r61307_prepare(struct drm_panel *panel) > > renesas_r61307_reset(priv); > > - priv->prepared = true; > return 0; > } > > @@ -175,9 +169,6 @@ static int renesas_r61307_unprepare(struct drm_panel *panel) > { > struct renesas_r61307 *priv = to_renesas_r61307(panel); > > - if (!priv->prepared) > - return 0; > - > usleep_range(10000, 11000); > > gpiod_set_value_cansleep(priv->reset_gpio, 1); > @@ -187,7 +178,6 @@ static int renesas_r61307_unprepare(struct drm_panel *panel) > usleep_range(2000, 3000); > regulator_disable(priv->vcc_supply); > > - priv->prepared = false; > return 0; > } > > diff --git a/drivers/gpu/drm/panel/panel-renesas-r69328.c b/drivers/gpu/drm/panel/panel-renesas-r69328.c > index b40bfd702fac..b5fe127634ae 100644 > --- a/drivers/gpu/drm/panel/panel-renesas-r69328.c > +++ b/drivers/gpu/drm/panel/panel-renesas-r69328.c > @@ -33,8 +33,6 @@ struct renesas_r69328 { > struct regulator *vdd_supply; > struct regulator *vddio_supply; > struct gpio_desc *reset_gpio; > - > - bool prepared; > }; > > static inline struct renesas_r69328 *to_renesas_r69328(struct drm_panel *panel) > @@ -56,9 +54,6 @@ static int renesas_r69328_prepare(struct drm_panel *panel) > struct device *dev = &priv->dsi->dev; > int ret; > > - if (priv->prepared) > - return 0; > - > ret = regulator_enable(priv->vdd_supply); > if (ret) { > dev_err(dev, "failed to enable vdd power supply\n"); > @@ -77,7 +72,6 @@ static int renesas_r69328_prepare(struct drm_panel *panel) > > renesas_r69328_reset(priv); > > - priv->prepared = true; > return 0; > } > > @@ -142,9 +136,6 @@ static int renesas_r69328_unprepare(struct drm_panel *panel) > { > struct renesas_r69328 *priv = to_renesas_r69328(panel); > > - if (!priv->prepared) > - return 0; > - > gpiod_set_value_cansleep(priv->reset_gpio, 1); > > usleep_range(5000, 6000); > @@ -152,7 +143,6 @@ static int renesas_r69328_unprepare(struct drm_panel *panel) > regulator_disable(priv->vddio_supply); > regulator_disable(priv->vdd_supply); > > - priv->prepared = false; > return 0; > } > Reviewed-by: Neil Armstrong Thanks, Neil