From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC2931C687 for ; Wed, 22 Jan 2025 00:39:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737506396; cv=none; b=dzl1DARfUmqX4TB5W46E3HSdfAX5kB9J0X/SW6bD9ymmrXWzUIPvSDokSBKZEYrTMWeGAO6dBHMsMtFGOaBQVfrKcOy0W1sWXrDClD3c6vP2tVCiA5lKQgmi0VUhHXo9FFVLFueiUM0vG5ob2CWBURoElwUjyeGfWbud4DJTswc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737506396; c=relaxed/simple; bh=SdZKzYOFjcvJbhaQdbT4IeimgpWNHjtjCmLbXbxOSjc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gvVpjmkZMVzMuO9ttsGm77IsmSrUbeEWWZpM9ukpQlHzXweUb8hMyft5TWf55uWQJ8kbWHz/x8j/JaQORCxeB2EwV5QutDp4Ym2k+cFgln+x+BObd2+B67BojG895b5HXLXF0xmzRZmq5vSN4bQ3DUZNs4w7cKBbSm7rcKTjjxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=J5hY5fbW; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="J5hY5fbW" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-aab925654d9so1111528166b.2 for ; Tue, 21 Jan 2025 16:39:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1737506393; x=1738111193; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Xe4seuHvx9fyPEV4EIFNjwpAMDzJSfbeTTxyvfVQ/2o=; b=J5hY5fbWz6NYbIFOuVUMbjVajmDfl9EqXZJdTLPrfIA5PyJGiTXEO3VFgZWlj7C+Cu Yh3ufSgexafnvB2xvArWvdiIO+u2cJUtcisN2/oVFP+ZsN7miG3uTPnzk1aAxR+FLoHp HD33q9SozlERDgn2AJI4q4OAGRTprbNnW7AwiLu5Bx37z25R2OwUwHoN/P2J8cBOyBdS /JsGAIK3FTF/dEMvxbh1qfoUtYiiT3heHvh4OPGFlWk+dzWOt/KEbJJWqEqLvcdwG8mQ tkb0lSUVlGslNmRXdF96BgT9fBzhj88OVKU5i5DTgwp+vaY8HJRk7AevW06sQQpw51U3 iXkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737506393; x=1738111193; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xe4seuHvx9fyPEV4EIFNjwpAMDzJSfbeTTxyvfVQ/2o=; b=Y1uoS325pA84pXtEXPd25Rfv/xb+1TMDuQAUOZ2rNj+oXxc9xID2iK/5t8MRrdH97e iF+uDlztHUnmGUn5242MjI+4MZ63FRXPqIeHFGyGmai+fZR7D61egMDLRtCC1qWTP/Jv CVEoU5/VPeyqNNcDAkQCiFjpOXQSCZ8ge5kmLVf2fE/sFf+Jff1uiBD++MsivRAC+7sL howsJvmgD/EozR5l0R3yz9t7C9e3oj/6YttrmUuVNLsMYyE2MMrVCIRMles68tCph87H 4PLztSed2aTw/wMPq19MiTlf0w5D2ih5EWzzJV67WNF1NTy0dJcquexiuCw/MnQxAbjl VjOw== X-Forwarded-Encrypted: i=1; AJvYcCWDkGX/gWFS/A3RAPeLnGWswDJRPA5NPgHm2YZGqGV3xgm9MNAE9OXSvj/OIzGgd3usG08aFEMAEWE0hN4=@vger.kernel.org X-Gm-Message-State: AOJu0YwK+0BM5YQ9oCeGn1Y0FVvmErb5MwtzJMZy1YUhOEGbLXfGWPby VKv1DGyzIr5i4KOXJT/aK2QQN6g0IV9/v9GDI9h+7/FjELmGtCc6N6XJSOIUVV0= X-Gm-Gg: ASbGnctvwJDszWP4NCiii8Y28ar1fr9wyYSUslTeVaHFrAzPkxqI0WTOtZDc4YV00q3 dHkBV+J3So0Bveas9f7Q32z89KnGZJbjDytg1k2CS8p1iJTaW/xBupGyk8rV61cOZYKXQwNZRN0 kA9uJLSAWD3YS8AdvpZqP8aaFgsb7K9pxLTOIzedS33tDObbcvqQikt9T8YGJ0eNWydroDC+QZD zIq7LNhNgqdkxHtDa5ePf1dcsEM3USYQwhVS6kkU3yBsToVA1gZC21z6Tt0xbq9FrWfXLkxetBJ 9Oe3X/etFiKO2VjtFLkpMiYLdebpsBig X-Google-Smtp-Source: AGHT+IHwMvg7Jgf3gyg3QM1Kx9E3XAxotqb6sHHRIgnXn8fANxuPm4B1kK/hetMxfb3Gw+V7wK2sUQ== X-Received: by 2002:a17:907:3f0b:b0:aa6:ab70:4a78 with SMTP id a640c23a62f3a-ab38b44de69mr2046519966b.37.1737506392922; Tue, 21 Jan 2025 16:39:52 -0800 (PST) Received: from ?IPV6:2001:67c:2fbc:1:2b1b:6df9:ad3c:c183? ([2001:67c:2fbc:1:2b1b:6df9:ad3c:c183]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dbe6de509esm1159790a12.70.2025.01.21.16.39.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2025 16:39:51 -0800 (PST) Message-ID: <6f907895-4f5f-450f-8aa7-709625e4bb25@openvpn.net> Date: Wed, 22 Jan 2025 01:40:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v18 20/25] ovpn: implement peer add/get/dump/delete via netlink To: Sabrina Dubroca Cc: netdev@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Shuah Khan , ryazanov.s.a@gmail.com, Andrew Lunn , Simon Horman , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Xiao Liang References: <20250113-b4-ovpn-v18-0-1f00db9c2bd6@openvpn.net> <20250113-b4-ovpn-v18-20-1f00db9c2bd6@openvpn.net> Content-Language: en-US From: Antonio Quartulli Autocrypt: addr=antonio@openvpn.net; keydata= xsFNBFN3k+ABEADEvXdJZVUfqxGOKByfkExNpKzFzAwHYjhOb3MTlzSLlVKLRIHxe/Etj13I X6tcViNYiIiJxmeHAH7FUj/yAISW56lynAEt7OdkGpZf3HGXRQz1Xi0PWuUINa4QW+ipaKmv voR4b1wZQ9cZ787KLmu10VF1duHW/IewDx9GUQIzChqQVI3lSHRCo90Z/NQ75ZL/rbR3UHB+ EWLIh8Lz1cdE47VaVyX6f0yr3Itx0ZuyIWPrctlHwV5bUdA4JnyY3QvJh4yJPYh9I69HZWsj qplU2WxEfM6+OlaM9iKOUhVxjpkFXheD57EGdVkuG0YhizVF4p9MKGB42D70pfS3EiYdTaKf WzbiFUunOHLJ4hyAi75d4ugxU02DsUjw/0t0kfHtj2V0x1169Hp/NTW1jkqgPWtIsjn+dkde dG9mXk5QrvbpihgpcmNbtloSdkRZ02lsxkUzpG8U64X8WK6LuRz7BZ7p5t/WzaR/hCdOiQCG RNup2UTNDrZpWxpwadXMnJsyJcVX4BAKaWGsm5IQyXXBUdguHVa7To/JIBlhjlKackKWoBnI Ojl8VQhVLcD551iJ61w4aQH6bHxdTjz65MT2OrW/mFZbtIwWSeif6axrYpVCyERIDEKrX5AV rOmGEaUGsCd16FueoaM2Hf96BH3SI3/q2w+g058RedLOZVZtyQARAQABzSdBbnRvbmlvIFF1 YXJ0dWxsaSA8YW50b25pb0BvcGVudnBuLm5ldD7Cwa0EEwEIAFcCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AFCRWQ2TIWIQTKvaEoIBfCZyGYhcdI8My2j1nRTAUCYRUquBgYaGtwczov L2tleXMub3BlbnBncC5vcmcACgkQSPDMto9Z0UzmcxAAjzLeD47We0R4A/14oDKlZxXO0mKL fCzaWFsdhQCDhZkgxoHkYRektK2cEOh4Vd+CnfDcPs/iZ1i2+Zl+va79s4fcUhRReuwi7VCg 7nHiYSNC7qZo84Wzjz3RoGYyJ6MKLRn3zqAxUtFECoS074/JX1sLG0Z3hi19MBmJ/teM84GY IbSvRwZu+VkJgIvZonFZjbwF7XyoSIiEJWQC+AKvwtEBNoVOMuH0tZsgqcgMqGs6lLn66RK4 tMV1aNeX6R+dGSiu11i+9pm7sw8tAmsfu3kQpyk4SB3AJ0jtXrQRESFa1+iemJtt+RaSE5LK 5sGLAO+oN+DlE0mRNDQowS6q/GBhPCjjbTMcMfRoWPCpHZZfKpv5iefXnZ/xVj7ugYdV2T7z r6VL2BRPNvvkgbLZgIlkWyfxRnGh683h4vTqRqTb1wka5pmyBNAv7vCgqrwfvaV1m7J9O4B5 PuRjYRelmCygQBTXFeJAVJvuh2efFknMh41R01PP2ulXAQuVYEztq3t3Ycw6+HeqjbeqTF8C DboqYeIM18HgkOqRrn3VuwnKFNdzyBmgYh/zZx/dJ3yWQi/kfhR6TawAwz6GdbQGiu5fsx5t u14WBxmzNf9tXK7hnXcI24Z1z6e5jG6U2Swtmi8sGSh6fqV4dBKmhobEoS7Xl496JN2NKuaX jeWsF2rOwE0EZmhJFwEIAOAWiIj1EYkbikxXSSP3AazkI+Y/ICzdFDmiXXrYnf/mYEzORB0K vqNRQOdLyjbLKPQwSjYEt1uqwKaD1LRLbA7FpktAShDK4yIljkxhvDI8semfQ5WE/1Jj/I/Q U+4VXhkd6UvvpyQt/LiWvyAfvExPEvhiMnsg2zkQbBQ/M4Ns7ck0zQ4BTAVzW/GqoT2z03mg p1FhxkfzHMKPQ6ImEpuY5cZTQwrBUgWif6HzCtQJL7Ipa2fFnDaIHQeiJG0RXl/g9x3YlwWG sxOFrpWWsh6GI0Mo2W2nkinEIts48+wNDBCMcMlOaMYpyAI7fT5ziDuG2CBA060ZT7qqdl6b aXUAEQEAAcLBfAQYAQgAJhYhBMq9oSggF8JnIZiFx0jwzLaPWdFMBQJmaEkXAhsMBQkB4TOA AAoJEEjwzLaPWdFMbRUP/0t5FrjF8KY6uCU4Tx029NYKDN9zJr0CVwSGsNfC8WWonKs66QE1 pd6xBVoBzu5InFRWa2ed6d6vBw2BaJHC0aMg3iwwBbEgPn4Jx89QfczFMJvFm+MNc2DLDrqN zaQSqBzQ5SvUjxh8lQ+iqAhi0MPv4e2YbXD0ROyO+ITRgQVZBVXoPm4IJGYWgmVmxP34oUQh BM7ipfCVbcOFU5OPhd9/jn1BCHzir+/i0fY2Z/aexMYHwXUMha/itvsBHGcIEYKk7PL9FEfs wlbq+vWoCtUTUc0AjDgB76AcUVxxJtxxpyvES9aFxWD7Qc+dnGJnfxVJI0zbN2b37fX138Bf 27NuKpokv0sBnNEtsD7TY4gBz4QhvRNSBli0E5bGUbkM31rh4Iz21Qk0cCwR9D/vwQVsgPvG ioRqhvFWtLsEt/xKolOmUWA/jP0p8wnQ+3jY6a/DJ+o5LnVFzFqbK3fSojKbfr3bY33iZTSj DX9A4BcohRyqhnpNYyHL36gaOnNnOc+uXFCdoQkI531hXjzIsVs2OlfRufuDrWwAv+em2uOT BnRX9nFx9kPSO42TkFK55Dr5EDeBO3v33recscuB8VVN5xvh0GV57Qre+9sJrEq7Es9W609a +M0yRJWJEjFnMa/jsGZ+QyLD5QTL6SGuZ9gKI3W1SfFZOzV7hHsxPTZ6 Organization: OpenVPN Inc. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/01/2025 12:48, Sabrina Dubroca wrote: [...] > With the delayed socket release (which is similar to what was in v11, > but now with refcounting on the netdevice which should make > rtnl_link_unregister in ovpn_cleanup wait [*]), we may return to > userspace as if the peer was gone, but the socket hasn't been detached > yet. > > A userspace application that tries to remove the peer and immediately > re-create it with the same socket could get EBUSY if the workqueue > hasn't done its job yet. That would be quite confusing to the > application. > > So I would add a completion to wait here until the socket has been > fully detached. Something like below. > > [*] I don't think the current refcounting fully protects against that, > I'll comment on 05/25 Sabrina, after the other changes I acknowledged, do you still have comments for 5/25? Thanks a lot! Regards, -- Antonio Quartulli OpenVPN Inc.