From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03E281CCEFC for ; Wed, 4 Sep 2024 14:51:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725461517; cv=none; b=k3rzVHEOoMvX606us2ZlbM3syPnKLnhpbnX1IvPD9QhGuOSDTN7uEEi7yelIUuCUbDHP0vIsAY9fkB/zH88kxnfNvhOCLWTG/GQjrISR8/Od1F7AE0tD0PRwBM2AaydqEbCteYIbTkVl+0mqjaV2Db89kVDympZXVeXv1zUTaLM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725461517; c=relaxed/simple; bh=ZV4bjcd1yVb9I8n+Wb7M4c70xmHeXcQXOcpIq85B9dw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sdgp6rb2kJDgcm1Bim43R9TWco4gvrTU23PpxFHyToQqT3SnrNwpuBd3cpnsHteQj5nuJ8XEvQl5L6oOtwOWXbvpys5/aJ6a4Lg+sh2BfT9JSsR1g4Z0Rm436dM41tIz/eCj5vU2lvdb2nADhJfzVKgxLoWU221JgX4UijwEtLU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uSP/aT0s; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uSP/aT0s" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5334c018913so6369002e87.0 for ; Wed, 04 Sep 2024 07:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725461514; x=1726066314; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I3Zj/0oIQoWTqTF5i+8OqjuVpe0UWAOmwxaLu2EWaqw=; b=uSP/aT0sYeDvBwtWbxltmyP26ddavrcPN7w2LyE5J4d5GGpmm3dTzy/ZcBEFg5CZWF nRkplDb1bOGm66bDadQcKmEcz07QTJAzlZE0O0PbTS4DthZewnNIg5RLkLp9zyQGSmNH clVU9MrikQaR5pcziUontm+JYqSF0czIKFqVtBnozy199Y8sbv7KOu+sVKtPZQ5mz9nS QG03ChAmSvSxobNFuq6QfVZU83tqugDni/pvlWD61Id2Bvv/qSXE2ZyRdMI9lgzRCErM 25MzQTxqzUDmGgf4lSyBiAGd9gsyPHQMKg+/6qKnY7D7sKpyCaxcdB2V4y3fSQ/ua9Fq 0J4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725461514; x=1726066314; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I3Zj/0oIQoWTqTF5i+8OqjuVpe0UWAOmwxaLu2EWaqw=; b=mbd964j5Ha7K0ad/mbDvR11GTIyXZlW5vXxmAUesCo95MuEM8Kltws79YDi2sREpXb DKrW+Vuuq6UvbIwnd8jYHGBwy7YkzBAUq2P9BuSYzyVXPuXAwS6ykqylP2wzqxWF6z3H pd2cO7/2p93Ccs0B4UQ/WoRpOjJgXdo4zFRuRZxU66B/zaDhm6VaTAYWNDNyFi7xZ7qO qhmqo7OLNJ0k8VYuwdDgpp/dKjeNbGBmGfYuPgn1+9JUc7moBVsvKLtZiC48JQMeCPs4 qsOEOYncYT8i6yJtyYcz8Wut44CiiVzfV/2wcqwx3BWrxHcjKHglXqVxRoAR7k2Ph8gX YqVQ== X-Forwarded-Encrypted: i=1; AJvYcCUmB5IPzhwHBfHFbn08koXowpePKqnEp2Vyw3WcKnwimsyNF3+eI3wOog7j39iRLQtl/EghF/dCIRJG8X4=@vger.kernel.org X-Gm-Message-State: AOJu0YydErXx+DGWS/nRQ+htJ/aafBPhO+V6OS6tNFwzf9LtHmZNb1P3 BbKlcLQKRvkm6GuREJ3mJgK/Es+JlciQUdrfl6ljJG3kfrbi6vjlVqKlycmmbrA= X-Google-Smtp-Source: AGHT+IFkqigaaN4wMGLBNJtAdSFzX1aKYyL8ehUt6BR57k4XcYMiCACdw9hdTrqWngLObGFcFo5oGA== X-Received: by 2002:a05:6512:3190:b0:533:4820:275a with SMTP id 2adb3069b0e04-53546bbfec9mr12860116e87.52.1725461513856; Wed, 04 Sep 2024 07:51:53 -0700 (PDT) Received: from [192.168.0.25] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a623e67desm1021766b.209.2024.09.04.07.51.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 07:51:53 -0700 (PDT) Message-ID: <6f9b7047-7471-4fdf-89ae-d78c1c92690a@linaro.org> Date: Wed, 4 Sep 2024 15:51:52 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/13] media: qcom: camss: csiphy: Add an init callback to CSI PHY devices To: Depeng Shao , Vladimir Zapolskiy , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com References: <20240812144131.369378-1-quic_depengs@quicinc.com> <20240812144131.369378-5-quic_depengs@quicinc.com> <3cdd7101-ae8c-45c9-9695-f7f4202d1edb@linaro.org> <7fb34b98-7bc0-43fb-a6e7-dee073fed317@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <7fb34b98-7bc0-43fb-a6e7-dee073fed317@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/09/2024 15:20, Depeng Shao wrote: > Hi Bryan, > > On 8/19/2024 8:17 AM, Vladimir Zapolskiy wrote: >> On 8/12/24 17:41, Depeng Shao wrote: >>> From: Bryan O'Donoghue > >> I've already expressed concerns about a necessity of this function, >> since it >> adds runtime burden of work, which can be successfully done at compile >> time, >> but okay... >> >> Since it is needed for 3PH case only, it may make sense to remove it >> from 2PH >> and call it here conditionally like >> >>      if (csiphy->res->hw_ops->init) >>          ret = csiphy->res->hw_ops->init(csiphy); >> >> But it's up to you, I hope the callback will be removed in short future. >> > > Could you please comment on if it is fine to remove the init from 2PH > driver? > > > Thanks, > Depeng Yes, its dead code ATM we can enumerate this callback when/if its needed. Agreed. --- bod