From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B715DC6778C for ; Tue, 3 Jul 2018 19:16:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7346821A59 for ; Tue, 3 Jul 2018 19:16:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7346821A59 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934518AbeGCTQs (ORCPT ); Tue, 3 Jul 2018 15:16:48 -0400 Received: from mga12.intel.com ([192.55.52.136]:38985 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105AbeGCTQq (ORCPT ); Tue, 3 Jul 2018 15:16:46 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 12:16:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,304,1526367600"; d="scan'208";a="63877174" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga002.fm.intel.com with ESMTP; 03 Jul 2018 12:16:44 -0700 Message-ID: <6f9e75b62b5e93b28694e6dac2abf0a398ee3dc1.camel@linux.intel.com> Subject: Re: [PATCH] i2c: designware-pcidrv: Mark expected switch fall-through From: Andy Shevchenko To: "Gustavo A. R. Silva" , Jarkko Nikula , Mika Westerberg Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 03 Jul 2018 22:16:43 +0300 In-Reply-To: <20180703191055.GA30768@embeddedor.com> References: <20180703191055.GA30768@embeddedor.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-07-03 at 14:10 -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. Acked-by: Andy Shevchenko > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/i2c/busses/i2c-designware-pcidrv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c > b/drivers/i2c/busses/i2c-designware-pcidrv.c > index 86e1bd0..b4997be 100644 > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c > @@ -105,6 +105,7 @@ static int mfld_setup(struct pci_dev *pdev, struct > dw_pci_controller *c) > case 0x0817: > c->bus_cfg &= ~DW_IC_CON_SPEED_MASK; > c->bus_cfg |= DW_IC_CON_SPEED_STD; > + /* fall through */ > case 0x0818: > case 0x0819: > c->bus_num = pdev->device - 0x817 + 3; -- Andy Shevchenko Intel Finland Oy