From: Logan Gunthorpe <logang@deltatee.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com,
Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 4/8] NTB: ntb_pingpong: Choose doorbells based on port number
Date: Fri, 15 Jun 2018 13:56:28 -0600 [thread overview]
Message-ID: <6fab7e2b-e7aa-8e67-a318-5ce790677c0d@deltatee.com> (raw)
In-Reply-To: <20180615194929.GA24025@mobilestation>
On 15/06/18 01:49 PM, Serge Semin wrote:
> Regarding the patch. The idea of using the port number instead of linearised
> unique index should also work for Intel/AMD/IDT drivers. But the ports-space
> linearization algorithm was created for the case if the real port numbers
> would exceed the available Doorbell bits. I thought this might be the case of
> multi-ports version of the switchtec driver.
Well, the switchtec driver splits its 64 doorbells in two sets, one for
each port right now. That will likely have to change when we go to a
multi-port implementation. In that case we will have 64 doorbells and a
maximum 48 ports. So I don't think we have to concern ourselves with
more ports than doorbells.
> Needless to say, that if Switchtec driver had the ports-index API implementation,
> this patch wouldn't be needed.
As I've said, it's impossible to write for the crosslink topology so the
clients must support that case.
Logan
next prev parent reply other threads:[~2018-06-15 19:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-09 0:08 [PATCH 0/8] Fix breakage caused by the NTB multi-port patchset Logan Gunthorpe
2018-06-09 0:08 ` [PATCH 1/8] NTB: ntb_tool: reading the link file should not end in a NULL byte Logan Gunthorpe
2018-06-15 19:47 ` Serge Semin
2018-06-09 0:08 ` [PATCH 2/8] NTB: Setup the DMA mask globally for all drivers Logan Gunthorpe
2018-06-11 20:51 ` Dave Jiang
2018-06-12 15:48 ` Jon Mason
2018-06-12 16:18 ` Logan Gunthorpe
2018-06-09 0:08 ` [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers Logan Gunthorpe
2018-06-12 15:59 ` Jon Mason
2018-06-12 16:30 ` Logan Gunthorpe
2018-06-15 19:48 ` Serge Semin
2018-06-15 19:51 ` Logan Gunthorpe
2018-06-09 0:08 ` [PATCH 4/8] NTB: ntb_pingpong: Choose doorbells based on port number Logan Gunthorpe
2018-06-15 19:49 ` Serge Semin
2018-06-15 19:56 ` Logan Gunthorpe [this message]
2018-06-09 0:08 ` [PATCH 5/8] NTB: perf: Don't require one more memory window than number of peers Logan Gunthorpe
2018-06-15 19:49 ` Serge Semin
2018-06-09 0:08 ` [PATCH 5/8] NTB: perf: Don't require one more memory window than peer Logan Gunthorpe
2018-06-09 0:09 ` Logan Gunthorpe
2018-06-09 0:08 ` [PATCH 6/8] NTB: perf: Fix support for hardware that doesn't have port numbers Logan Gunthorpe
2018-06-15 19:50 ` Serge Semin
2018-06-15 20:01 ` Logan Gunthorpe
2018-06-09 0:08 ` [PATCH 7/8] NTB: perf: Fix race condition when run with ntb_test Logan Gunthorpe
2018-06-15 19:51 ` Serge Semin
2018-06-15 20:00 ` Logan Gunthorpe
2018-06-09 0:08 ` [PATCH 8/8] NTB: ntb_test: Fix bug when counting remote files Logan Gunthorpe
2018-06-15 19:51 ` Serge Semin
2018-06-15 20:02 ` Logan Gunthorpe
2018-07-20 16:33 ` Logan Gunthorpe
2018-06-10 1:45 ` [PATCH 0/8] Fix breakage caused by the NTB multi-port patchset Allen Hubbe
2018-06-15 19:47 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fab7e2b-e7aa-8e67-a318-5ce790677c0d@deltatee.com \
--to=logang@deltatee.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome