mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tor Vic <torvic9@mailbox.org>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-i2c@vger.kernel.org
Cc: benjamin.bara@skidata.com
Subject: Re: [Bug Report] [6.6] i2c: No atomic i2c transfer handler
Date: Fri, 1 Dec 2023 13:26:08 +0100	[thread overview]
Message-ID: <6fb5d126-1c66-412a-a1a2-6c4e5725f7fb@mailbox.org> (raw)
In-Reply-To: <621c7d60-8953-1d7e-b4a1-f4fc510ba9d6@collabora.com>



On 12/1/23 12:50, Dmitry Osipenko wrote:
> On 12/1/23 13:48, Tor Vic wrote:
>> Hi,
>>
>> Since Linux 6.6.3, I see some warnings in the late phase of shutdown.
>> Unfortunately, they are not logged because syslog has already shut down
>> at that point.
>>
>> I used a camera to capture a small part of the warnings:
>>
>>    No atomic I2C transfer handler for 'i2c-0'
>>    [trace follows]
>>    i2c_smbus_xfer
>>    [...]
>>
>> After checking the changelog, the culprit was found quickly:
>>
>>    (3473cf43b) i2c: core: Run atomic i2c xfer when !preemptible
>>
>> Reverting that commit made the warnings go away.
>>
>> This is a voluntary preemption kernel running on a Skylake laptop.
>>
>> Please tell me if you need more info.
> 
> The warning says that I2C bus driver used by your laptop doesn't support
> atomic transfers while it should. Which driver it is?

'i2c-0' is
SMBus [0c05]: Intel Corporation Sunrise Point-LP SMBus
using 'i801_smbus' driver.

> 
> In your case the warning is harmless, still the I2C driver likely needs
> to be improved.
> 

That's good news, I was a little worried because of the several (I think 
it was 3 in total) large warning splats.

      reply	other threads:[~2023-12-01 12:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01 10:48 Tor Vic
2023-12-01 11:50 ` Dmitry Osipenko
2023-12-01 12:26   ` Tor Vic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fb5d126-1c66-412a-a1a2-6c4e5725f7fb@mailbox.org \
    --to=torvic9@mailbox.org \
    --cc=benjamin.bara@skidata.com \
    --cc=dmitry.osipenko@collabora.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®