From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32ED73A7827 for ; Mon, 9 Mar 2026 11:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773056924; cv=none; b=cNaXZiU5Vo4WCgsfLnEBZvHa7CbLM3us3tigs25JM4PfKl/mVSIRxGcZ2Za7j4kY0F6pV/buJ9qsTs0ILhYGeM4BCGdZ82azAjEeAfPac27vUYr5zr4aAz158EkmZHqaWjNsGSiyijOat3m04sbduiM0OXUx+L4xGq3GvFdolV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773056924; c=relaxed/simple; bh=PSAtaabDHOBf7+GnO4Oo5se4Ft7UAUwgseGnnqtgjZ4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZIl9scDN2NUJihd++PecC4tvOWJKgqQJDKf5OnlV4RRE/84WqFg804Ca2yrI3+Vk0US3VnzSSD8rS7nazol6VqXI8KNbixp8eYrwoonnvuin6jZ3/uIMa+A1G33jLLupPC3uogJtszyRkn/0GN68pWD04iDeMPEU9TRoMROK70Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nh/djnMY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GmkzfSk2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nh/djnMY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GmkzfSk2" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629A6dxD2195107 for ; Mon, 9 Mar 2026 11:48:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4plS8DiT8nd8Y8ivbbOmNRR2e17OUs340VYiwNRUAU8=; b=nh/djnMYrVI/XTG3 8jglzIziPGZDErYJLD5mVwRS9GyvjMQO7Qo99zb3ox+/6+xYKkD3lnZdNX9ypGfk g+zS84wA9qyhzCb4JU95SPDxThFD1tXYUdN+HFNh9b/XduwQq1WucC+24mJ9X4EW ud9iJCssKGnim6qb2FZUA51vvkJbJbZGl7bgvI0MJJn0GtU5YewtQBUMTqyGAXxI tdFHgu2cDYlOISs5hw4vEkc9PvXjdNVBbako45JUH2uxmkQgVlcUC21AY0gbVmne vQprZwxUXdZf2FN5iSL+9CNPmckrlLNlIiTOPwVlLD+7cdxLp7bdB+rDlrWAi9Qh PG+LUQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csv5u8ads-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 11:48:39 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-89a09f050feso40159906d6.1 for ; Mon, 09 Mar 2026 04:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773056919; x=1773661719; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4plS8DiT8nd8Y8ivbbOmNRR2e17OUs340VYiwNRUAU8=; b=GmkzfSk2FtDBVFp3Md4375MezWWHx7khnHCrdwPnkBOree5ydWh9JxyZWB+sCrEnhG Z7stqiVciOQZDe1e92z6p1Z0HUxMEqc8yLJxiAcJqkbmzqW14OttQY8BopIdzJ8t1eJX Ti1f+EVQvs9eAYKYFYNN6SfxGjYazBhHM7xulc6Q5FsTJaAibF9dN/Xv5k3vPE/tmte3 4UkIlfMJzJJmSxJQgYUzOknn0f2rJ+WqghX8MlhPaMO74BM73sh7AwP6mLf1Iyuaj+Ba hHk8s0Jxaceh561do9Xg1YfqZKzAFtUpl6vtcmDc6nMxIVpgbc1Y9coxRUzrBdEFJbBt QXEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773056919; x=1773661719; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4plS8DiT8nd8Y8ivbbOmNRR2e17OUs340VYiwNRUAU8=; b=g1bKJm6SKMwJKQQDsMewiBJbBmnk0H/dB0TDDRb3XJzFJUbjTsIFtG3nZXCZQ8+V2O J/5LfEa6yZxhhMqAJG+T4K/Tlt/F5xTlOsIImsZxqnYEgU/hHV68Yx6rY4EMTBkVmRQQ xj4hbOULlRqGOpmGqFMHnjYwPUdFJEjAFo4SDEKKEznGeD7O7DlYEtuSKiacqB/JISMF F1okGHyIPiyAfUz3Plu/gGE9Og5ZBiWoCifpBCIxhh6ulIDhG0LxcVNMe0e2U6lMyHRd 9OwJ0UciclCuPrDtEkC3t31v0hERle6EX7EbB111nMaH3+5jJ9adsGq9sgAQv0sA40zs kRQg== X-Forwarded-Encrypted: i=1; AJvYcCXUyrJMqzlxDyRgGTgBMGn8VlOgkUs6jgRjp3A6OPUEWjBwDqoGg37yXppekKh4IjcOg1G6CgJNR3rxkfk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/KoHgYlR1zn2mEyInjH7B88HMUMMnad6LH/Uwic+vw8bdT5ri HS1mJLom1nPAqRZ2UtMBOWtf4EADLFkEBdhBwpUJao0YRcCTBWfP6gOt97eL7IXxUg0quWPaGgO fwwf5q0TRYSVSU4O6AT5UwIonsmk6A8ruAH9an0QslTTLif0S/wSrwi0M9ZQMXP3MQ5I= X-Gm-Gg: ATEYQzw9DHIrvGL8DgSFx5nOvm3wFk9I5FmFHd00M5CpEVp/hVSDUKN6i1GZnQuF26L S3+6AchEK6X1pjpkyDI9G+kmyE6qSaJ1dnPTeitqYIvD1IIAYccOYzLaGIgdA5MpA/0oEU1l/OW ljWlbAeFzhWsbtlaL71yVMZPRocWVtqRArvhP7Xvhtj7dMpI1CyYGmmehXuEq6ObOC5kXaWBNe2 UmDGMki8AYcqgllKbXxdMhNN0iRvcI1PZRUfkEuNlCl49ocDV1FhKFsuSz4Bv80YiMF3Rb1RwST n28iWEPiI/on2vj7t6E4Pf/9RP6c8hh8VkrwIsjg2y+iikxo6SaBJGP0VBk0e4Ln8ByzRi6F5Tr dv49JZ9oYFrcVP8DGtl/vXmlzjadud832RTmoKQNIObx1GJ9fQdAllwEZwqk94HJhOH1SL2BOiq k0igA= X-Received: by 2002:a05:6214:4413:b0:89a:44d7:6591 with SMTP id 6a1803df08f44-89a44d76b9fmr59337476d6.4.1773056919223; Mon, 09 Mar 2026 04:48:39 -0700 (PDT) X-Received: by 2002:a05:6214:4413:b0:89a:44d7:6591 with SMTP id 6a1803df08f44-89a44d76b9fmr59337136d6.4.1773056918803; Mon, 09 Mar 2026 04:48:38 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b942ef8a861sm361026366b.16.2026.03.09.04.48.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2026 04:48:37 -0700 (PDT) Message-ID: <6fb8cc16-d339-4913-b1d7-5d114f0a1ed6@oss.qualcomm.com> Date: Mon, 9 Mar 2026 12:48:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 4/5] arm64: dts: qcom: x1-crd: Add Embedded controller node To: Krzysztof Kozlowski , Sibi Sankar Cc: robh@kernel.org, krzk+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, bryan.odonoghue@linaro.org, ilpo.jarvinen@linux.intel.com, hansg@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20260308233646.2318676-1-sibi.sankar@oss.qualcomm.com> <20260308233646.2318676-5-sibi.sankar@oss.qualcomm.com> <20260309-festive-prudent-ibex-f8b601@quoll> <3eaceb96-003b-47d2-9ae5-bb676dde0240@kernel.org> <441a72fc-b81b-4fb6-b032-867752b3c773@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <441a72fc-b81b-4fb6-b032-867752b3c773@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 0vRJ-TdG72OUbUt6KzzxRm-hSO_Ls2Jm X-Proofpoint-ORIG-GUID: 0vRJ-TdG72OUbUt6KzzxRm-hSO_Ls2Jm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDEwOCBTYWx0ZWRfX3ovvck/pPuj+ zk7dbjCv8ouuZdWHYDSvdhPfWvruI1lQqnSkPzLuPMcs2lxFilnSS3s2VXk3rwdRiUNXpfL7YaY YBbz9i4ozu0fpi9B0/mQCY+ug7RCQwuGriJbFrWulnjGu3wwAbhoFNV+8AcwB5JbYPYxLLuDv1T ylYlEQqAdd2V+/+PTfdv2JwRQWUR5DCo13uQdsDFjNPZiPN2I+CIofil/g5cdq4kb3mUmX1FvLX VO+7x79tg3wR0bINVhXVY8h1yrmi9D5JfgrPxjPlXaSGgJeaudUQ8khAh+/rcpZ/3oFp9oLkG9b gSidaMEQ271PHTR3AJzTEBb7fnbVbT2o+/sw16Uj3IL35g50E+nZLOqHLzTsEFe0PIbgZcOhX7X wMA8xgFJQX7rScmunv8vBi+JDZTjkPZ7CWfZ+Lse6v14yVMaW0Ins9N/B7fI59Z16VdmRB4K/9R W6pisTFeMCBM9COSaLQ== X-Authority-Analysis: v=2.4 cv=Xr/3+FF9 c=1 sm=1 tr=0 ts=69aeb397 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=CZwadPU-L3mGcov22fYA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_03,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 spamscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090108 On 3/9/26 11:53 AM, Krzysztof Kozlowski wrote: > On 09/03/2026 11:51, Sibi Sankar wrote: >> >> On 3/9/2026 2:39 PM, Krzysztof Kozlowski wrote: >>> On 09/03/2026 10:03, Sibi Sankar wrote: >>>> On 3/9/2026 12:55 PM, Krzysztof Kozlowski wrote: >>>>> On Mon, Mar 09, 2026 at 05:06:45AM +0530, Sibi Sankar wrote: >>>>>> Add embedded controller node for Hamoa/Purwa CRDs which adds fan control, >>>>>> temperature sensors, access to EC internal state changes and suspend >>>>>> entry/exit notifications to the EC. >>>>>> >>>>>> Signed-off-by: Sibi Sankar >>>>>> --- >>>>>> arch/arm64/boot/dts/qcom/x1-crd.dtsi | 16 ++++++++++++++++ >>>>>> 1 file changed, 16 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi >>>>>> index ded96fb43489..29a1aeb98353 100644 >>>>>> --- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi >>>>>> +++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi >>>>>> @@ -1042,6 +1042,16 @@ eusb6_repeater: redriver@4f { >>>>>> >>>>>> #phy-cells = <0>; >>>>>> }; >>>>>> + >>>>>> + embedded-controller@76 { >>>>>> + compatible = "qcom,hamoa-it8987-ec", "qcom,hamoa-ec"; >>>>> I don't see updates to other x1e boards, thus my arguments from v2 stay >>>>> valid. It's wrong to call it "hamoa-ec" since only one Hamoa board has >>>>> it. All of other Hamoa boards apparently do not have it. >>>> >>>> Hey Krzysztof, >>>> Thanks for taking time to review the series :) >>>> >>>> What other Hamoa boards are you referring to? The series >>>> mentions that the driver and bindings is meant for Qualcomm >>>> Hamoa/Purwa/Glymur "reference" devices, so it only covers >>>> CRD and IOT-EVK. It definitely does not cover all Hamoa boards >>>> boards like you are assuming. >>> hamoa-ec compatible implies that and that's something I raised in v2 >>> already. You need a specific compatible. >> >> >> Hamoa/Glymur reference devices can have different EC MCUs >> depending on the SKU. This introduces the need to deal with >> possibility of quirks and bugs introduced by these differences. >> Hamoa/Purwa CRDs and IOT EVK runs on IT8987, while Glymur >> reference devices run on NPCX498/488. This pretty much was > > None of these answer my comments from here and v2. > >> the rationale to make the MCU part of the compatible. Anyway >> I can keep it as qcom,hamoa-ec and qcom,glymur-ec for now > > No. You cannot add a generic compatible when you claim it is not even > correct - "different EC depending on the SKU". I agree, this name isn't really the best. We don't really have a better "official one" though. Perhaps something like "qcom,compute-ec"? "qcom,reference-compute-ec-that-happens-to-be-found-on-boards-featuring- hamoa-glymur-and-derivative-socs-running-windows-by-design"? Konrad