From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0839CC48BD1 for ; Wed, 9 Jun 2021 13:57:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E14EF61246 for ; Wed, 9 Jun 2021 13:57:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236874AbhFIN7E (ORCPT ); Wed, 9 Jun 2021 09:59:04 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:43791 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236026AbhFIN7C (ORCPT ); Wed, 9 Jun 2021 09:59:02 -0400 Received: from mail-wr1-f72.google.com ([209.85.221.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lqyhf-0001jr-C0 for linux-kernel@vger.kernel.org; Wed, 09 Jun 2021 13:57:07 +0000 Received: by mail-wr1-f72.google.com with SMTP id s8-20020adff8080000b0290114e1eeb8c6so10801097wrp.23 for ; Wed, 09 Jun 2021 06:57:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=94MTmrJjy+QuCQp+H85bF1V9qIA+ZZgrzOcpkBB5S9M=; b=SldcgeZNKNjjJf/Nb4l8Rr7fyqMN2+4Qki9nxCBbW0qYGhHwipQ1z2w/xIzEMixRNg uXbf9PXPG00TSvOnA/EwPOny1Il/FmBmIdXPFZwDP6b2kAexSsgqV9bRWSy5vZ02xgCu w91GBjrsa4c4b/PHZIpLmFwbGEtKfWjYGAwFOBH7Xa/5IjYGSP7DP+GeLn2ImLLQlEGn uDK/uHKJEaAQ8ZtQkdSpF433GxsK0ph1Y9jDDJouTgaAuQNHzGsd8+782jqnBAp5ZZnT PITDFfcbL6r273YKNogRjrxomfL+hcaLENRQVSyfYTQJhsH52OQCXDUsTDHI056wHdSx zaug== X-Gm-Message-State: AOAM532GGFT4+8nwrTTHp2RuF5fmwkg4IiwF5Ad8ixh4BUsAPbYkiPvb GhDoGr1QnmJKV2TQtpacz1Fodb/if5ZuPrznO1k5g2ThUQOmbZ9e3olA7jeY8j6ARgDAoqUzvRM KUjfLot0bquxAoWkNKj9HZ665qa8Ot8ChMhrjhPFenA== X-Received: by 2002:a05:600c:22cf:: with SMTP id 15mr28210711wmg.144.1623247026700; Wed, 09 Jun 2021 06:57:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnMkKQ1aeaiRBj9+JK4EwMsgwWT/6OvveUSFlZdu8TfcqICkeqyGjLL1rEQa6Dgw064GW83g== X-Received: by 2002:a05:600c:22cf:: with SMTP id 15mr28210682wmg.144.1623247026518; Wed, 09 Jun 2021 06:57:06 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id q11sm23273791wrx.80.2021.06.09.06.57.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 06:57:06 -0700 (PDT) Subject: Re: [PATCH v22 17/18] dt-bindings: mtd: pl353-nand: Describe this hardware controller To: Miquel Raynal , Rob Herring Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, Michal Simek , Naga Sureshkumar Relli , Amit Kumar Mahapatra , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, helmut.grohne@intenta.de, Srinivas Goud , Siva Durga Prasad Paladugu References: <20210609080112.1753221-1-miquel.raynal@bootlin.com> <20210609080112.1753221-18-miquel.raynal@bootlin.com> <57ef16cd-33e7-6c16-3a24-9634f47831b3@canonical.com> <20210609153621.1303bc4d@xps13> From: Krzysztof Kozlowski Message-ID: <6fb9c0e4-43cb-d224-0ebe-568f62ac35b1@canonical.com> Date: Wed, 9 Jun 2021 15:57:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210609153621.1303bc4d@xps13> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2021 15:36, Miquel Raynal wrote: > Hi Krzysztof, > > Krzysztof Kozlowski wrote on Wed, 9 > Jun 2021 14:01:10 +0200: > >> On 09/06/2021 10:01, Miquel Raynal wrote: >>> Add a yaml description of this NAND controller which is described as a >>> subnode of the SMC bus. >>> >>> Signed-off-by: Miquel Raynal >>> --- >>> .../bindings/mtd/arm,pl353-nand-r2p1.yaml | 57 +++++++++++++++++++ >>> 1 file changed, 57 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml >>> new file mode 100644 >>> index 000000000000..e72fa14b4385 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml >>> @@ -0,0 +1,57 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/mtd/arm,pl353-nand-r2p1.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: PL353 NAND Controller device tree bindings >>> + >>> +allOf: >>> + - $ref: "nand-controller.yaml" >>> + >>> +maintainers: >>> + - Miquel Raynal >>> + - Naga Sureshkumar Relli >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >> >> That's not an enum, but simple const without items. > > Ok. > >> >>> + - arm,pl353-nand-r2p1 >>> + >>> + reg: >>> + items: >>> + - items: >>> + - description: CS with regard to the parent ranges property >>> + - description: Offset of the memory region requested by the device >>> + - description: Length of the memory region requested by the device >> >> Doesn't it depend on parent's address/size cells? > > Yes, but as the child nodes are not defined in the parent's binding > (ie. the SMC) I think it's interesting to have them defined here, no? The trouble is if parent decides to have different address/size cells. The schema will stop matching. I am actually not that sure if such case is real since the pl353 NAND part will usually be connected to pl353 SMC. However the schema now hard-codes specific dependency against parent schema/node. Rob, Maybe you have here some thoughts? Best regards, Krzysztof