From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C7CDC2D0D3 for ; Mon, 23 Dec 2019 08:21:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D91CA207FF for ; Mon, 23 Dec 2019 08:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577089266; bh=j9mpvD2vwVqJgqgRO1huDRjRF97+pmAiqRJqpb4yQWo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pVIyekXM//6RzPu3PVQpLNQSABgH7lqxta+YByee3KOh7hRYdxfpA7rMubiq8uqen dECaDSiqLQnwDx+030TyUP1PRUm75fIIjXkFZYW9GbN9YA4HUaNGLAF5RUW2flUSRt 8JY5LPYzf/oJjmL1a4UgoZ2SelfCRZGkgIEo7aq0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726633AbfLWIVD (ORCPT ); Mon, 23 Dec 2019 03:21:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:38654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725855AbfLWIVC (ORCPT ); Mon, 23 Dec 2019 03:21:02 -0500 Received: from localhost (36-236-5-169.dynamic-ip.hinet.net [36.236.5.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11FE320709; Mon, 23 Dec 2019 08:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577089261; bh=j9mpvD2vwVqJgqgRO1huDRjRF97+pmAiqRJqpb4yQWo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JgMk4fE0EfdHV0JXNpb2TasyUXF7PfAmCOc7uF/6HodTzMkS1oOJjyz//vZONpMPF CTxunEVo9DvwQ02weloIIbupCnBwGA2dP8GRrF3HJoITmTCK1dM8t6X+jj+e5Wq0Vp roYfVLl0NQiC3iKV9M78+5ehKLdjrHlMmLrzYxno= From: Andy Lutomirski To: Ted Ts'o Cc: LKML , Linux API , Kees Cook , "Jason A. Donenfeld" , "Ahmed S. Darwish" , Lennart Poettering , "Eric W. Biederman" , "Alexander E. Patrakov" , Michael Kerrisk , Willy Tarreau , Matthew Garrett , Ext4 Developers List , linux-man , Stephan Mueller , Andy Lutomirski Subject: [PATCH v3 1/8] random: Don't wake crng_init_wait when crng_init == 1 Date: Mon, 23 Dec 2019 00:20:44 -0800 Message-Id: <6fbc0bfcbfc1fa2c76fd574f5b6f552b11be7fde.1577088521.git.luto@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org crng_init_wait is only used to wayt for crng_init to be set to 2, so there's no point to waking it when crng_init is set to 1. Remove the unnecessary wake_up_interruptible() call. Signed-off-by: Andy Lutomirski --- drivers/char/random.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/char/random.c b/drivers/char/random.c index cda12933a17d..c6252a3a4aec 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -946,7 +946,6 @@ static int crng_fast_load(const char *cp, size_t len) if (crng_init_cnt >= CRNG_INIT_CNT_THRESH) { invalidate_batched_entropy(); crng_init = 1; - wake_up_interruptible(&crng_init_wait); pr_notice("random: fast init done\n"); } return 1; -- 2.23.0